[Idr] Secdir last call review of draft-ietf-idr-bgp-sendholdtimer-13

Carl Wallace via Datatracker <noreply@ietf.org> Sun, 28 July 2024 15:37 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: idr@ietf.org
Delivered-To: idr@ietfa.amsl.com
Received: from [10.244.2.81] (unknown [104.131.183.230]) by ietfa.amsl.com (Postfix) with ESMTP id 62451C14CF1E; Sun, 28 Jul 2024 08:37:33 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Carl Wallace via Datatracker <noreply@ietf.org>
To: secdir@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 12.19.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <172218105300.1558539.17525621904498066822@dt-datatracker-659f84ff76-9wqgv>
Date: Sun, 28 Jul 2024 08:37:33 -0700
Message-ID-Hash: 3MBRSLV63SNY77CP53NN26WCC3SOVMLF
X-Message-ID-Hash: 3MBRSLV63SNY77CP53NN26WCC3SOVMLF
X-MailFrom: noreply@ietf.org
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-idr.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: draft-ietf-idr-bgp-sendholdtimer.all@ietf.org, idr@ietf.org, last-call@ietf.org
X-Mailman-Version: 3.3.9rc4
Reply-To: Carl Wallace <carl@redhoundsoftware.com>
Subject: [Idr] Secdir last call review of draft-ietf-idr-bgp-sendholdtimer-13
List-Id: Inter-Domain Routing <idr.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/9LcIOtwYjC1Gtz7t-WRjKSdsiQU>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Owner: <mailto:idr-owner@ietf.org>
List-Post: <mailto:idr@ietf.org>
List-Subscribe: <mailto:idr-join@ietf.org>
List-Unsubscribe: <mailto:idr-leave@ietf.org>

Reviewer: Carl Wallace
Review result: Ready

This draft defines the SendHoldtimer and SendHoldTimer_Expires for the BGP
state machine. The draft is straightforward and well written but I had one
minor nit. In section 3.3, there is a NEW block to be added that begins "If the
SendHoldTimer_Expires (Event 29), the local system:". This seems to be
incomplete. From similar text in 4271, one fix would be to put the word
"occurs" before the comma.