Re: [Idr] Secdir early review of draft-ietf-idr-bgp-ls-app-specific-attr-05

"Ketan Talaulikar (ketant)" <ketant@cisco.com> Fri, 21 May 2021 12:17 UTC

Return-Path: <ketant@cisco.com>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4AA243A0AE7; Fri, 21 May 2021 05:17:17 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.595
X-Spam-Level:
X-Spam-Status: No, score=-9.595 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=Oa/1gdyB; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=kmeNbn3N
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z1I38J8mOJPj; Fri, 21 May 2021 05:17:11 -0700 (PDT)
Received: from alln-iport-8.cisco.com (alln-iport-8.cisco.com [173.37.142.95]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 744E33A0AE1; Fri, 21 May 2021 05:17:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2788; q=dns/txt; s=iport; t=1621599431; x=1622809031; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=+84T9kkp7R5mVYI70Wp0re45N1MM5fOzAfivBgbrVV4=; b=Oa/1gdyBCt7Cs8VxNAZ+xAvEa3am6s9WCJSXmELaQ81KAHaPRNO3F/7T mKU6T2ZwA0gndZwIavh3/gTqdgRwT7AcJFYcSO2oiSG6lkvMDKlqrDZ+H OjTez8PK4xasz+eNhh+qPvh+jxKyeHqdsAYoEcjkn1FFIboeiJ5uBfdGn c=;
X-IPAS-Result: A0A7AABfpKdgl4MNJK1aGgEBAQEBAQEBAQEDAQEBARIBAQEBAgIBAQEBQIFXgVNRgVg2MQuEPYNIA4U5iHcDgQ2YbIJTA1QLAQEBDQEBPwIEAQGETwIXgWcCJTgTAgQBAQEBAwIDAQEBAQUBAQUBAQECAQYEFAEBAQEBAQEBaIVoDYZEAQEBBCMRDAEBNwELBAIBCBEEAQEDAiYCAgIwFQgIAgQBDQUIgmmCVgMvAU2dTgKKH3qBMoEBggcBAQYEBIU4GIITCYEQKgGCeoQOhlonHIFJRIEVQ4IpNj6ERYMVNoItgkQGAjwmAQMNNg4iMAcoGXoBGJR8pgmBDAqDF5gShWARg1qLGZZXlTqfNoRiAgQCBAUCDgEBBoEjSCKBW3AVgyRQFwIOjh8Zg1eKXXM4AgYKAQEDCXyHQQGBEAEB
IronPort-PHdr: A9a23:eVbbmRJqahsO596ZUNmcuXsyDhhOgF28FggS6pM7kPRFe/fr85fjO RnZ4vNgxB/MUJ7A4v1Jw+zRr+j7WGMG7JrA1RJKcJFFWxIfz8lDmQsmDZ2DDk3yMOWsZCVpV MhHXUVuqne8N0UdEc3iZlrU93u16zNaGhj2OQdvYOrvHYuHhMWs3Of08JrWMG11
IronPort-Data: A9a23:jEBVDaIgKATOb6+RFE+Rr5UlxSXFcZb7ZxGr2PjKsXjdYENS1WdWz 2ZJXj2OMq6ONmX0edlwOY2zoB8B65ODnYdmTFQd+CA2RRqmiyZq6fd1j6vUF3nPRiEWZBs/t 63yUjRDRSwNZie0Si2FatANllEhk/HSLlbAILScYHkpGFU9EH5JZS9LwobVvKY52bBVPCvV0 T/Ci5W31IiNgmMc3so8sspvmTs31BjAkGpwUm8WOZiniGTje0w9V/rzE00ew0zQGeG4FsbiL wrKISrQEmnxp3/BAfv9+lr3n9FjrrP6ZWCzZnRqt6eKhAJQpxFqlYACCrkmVQBSzDm3wdVKx 4AY3XCwYV9B0qzkkeAZVVxTFDtzePQA877cKn/5usuWp6HEWyKzmLM1UgdvZstBob8f7WJmr ZT0LBgOYwyKgf6ey7OgQe4qjcMmRCXuFNxG5yA5kW6BV57KR7jxHImW4v1z4QwCrfhqEOzyS uUTWz1wOUGojxpnYwdLV81WcP2TrnjzaRVZpU6b460t7AD7wBZ43qSoMdfJdJmLSd8QlEmA4 2bdum3hGlQBLNGUyDSE+TelmvPV2yr/XKoTGaG2sPlwjzW73WEYBBwMfVq2vff/jVSxM/pHI lEQ0iwpraEu7wqgR7HAswaQqXqAuFsXXMBdVrR84wCWwa2S6AGcboQZctJfQNo8ps4LHXsM7 2HKpe+uAHtjjuOQcn3Io994sgiO1TgpwX4qPHFeFFFUsoi6+OnfnTqUFY4ySv7dYsndXGCun WzX8EDSkp1O1aY2O7OHEUcrat5GjrHNSgMzjuk8dj34tlsjDGJJinDB1LQ2xf9EKIDcRV6bs T1d8yR/0AzsJczW/MBuaLxQdF1M2xpjGGaN6bKIN8J+nwlBA1b5IehtDMhWfS+FyPronAMFh meN5Gu9A7cNZROXgVNfOOpd9uxzl/G7TIS5PhwqRoQePvCdizNrDAk3NRLPgAgBYWAHkLo0P t+gYN2wAHMBYZmLPxLnGrdBgOND+8zK/kuOFMuT50n2jtKjiIu9FO5t3K2mNbhpsstpYWz9r r5iCid940UOCLGhOnGPr+b+7zkidBAGOHw/kOQPHsbrH+asMDhJ5yP5qV/5R7FYog==
IronPort-HdrOrdr: A9a23:S+20dK0NMM4KlQckIKCZGQqjBWdyeYIsimQD101hICG9Lfb4qy n+ppomPEHP5wr5AEtQ5uxpOMG7MBThHO1OkPcs1NCZLUjbUQqTXc9fBO7ZowEIdBeOjdK1uZ 0QFpSWTeeAcWSS7vyKoDVQcexQuuVvmZrA7Yy1ohsdLnAJV0gj1XYFNu/xKDwReOAyP+tAKH Pq3Ls/m9PPQwVyUu2LQl0+G8TTrdzCk5zrJTQcAQQ81QWIhTS0rJbnDhmxxH4lInBy6IZn1V KAvx3y562lvf3+4ATbzXXv45Nfn8ak4sdfBfaLltMeJlzX+0SVjcVaKvi/VQIO0aaSAWUR4Z /xStAbTp1OAkbqDyWISN3WqlHdOXgVmiTfIBSj8AreSITCNUIH4ox69Nhkmt+z0Tt9gDm6u5 g7gl5x/qAnfi/ojWDz4cPFWAptkVfxqX0+kfQLh3gaSocGbqRNxLZvsX+9Pa1wVx4S0rpXWt WGzfusksq+emnqI0wxflMfiOBEe05DUStubnJyzvB94gIm1UyRlXFosfD3tk1wg67VZaM0ld j5Dg==
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-AV: E=Sophos;i="5.82,319,1613433600"; d="scan'208";a="715914702"
Received: from alln-core-1.cisco.com ([173.36.13.131]) by alln-iport-8.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 21 May 2021 12:17:10 +0000
Received: from mail.cisco.com (xbe-rcd-007.cisco.com [173.37.102.22]) by alln-core-1.cisco.com (8.15.2/8.15.2) with ESMTPS id 14LCH91r025945 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=OK); Fri, 21 May 2021 12:17:09 GMT
Received: from xfe-rcd-005.cisco.com (173.37.227.253) by xbe-rcd-007.cisco.com (173.37.102.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Fri, 21 May 2021 07:17:09 -0500
Received: from xfe-aln-004.cisco.com (173.37.135.124) by xfe-rcd-005.cisco.com (173.37.227.253) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Fri, 21 May 2021 07:17:09 -0500
Received: from NAM11-BN8-obe.outbound.protection.outlook.com (173.37.151.57) by xfe-aln-004.cisco.com (173.37.135.124) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15 via Frontend Transport; Fri, 21 May 2021 07:17:09 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SmTH7sJ5vC7nR21/ifyPRjfH4f0XhJVHOUY+kVNQPTlajjHP6AoXkDbg61ko4af8qx6fwrnsCEhgWpE4rhjifzdXLLq2jq/s5j96AkGTFO0zjRkicAnjiatuZN/1sjSq+QXRr3IuYO585kP44VDGlKyKCdvKEowSqGtcCo6ISrh5c7ofko4EtsfQM1lQw0OmYEW87MBla709hCgEFJgbhXGfnAgOjwxrviRMRZ9Sz8gMRAlvC/wzxAmbgfx3Sjj355JDBbi8pWx76F+k29Ox2VNB4EEK3yxKNDYvAKvKGLR1HvFOG5TNv0sZGClSyfCXOy8PfCH4vECcPzpuS3fmLA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+84T9kkp7R5mVYI70Wp0re45N1MM5fOzAfivBgbrVV4=; b=eg60zikvULjFfl4Sc9IfBfKTJURy5NQSk6Xzy7DWwCKsFrbugUw0kYTIfyDHuRq1xzCLBCeO76xaJCLEMX9uoeQ/1V/cHL7XGFMpxUQ2RMLrEosJpvJJhJH3jeQYJ/KnF1SMiFUTg30/XyhgSq7hvzGScGn+mkRZ7bpdiXQ5a6H2v3QG2pFIPTAQwUnf4mRFzmZ9KG/JDft4x4O+BnpTbRGqOsIl5Qc80MPBJjo7FI2KjB2hY3RlbDHdR7AXguHWg2XLfqEOUjHBENN99eRTW7aeEXWgP5Vpv2r8x6SJi102IOHuogSTysWLnAqG9/9vgfo+aT2ya+REY1e+CP+HpA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+84T9kkp7R5mVYI70Wp0re45N1MM5fOzAfivBgbrVV4=; b=kmeNbn3NCdU+DJzBkxRgUOsWfwC4UFKHkZcQAbG1RWnc/o1LKrcJfDs0GOfKH26NpDGFWxMsVitB57XNXbBJxegoC8jvgUF9iKz5uXDzpIsEQZctbbMhK+3kNamcZB/x3AwKtM6tf5TJdDdnv9uPx/NkkBnNR0BLaa7CkJNjzB4=
Received: from MW3PR11MB4570.namprd11.prod.outlook.com (2603:10b6:303:5f::22) by MW3PR11MB4697.namprd11.prod.outlook.com (2603:10b6:303:2c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.26; Fri, 21 May 2021 12:17:07 +0000
Received: from MW3PR11MB4570.namprd11.prod.outlook.com ([fe80::592f:2e19:cf5b:a0f5]) by MW3PR11MB4570.namprd11.prod.outlook.com ([fe80::592f:2e19:cf5b:a0f5%5]) with mapi id 15.20.4129.035; Fri, 21 May 2021 12:17:07 +0000
From: "Ketan Talaulikar (ketant)" <ketant@cisco.com>
To: Paul Wouters <paul@nohats.ca>, "secdir@ietf.org" <secdir@ietf.org>
CC: "draft-ietf-idr-bgp-ls-app-specific-attr.all@ietf.org" <draft-ietf-idr-bgp-ls-app-specific-attr.all@ietf.org>, "idr@ietf.org" <idr@ietf.org>
Thread-Topic: Secdir early review of draft-ietf-idr-bgp-ls-app-specific-attr-05
Thread-Index: AQHXTeoF2VcqF++be0S0jVpGL2lZn6rtZUcg
Date: Fri, 21 May 2021 12:17:07 +0000
Message-ID: <MW3PR11MB45706EFB5C97B95D05BC0A99C1299@MW3PR11MB4570.namprd11.prod.outlook.com>
References: <162156453202.16583.7878225218187327569@ietfa.amsl.com>
In-Reply-To: <162156453202.16583.7878225218187327569@ietfa.amsl.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: nohats.ca; dkim=none (message not signed) header.d=none;nohats.ca; dmarc=none action=none header.from=cisco.com;
x-originating-ip: [72.163.220.23]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: c0b1a543-c351-419f-0fee-08d91c525a24
x-ms-traffictypediagnostic: MW3PR11MB4697:
x-microsoft-antispam-prvs: <MW3PR11MB46970C5C025EF70B3B69B7E4C1299@MW3PR11MB4697.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: ndE2Z/65GSMrgRDeRgdVLxneLMJJh3wepY3Oo+WWk3sMt96VaecPtpWP7bcEhAipCh7wbXZ05WqlW76gZdO5XEuCNFqGGARMb7cZ5maHkIkngTUwo0qg052vMslT+JrZEwNBHvxk0Pset5x00k8/WJCs/HfdSBfpJsUaKYHN2fXJvwJ6sV3lMkI2s4z940rGgizQJEERXivkIDYEDzXUYIl2hqzqfnF8LzmZqQ01w/2FLiCOB07qOgjQILcsVVXgB2r8uZAsZ3YqXcqLaWu9hLU1OxHtpO5mncja3l86amBVkfUK9ehX0iGGPU3mS2VyItF/1x4m9R/y/doCosiydLzxX6H3hKinFvY1L6Sn0jzbj0fUVMIE9rwSRNlZ+yeMQns5FXT8mFmu0YW+1beiipaorDfywE/OkZbeWHGcAaV9CyQYO41gEdx8yS8Mi4xed6A4bBjzmFvJQCQjKZnaBLjn/fbOpl+Hv3IR+RsexYMbYSCEwBJNyGvWDBduMhJbcNqCrlwafpoQMpLYygmlLC96DwTbGxxqBcNeL4cFEfvc86fHo7vRoeCq4CC+tdi82K8Ph8i8k7bOFa7wTYkL9qTyP78jXM+bzLM+uwbnq8E=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW3PR11MB4570.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(136003)(376002)(39860400002)(366004)(396003)(38100700002)(122000001)(7696005)(86362001)(33656002)(8936002)(54906003)(26005)(4326008)(71200400001)(53546011)(76116006)(6506007)(110136005)(83380400001)(478600001)(8676002)(316002)(5660300002)(55016002)(2906002)(52536014)(66446008)(64756008)(66556008)(9686003)(66476007)(66946007)(186003); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata: Nz/tfQzZlSaYrwMLNv10VQWaURQ50jzklfDGpeNztBbRKv488G5DQzUKIJ5EmnYu8CVy+ilDKpUiPGcklkMZ/XG20BWDkUB9iiLDplV454rsWL6fHyjq8+E5NTYGUse9PBypbSJAaXIV1o0wtXCER5BtEmG6yUURm8zvvbs5JdwdBbnqwIwzBgLy8NmAO0WM0hDeMya1RpMvn+hQcCQfsohmBIaR4/vrOQjh1L0/ZM3qOyV+YAHynlMPKvzsVKQclJPeNPDsniIpXiUAnWvLEvFonQyJwuU1MCHminLIceUpX3Pf4n9tUWuFZXMGN374pvwkL+gmCIsZ3wXtq5kwGZ5vVrYPQteR39i7oIybSQgqXcSuF2neRLTHMQMui3RWBWgWoIX4e1wojyRkKAWefR+fSqrNONSO2UiCxVDgKPEhjd4UpXypkJ+LKpzFRE6hI/vISQhPaohXAELLxKDo3tB5Oy9urd9q0we6Itl6hqT5/94Pz0XMPrT33Nu/vjoNHxhUeaXZvR2qEoWjxjlsSma2A92/3cM38zcnk/yQWYyMrBshKo5llhCCUXGh5R8Usx6HHkqSpJBjiETdYmRHtNL3EFyuOpucn34aXyP/03vdIWPRxvlNUGt0/Tp3osc+dzszIbAcyJh0Smhh8tIcL/98ZhDBaAuwPmHtpIl70ELTgTZBBORE2wmrAu8/3XWtX7/laJv1QzrhPHmYwhq6YT9ijzVkTkvn+ruXFb3H7GW20f3j5mYaY+PKxB6UJtysKuXJNyCxJ44mpr+COJ8ZKJgiYMMnc+YYPqSwDaYLs7m8YgfBh1HyKVYUKUSpbD587o/8JkAPOzqI0EWRYtviDAaIaCC1GrjTTWjOeCBImE++LDXoeLghWLLXlSq9O2hotBC3m4uSJ9R/6gQWWmDw7F0Zq9WhAVX8rOzOPqmuENB7Q6qirUZsowOYqeAYPCjfZXFV94VwdkFbwcBQa4b9aDP12MP1icPmvTQDvVHsGifNhtDixzZl62lZ3jvIjbck5SMkV56M5TcJzWFfmQjaQ1NYONhvBqHyoXvBeO958ubpf+51IJ/1SYC3A8hkuHCV0Rld2jblvAG4UIjsFVbdVNxIOEl06NqKTMyZQ4iufSBWOTtIdj9kHqw9GBbX3T+HmcDSR5iY6FfYABcOBGoUB7DEzcvuR/2DJ9W+ICzqbsMCRlVJIEkeXSHh1AxBTt0tGU9kJ0fB4jra0pkjf9ht9ZLFcgFfFIZ2wTUTv+CM67LFLDD/GZeO4TBQ/oBBnJUL5ABYRSjltRcU1gJme/m73tN/ZQMm7KiOvBVyMxFwLdtyCkjmdQEGqJT2LdNQWluu
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4570.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c0b1a543-c351-419f-0fee-08d91c525a24
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 May 2021 12:17:07.2962 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5LxyX0gbwe2CcLJw5n1I/stBXgiuiTyfJvmLxEctzjIB9EgIRfWBH5uuOaCLMvN4pGzxPpgumjII3MJzXx6KXA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4697
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.37.102.22, xbe-rcd-007.cisco.com
X-Outbound-Node: alln-core-1.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/9NszLMBqvCKAt6hIZFMxdUhbd3c>
Subject: Re: [Idr] Secdir early review of draft-ietf-idr-bgp-ls-app-specific-attr-05
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 21 May 2021 12:17:17 -0000

Hi Paul,

Thanks for your review and please check inline below for responses.

-----Original Message-----
From: Paul Wouters via Datatracker <noreply@ietf.org> 
Sent: 21 May 2021 08:06
To: secdir@ietf.org
Cc: draft-ietf-idr-bgp-ls-app-specific-attr.all@ietf.org; idr@ietf.org
Subject: Secdir early review of draft-ietf-idr-bgp-ls-app-specific-attr-05

Reviewer: Paul Wouters
Review result: Has Nits

I have reviewed this document as part of the security directorate's  ongoing effort to review all IETF documents being processed by the  IESG.  These comments were written primarily for the benefit of the  security area directors.  Document editors and WG chairs should treat  these comments just like any other last call comments.

The summary of the review is Has Nits

In section 3 it lists 1092 as "TE Metric" but RFC 7522 lists it as "TE Default Metric". And 1116 is listed as "Unidirectional link delay variation" but RFC
8571 lists it as "Unidirectional Delay Variation". And 1117 shows "packet loss"
vs "link loss". There are more subtle differences.  Maybe ensure these terms are synced up better, unless there is a reason these terms are different/updated ?
[KT] Good catch! Fixed them all.

      Link attributes that do not have application-specific semantics SHOULD
      NOT be advertised within the ASLA TLV.

Is there a reason why this is SHOULD NOT and not MUST NOT? In other words, do you have an example of where the SHOULD NOT would not apply? And if so, should that be mentioned here? 
Same for the following SHOULD case,
[KT] Thinking over it now, I do not see a reason for the SHOULD. Will change it to MUST unless someone believes it needs to stay as it is.

In section 4, "[RFC8920] " appears without an actual link. It's either missing the xref target, or there is a bug in rendering the xml to html?
[KT] Looks like an xml2rfc rendering issue.

grammar nit:
CURRENT:  They were originally defined
PROPOSED: These were originally defined
[KT] Ack.

Thanks,
Ketan