Re: [Idr] Shepherd's report for draft-ietf-idr-bgp-ls-flex-algo-05.txt

"Ketan Talaulikar (ketant)" <ketant@cisco.com> Mon, 08 March 2021 19:04 UTC

Return-Path: <ketant@cisco.com>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6AA063A1536; Mon, 8 Mar 2021 11:04:22 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.6
X-Spam-Level:
X-Spam-Status: No, score=-9.6 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=K/Xoc2wn; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=RrVyh5DV
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RCD1GPlnHrvP; Mon, 8 Mar 2021 11:04:20 -0800 (PST)
Received: from alln-iport-8.cisco.com (alln-iport-8.cisco.com [173.37.142.95]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 366883A1532; Mon, 8 Mar 2021 11:04:20 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=18129; q=dns/txt; s=iport; t=1615230260; x=1616439860; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=9kNlfDITpqrd7IcviJlAobVFYJA8zYgjLksgNUzK2v4=; b=K/Xoc2wnkL7UyQMhP3hmEQdUL+APrXDHA3DF7FU2rPAEjAnIJqSIn9nq hQw9FNVkKq6JqwryFdMgvtEEj5Y8nbIdc3l9g3Q4VBMawj4is4sRxMRy+ UurdVQPZhDURRfmIeif5f/cfuF3HDwctfzTIIKT0FSQcXa5Tt1KVoj5wo A=;
X-IPAS-Result: A0A4AABddEZgmJFdJa1iHAEBAQEBAQcBARIBAQQEAQFAgT0FAQELAYEiMFF9WjYxiAkDhTmIWAOZI4EuFIERA1QLAQEBDQEBKAoCBAEBhE0CgXoCJTYHDgIDAQEBAwIDAQEBAQUBAQECAQYEFAEBAQEBAQEBhjYNhkQBAQEELRMBATcBDwIBCBEEAQEvMh0IAQEEAQ0FCIJoAYF+VwMvAQ6hfwKKJXSBNIMEAQEGhRMYghMDBoE5AYJ1hAaGRiYcgUlCgRFDgVl+PmmBcwKBJjwrgx2CK4FZJU5iBEMQghKcC4xZkESBCwqCfpxIgzmKUZMUgk6UXYILoCECAgICBAUCDgEBBoFbAi+BWXAVgyRQFwINjh8Zg1aFFIVFcwI2AgYKAQEDCXyOKgEB
IronPort-PHdr: 9a23:qXipLBXrV9yhZ70kRiFzduFPu9TV8LGuZFwc94YnhrRSc6+q45XlOgnF6O5wiEPSBNyFufJZgvXbsubrXmlTqZqCsXVXdptKWldFjMgNhAUvDYaDDlGzN//laSE2XaEgHF9o9n22Kw5ZTcD5YVCBomC78jMTXB74MFk9KuH8AIWHicOx2qi78IHSZAMdgj27bPtyIRy6oB+XuNMRhN5pK706zV3CpX4bdg==
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-AV: E=Sophos;i="5.81,233,1610409600"; d="scan'208,217";a="673282357"
Received: from rcdn-core-9.cisco.com ([173.37.93.145]) by alln-iport-8.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 08 Mar 2021 19:04:18 +0000
Received: from mail.cisco.com (xbe-aln-004.cisco.com [173.36.7.19]) by rcdn-core-9.cisco.com (8.15.2/8.15.2) with ESMTPS id 128J4I0S015426 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=OK); Mon, 8 Mar 2021 19:04:18 GMT
Received: from xhs-rtp-002.cisco.com (64.101.210.229) by xbe-aln-004.cisco.com (173.36.7.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Mon, 8 Mar 2021 13:04:17 -0600
Received: from xhs-rtp-002.cisco.com (64.101.210.229) by xhs-rtp-002.cisco.com (64.101.210.229) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 8 Mar 2021 14:04:00 -0500
Received: from NAM10-DM6-obe.outbound.protection.outlook.com (64.101.32.56) by xhs-rtp-002.cisco.com (64.101.210.229) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Mon, 8 Mar 2021 14:03:59 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ESG/USeH/4Pm8BZLMfy8YPeSes+AWofdCv6OK9UEMz/Wu9cPP0Twwnz2Q7mbFW41gtXoqDy8FSB9rZ4a9xv2DnYIwBDNXT+lC3kHNgIHxkHPMe0wSgWbILxdfmfByorCgmDwJmLB0jJD+XpruFXxR+8YK3NEXQujjyvgwZIYp3aYMR0g3oPiRXCq7WliWZ/jy1uT9jIa4Pv3FaPMqbmaMxNujcVBowIvO8m5dbUKBTpQJu7cGE5ybrLkiuufpynRlXwCEwt2HIe669SWtJt9jpHgcANmgH0wpstn7t0MPjJMRFcEmJY0HcoOyARoWyfnGcB8+lShnjtU9blpPoDq0w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EhZCM7Uo5UlXgiFcRRGsrPpMGNDru5ybQIUmltjz30w=; b=KNQBwU2lOsQkaruDpf9APuSzoGafGl4uQLw9v7Tx0cCSk1JOWjZR2gRQpkgfnEQuZrMLg0YdEmSxGYR1GMtDFicaCbcOiP2QqzLLaeXJX/2zvWMOCQVXZ/RIvvpkjlRFQY+s3SzlhUy/sEo4TE0UHZgPA0U9vAzb4F4JigykFGQvs8I7PtnX92gH3KQsa1zmV4koYFH6/98Rqjgzx1o+vO2KISHaYFNvi/g0H8gEZR0MQzseZLEXu4iB5WaUpwkjo4L4OLdGAeqM9yamW1WTLLYxrLoGILsgCLBTxTTCQh9i0QjSJwtYu+ciaVwPIHNG4juBye9Ghwwnhd9j/HPbSg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EhZCM7Uo5UlXgiFcRRGsrPpMGNDru5ybQIUmltjz30w=; b=RrVyh5DVR3qQe0YZf1Qw8X48rePwPZDZXiZSxCYIaqxz8Ae0emqhkx5xdJ0d81WFKZ2Bv3q58kiaoGwuo091WjCBfy5t87hFvYVaCEMwKcfJ8dyVjsvHBDuAgUowYtSUQcomx0o4dKi7xp1MMZ4GH0YO0PgYFzl8W6Yvcz3dwao=
Received: from MW3PR11MB4570.namprd11.prod.outlook.com (2603:10b6:303:5f::22) by MWHPR11MB1662.namprd11.prod.outlook.com (2603:10b6:301:e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17; Mon, 8 Mar 2021 19:03:58 +0000
Received: from MW3PR11MB4570.namprd11.prod.outlook.com ([fe80::912e:ea1d:5ec:ea30]) by MW3PR11MB4570.namprd11.prod.outlook.com ([fe80::912e:ea1d:5ec:ea30%3]) with mapi id 15.20.3912.027; Mon, 8 Mar 2021 19:03:58 +0000
From: "Ketan Talaulikar (ketant)" <ketant@cisco.com>
To: "Dongjie (Jimmy)" <jie.dong@huawei.com>, "idr@ietf.org" <idr@ietf.org>
CC: "draft-ietf-idr-bgp-ls-flex-algo@ietf.org" <draft-ietf-idr-bgp-ls-flex-algo@ietf.org>
Thread-Topic: Shepherd's report for draft-ietf-idr-bgp-ls-flex-algo-05.txt
Thread-Index: AdcHSu9H6AkDzQRhS0ekCflYK3Ow5wM/xrbA
Date: Mon, 08 Mar 2021 19:03:58 +0000
Message-ID: <MW3PR11MB45708069D8538A0E0EE9C3D3C1939@MW3PR11MB4570.namprd11.prod.outlook.com>
References: <54ad153c99ba4455aa1bcb3dff671bce@huawei.com>
In-Reply-To: <54ad153c99ba4455aa1bcb3dff671bce@huawei.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=cisco.com;
x-originating-ip: [2405:201:1006:a1ca:e874:1075:5390:90c7]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: c487d2db-77b3-421d-0b8e-08d8e264edec
x-ms-traffictypediagnostic: MWHPR11MB1662:
x-microsoft-antispam-prvs: <MWHPR11MB1662B22F0973385C08D1E0B1C1939@MWHPR11MB1662.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: aw4sKXU7gy4G1pQA319Gumm3aVn/xvNpVraR+oRIFwQhJYPOkkvTGE7AhPdJ+VJZFgPd5kWgeVvNODd1XpTrGJDobByI/Heh11EujACEYlQJFxKaky5whPn1lBHZF6pSZhg6RZyVjfBF44M3ip1CueYBp45e54bXIB1JKjpGkTXq6pB4/CfsyetPTZ1vmRAO+km5BwEYA+j+sHMB4I9/czq76mj8Ksc6vMbPjqkGaw4bupbSmP9R+0pCTykYIg6xXo29YAGcQoIULZA+4tjThVlm9HIqv0HY36VncW53fbHKRh69xMPmfAnKWDGTM3ySjLpEDCtgTG2HITukQvlQusNVXg0pP1lB/88BvhN/oie0nPOIqrXG7s5Xj3IVP9+62zrSdNP/SunBZg/gyRemiYxLEF0rAsIrD+7q569b3psgASAuuUSQPl5jPyuDX8C9yFR8sD9zqCp1VfBBGMy3cht3QJ3/4MZbo9DBOc0guP9MmGiMT0pI5hJMCXz8jqcSY+ojB7RwJWiw39YmIYe7at/bJWR5W2ZyKm94KGZXKYLWqFQxPofJMqANTzcMAvJFAvrk7I8MW71lry7/IOZpFkQfxbRs/IJ/wZGCNW4CGKM=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW3PR11MB4570.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(136003)(376002)(39860400002)(396003)(346002)(366004)(76116006)(166002)(66946007)(6506007)(4326008)(53546011)(66476007)(66556008)(186003)(316002)(64756008)(66446008)(110136005)(83380400001)(9686003)(478600001)(7696005)(55016002)(9326002)(5660300002)(71200400001)(966005)(33656002)(86362001)(8936002)(8676002)(52536014)(2906002); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata: KichZVRPFTUHNLYrpW/Z+C59it4C8CMOr69xGTi4YqMVS48x3M8f4m9QbI43JzNM4ytNmDWIBbZPfeyBkFEaFzkGGNKZ95qpcoEoFoo7LBvE+ZBYYU39GR/RBiJO2/F8t/7Lg7PDJBhGG4ARBDstZEdTrZyWaN2p//8dLCRgdNRx0QsJ/wnHObkyE3Dkh9lvcTC7XH4B+kXAqpiU6DcD27aB4+SxMtTpSc393zWc63PZwtcdCFcFPEuYhGCcZ73zO3KKkapVQbV5n33YeV3SPqmhXhZ1K1tqL0n5nyZtyyOLbBq6vSJGiEj7xi7l64F0K+ZUpTmZa+fvyOC4MmW3fv9JVeAS8qj5LkXirqIt2R8KxoQRFCwGeYu3EZT+F9gIL+sukMLj3kh1bCqyeXjaBJN8XivtfOAQOYfKehNfwG3J5Ptks4r6C2q+nUYJVIjQiVqCl7RRBAScqIWMaecd/JJN2QylysqbweAACsipDwLKdhjFlfZ3r0q8xK2mfKzaOE+JNtk0FZiUnPaDsACDaWL/NRrfaplP4OEkLItuDAlReF7kfoNUsSxnmGn4HDMBg9zcEHhkGvLVAE7NLuWtrKQfrQE560TNXnbgm5KSNt0WWZ+hC7cxAKPA9In842f9zcMC18OPURNmUjsIdyVBE7rzf1Bbo1AL8qFyb9iMEbLlhR/cv3TcjIQ+1OcvY/7Ij/68Pi5kAlIM2WMVb0nCc7WpZqdYWhL+3pKx0ww/7vHDj6T2GdEV1Q3CxfeLTjEpbdNZzavPcpUz0QGo2uEuj+y7KQxXsf0CIItxf7CGtbVKB+gn+zWNjyWBd8Afe4HWeSkehtHUvDWHR6lrzEfCnjalx6EocmL1WBIco6XknadRtcWly9h+bO7OzkHi+wVpuHV8t7L4tiCJDpgi3l/CH1B9lWNuax4o8l0tKFjdazQZYNFF43F70eKd+Az9x776L7CKMr21R+SNde7EnekKmlCYjTaEKtyReoHLki++nSm+T3NiTNNyOq7NfQOmaBASQzWlcNO8WdmozBmYZwpRPNhn7obO+TBkjNMKcbLwEiEDa/+3OTD+Mn+gSGCO6w/n7Asnjnb51BBuVwosuho8qi/BgpiiWhXj/OJQ6nmNOY5HmLZ5SByTvKYUbx/qGLn5R5751APW1hVo58z/bVrXaDVuqI9rN87i16yt2cs4L3K/PJZKiJKpBcEQ3Cg3ziZLkagf3QVKF15Nb/gSjKWNO3TDb6myEYj4VJz0tQA5Cktm8TdNyFMBl2MEuV792ymuakuAiaelTuCQlTy1+0ut/4XasJeEsrcB/XtMid5SpIAU5m9P4GI/U9BsepBOA25OHK1SxYliqFBUGpf1eAk32yJfiSta0R1Rf9B8zTcgJ7rDo4d5htZhGRVY+1qYE+jy
x-ms-exchange-transport-forked: True
Content-Type: multipart/alternative; boundary="_000_MW3PR11MB45708069D8538A0E0EE9C3D3C1939MW3PR11MB4570namp_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4570.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c487d2db-77b3-421d-0b8e-08d8e264edec
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Mar 2021 19:03:58.8176 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: W7CrGfjii54e+g9DHEJg1xlADWRlQk0ufEf1WJqhbsVco2EACWCpzYDeqKMEFuiGgJLpcwB0QZvnl3//ROu50Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1662
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.36.7.19, xbe-aln-004.cisco.com
X-Outbound-Node: rcdn-core-9.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/CzhmolCaUIv7TNdLl36WaoH6rVo>
Subject: Re: [Idr] Shepherd's report for draft-ietf-idr-bgp-ls-flex-algo-05.txt
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Mar 2021 19:04:23 -0000

Hi Jie,

Thanks for your review.

We've posted an update for the draft to address your comments :

https://www.ietf.org/archive/id/draft-ietf-idr-bgp-ls-flex-algo-06.txt

Please check inline below for responses.


From: Dongjie (Jimmy) <jie.dong@huawei.com>
Sent: 20 February 2021 11:11
To: idr@ietf.org
Cc: draft-ietf-idr-bgp-ls-flex-algo@ietf.org
Subject: Shepherd's report for draft-ietf-idr-bgp-ls-flex-algo-05.txt

Dear authors,

This is the shepherd's report for draft-ietf-idr-bgp-ls-flex-algo-05. This shepherd report is a combination from my review and a review done by Shunwan Zhuang. I appreciate his help in reviewing this IDR draft.

This document is straightforward and in a good shape. Here are some minor comments:


1.      In section 1, the flex algorithm computation is described as "the result of a flex algorithm computation is the provisioning of the Prefix SIDs associated with that algorithm with paths based on the topology computed based on that algorithm." Since a Flex-Algo is defined as the combination of calculation-type, metric-type and constraints, it may be more accurate to reflect these parameters in the above description, such as "...the Prefix SIDs associated with that algorithm with paths computed based on the calculation-type, metric-type and constraints of that algorithm".
[KT] ack - I would propose "... Prefix SIDs associated with that algorithm with paths based on the topology computed based on that algorithm's definition."


2.      The definition of SRv6 in this draft is "SR forwarding plane on IPv6 (SRv6)", it is better to align with the definition in RFC 8754: SR over IPv6.
[KT] ack



3.      The format of "Flex Algorithm Prefix Metric TLV" in OSPF has just been updated in draft-ietf-lsr-flex-algo-14, does the format of the corresponding TLV in BGP-LS also need to be updated? BTW, are there other changes to be made in this document to align with draft-ietf-lsr-flex-algo-14?
[KT] Ack - have updated the OSPF flags in the FAPM TLV. The other updates are for ASBR reachability which is not something that is advertised via BGP-LS. Therefore, there are no other updates for this document.



4.      The "Flex Algorithm Exclude SRLG TLV" in section 5 should be "Flex Algorithm Exclude SRLG sub-TLV".
[KT] Ack - also updated the allocated codepoint for this sub-TLV.

Thanks,
Ketan

Look forward to a new revision to solve the above comments. Thanks.

Best regards,
Jie