Re: [Idr] AD Review of draft-ietf-idr-bgp-gr-notification-13

[Job Snijders <[e-mail]>]

On Fri, Apr 06, 2018 at 08:55:01AM +0000, [e-mail] wrote:
> Hi John, Job, all
> 
> Hijacking the thread with a remotely related comment.

Yes, you are. You raise valid points, thank you.

What would you suggest as a solution?

Kind regards,

Job


> draft-ietf-idr-bgp-gr-notification and RFC8203/draft-snijders-idr-rfc8203bis-01 seems to ignore each other and as a result seems incompatible.
> 
> 
> 1)     It’s not crystal clear whether the use of RFC8203 is allowed with draft-ietf-idr-bgp-gr-notification given that with the latter, such NOTIFICATION message would be send with Error Code “Cease” and Error Subcode “Hard Reset” which is not covered by RFC 8203:
> 
> 
> 
> “   If a BGP speaker decides to terminate its session with a BGP
>    neighbor, and it sends a NOTIFICATION message with the Error Code
>    "Cease" and Error Subcode "Administrative Shutdown" or
>    "Administrative Reset" [RFC4486<https://tools.ietf.org/html/rfc4486>], it MAY include an UTF-8 encoded
>    string.  ”
> https://tools.ietf.org/html/draft-snijders-idr-rfc8203bis-01#section-2
> 
> So either RFC8203/draft-snijders-idr-rfc8203bis-01 needs to cover both cases. Or draft-ietf-idr-bgp-gr-notification needs to state that the Hard Reset encapsulation behave as per the encapsulated Error Code, in all protocol aspects (but X, Y).
> 
> 
> 
> 2)     In which order is the Notification data field highjacked?
> 
> https://tools.ietf.org/html/draft-snijders-idr-rfc8203bis-01#section-2  says:
> 
>    The Cease NOTIFICATION message with a Shutdown Communication is
>    encoded as below:
> 
>     0                   1                   2                   3
>     0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
>    +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>    | Error code 6  |    Subcode    |    Length     |     ...       \
>    +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+               /
>    \                                                               \
>    /                 ... Shutdown Communication ...                /
>    \                                                               \
>    +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
> 
> 
> 
> 
> https://tools.ietf.org/html/draft-ietf-idr-bgp-gr-notification-13#section-3.1 says:
> 
> 3.1<https://tools.ietf.org/html/draft-ietf-idr-bgp-gr-notification-13#section-3.1>.  Sending a Hard Reset
> 
> 
>    A Hard Reset message is used to indicate to a peer with which the
>    Graceful Notification flag has been exchanged, that the session is to
>    be fully terminated.
> 
>    When sending a Hard Reset, the data portion of the NOTIFICATION is
>    encoded as follows:
> 
>        +--------+--------+--------
>        | ErrCode| Subcode| Data
>        +--------+--------+--------
> 
> 
> 
> Given that no TLV encoding has been introduced, if both spec are enabled, should we first encode the encapsulated Code or the shutdown communication? (I would personally assume the former but fortunately my opinion is not normative)
> 
> 
> Thanks,
> Regards,
> --Bruno
> 
> From: Idr [mailto:[e-mail]] On Behalf Of John G. Scudder
> Sent: Tuesday, April 03, 2018 10:03 PM
> To: Alvaro Retana; idr@ietf. org
> Cc: [e-mail]; [e-mail]
> Subject: Re: [Idr] AD Review of draft-ietf-idr-bgp-gr-notification-13
> 
> Hi WG,
> 
> As co-chair, I want to point out that the AD asked the WG for comments ("I want to ask the WG to consider..."). Since Alvaro asked more than three months ago and nobody answered, maybe nobody has anything to say -- as he points out ("[After I wrote the text above…] I found that some of the points have been discussed on the list already"), this topic was beaten to death in March 2017 (https://www.ietf.org/mail-archive/web/idr/current/msg17679.html and the following thread, specifically in the context of session culling which Alvaro brings up). Also, for reference the original WGLC all the way back in May 2014 is here: https://www.ietf.org/mail-archive/web/idr/current/msg13202.html.
> 
> However, maybe some people have just missed Alvaro's request, so if you have comments you want considered, please send them by April 10. I will follow up myself (with cu-author hat).
> 
> Thanks,
> 
> --John
> 
> On Dec 7, 2017, at 4:11 PM, Alvaro Retana <[e-mail]<mailto:[e-mail]>> wrote:
> 
> Dear authors:
> 
> I just finished reading this document — I have some comments, please see the list below.
> 
> I understand the intent of this document: instead of resetting a BGP session when a NOTIFICATION is received, use Graceful Restart; if the session is going to *really* be reset, then use the new Hard Reset sub-code.  That makes sense to me…but, is that the only code/sub-code for which it makes sense to do a hard reset?  The NOTIFICATION has always had the “stigma” of being something bad, so much that we (idr/IETF) have even worked on ways to reduce its use (rfc7606, for example).  I want to ask the WG to consider whether other code/sub-code NOTIFICATION combinations should also result in a hard reset.  I think there are several cases, for example:
> 
> (1) rfc4486 (Subcodes for BGP Cease Notification Message) defines “Administrative Shutdown” ("a BGP speaker decides to administratively shut down its peering with a neighbor”).  It seems to me that the sender of this NOTIFICATION would not want to "follow the rules for the Receiving Speaker” (as specified in Section 4).
> 
> (2) rfc4486 also defines "Administrative Reset” ("a BGP speaker decides to administratively reset the peering with a neighbor”); no more details are provided, but that sounds like a hard reset to me.
> 
> (3) …there’s probably others...
> 
> Having said all that, I note that Section 3.1. (Sending a Hard Reset) specifies the “encapsulation” (for lack of a better word) of the real reason for the Hard Reset.  If the consensus is to go forward with that, and not call out other exceptions, then I think that the text in 3.1 should expand more on the encapsulation operation and the rationale for doing it this way, and the document should also address other recent work that recommends the use of Administrative Shutdown, for example draft-ietf-grow-bgp-session-culling (a BCP currently in the RFC Editor’s Queue).
> 
> [After I wrote the text above…] I found that some of the points have been discussed on the list already — please include some of that discussion/analysis in the document.
> 
> 
> I’ll wait until the issue above and ones marked Major (below) are addressed before starting the IETF LC.
> 
> Thanks!
> 
> Alvaro.
> 
> 
> 
> Major:
> 
> M1. Unfortunately, rfc4724 failed to setup a registry for the Restat Flags (or the Flags for Address Family), which means that anyone is able to use the bits in there (assuming the receiver looks at them, of course).  Given that there are only a few bits, and to prevent conflicts, I would really like to see a registry set up.  This document is already tagged to Update rfc4724, so it seems like a good place to establish the registries.  [If for some reason you rather not include that information here, then we can take care of it elsewhere.  IOW, this request is not a requirement.]
> 
> 
> 
> 
> M2. Section 4.1. (Rules for the Receiving Speaker) has me a little confused.  Are the proposed changes contingent to setting the N bit?  The text starts by saying: "As part of this extension, routes from the peer previously marked as stale MUST NOT be deleted, until and unless the optional timer…expires…”…does that mean that the timer is no longer optional?   Then you also say: “...if the Graceful Notification ("N") bit is not set in the newly received Graceful Restart Capability, no new actions are triggered on the Receiving Speaker -- in particular, a clear "N” bit does not trigger deletion of stale routes.”  If I understand rfc4724 correctly, stale routes could be deleted — the text indicates changes in the behavior even if the N bit is not set, right?  If you are Updating this section of rfc4724, what would make it crystal clear is an “OLD/NEW” notation of the text (as in, this is the OLD text…and this is the NEW text…).
> 
> 
> 
> 
> 
> M3. Security Considerations:  Maybe not a security issue, but something to think about.  Section 4.1 says that “routes...previously marked as stale MUST NOT be deleted, until and unless the optional timer...expires, or unless a Hard Reset is performed.  This supersedes the “consecutive restarts” requirement…”.  Not deleting the stale routes and not making the timer mandatory could result in stale routes that live forever if an attacker manages to create consecutive restarts (by simply sending NOTIFICATIONS before EoR) — stale routes are ok in the short term, but may point in the wrong direction eventually.  Is this an issue?  I think that it would be mitigated if the timer was made mandatory (with a nice default).
> 
> 
> 
> 
> 
> Minor:
> 
> 
> P1. Section 4: “...receive and send BGP NOTIFICATION messages in Graceful mode...” What is “Graceful mode”?
> 
> 
> 
> 
> 
> Nits:
> 
> N1. In Section 2, please indicate that the first figure corresponds to the GR Capability from rfc4724.
> 
> N2. s/subcode is defined known as/subcode is defined as
> 
> N3. s/Graceful Notification flag/Graceful Notification bit   (For consistency)
> 
> N4. The operation is obviously per-AF; maybe it’s worth saying that somewhere just for completeness.
> 
> 
> _________________________________________________________________________________________________________________________
> 
> Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
> pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
> a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
> Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.
> 
> This message and its attachments may contain confidential or privileged information that may be protected by law;
> they should not be distributed, used or copied without authorisation.
> If you have received this email in error, please notify the sender and delete this message and its attachments.
> As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
> Thank you.
> 

> _______________________________________________
> Idr mailing list
> [e-mail]
> https://www.ietf.org/mailman/listinfo/idr