Re: [Idr] Rtgdir early review of draft-ietf-idr-eag-distribution-13

Jeff Tantsura <jefftant.ietf@gmail.com> Tue, 09 March 2021 18:32 UTC

Return-Path: <jefftant.ietf@gmail.com>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7012F3A15F0; Tue, 9 Mar 2021 10:32:08 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id H9ex_Lc9t6Xr; Tue, 9 Mar 2021 10:32:06 -0800 (PST)
Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A9F6B3A15EF; Tue, 9 Mar 2021 10:32:06 -0800 (PST)
Received: by mail-pf1-x42e.google.com with SMTP id x7so6574633pfi.7; Tue, 09 Mar 2021 10:32:06 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:message-id:in-reply-to:references:subject :mime-version; bh=z+f6JvuTwlgp9jFmjnSyXEiRGS1Z3lMaxRHMrkZ8K78=; b=d1ldtn/YDj8EzVdx9Bw5sz28KKSTrigHhH1UbJhe+iGJUB7R/FKxrsX39pOeJJJbEx KthvKwbg519Y8ictOdl6sDpW+O9kI/1k2CsBfMZY1GRzq0a4+04XqddlNXZsa00SKXwV fm4hjcpSc7pniIbgRIUDUl7wCkHEcjMubGqKCjitu3hxYO7/5dvAR54CvvygPTp5Ai7m 8YSL8QjBtd2bkVLs3hRafoD5XRgttNJzLSJL9vKYyQ6h62az4m/G6gQ9IZqGh1G2N2TK ew5ZmnWNxCyJHqC0cR8fgkwpPTtFIbPqbn5378+E8nfOvVWRbZ/1irMCkrfRUoRo9IoN sj/Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:message-id:in-reply-to :references:subject:mime-version; bh=z+f6JvuTwlgp9jFmjnSyXEiRGS1Z3lMaxRHMrkZ8K78=; b=sD3eBXlsyS2mzr/ul1GAbajmUHUmMPEIEEG6UIk4k2KUn19fHnMGg8oK9g/1hiAD7G AomHBRSx8tznd+/fxPlMHfo/dpSUt7KhQIWaos/ZP5sG/sV33VP36VbczSv1JLqzACh8 180ZowkEvb8vERJabMSyl8p6fXTD05+18skVQ9tWsRTHZrlz4Yp5i9ufyH+9QqOtgGk1 Qaq01YviqdRpsnPZi3cJOe7rBrQlUg3H6cZkC52HHjndxg3gdgrXxgdQnHTaxCB/LgxZ RXyY8+3NjT09cb+ccVmG0BOsGOmE3XDGjh2XV/OHTGUQg9sALlJZryHB4aS3V+CkhOcn FG6g==
X-Gm-Message-State: AOAM530fTyC26902PAKSsTOjQm8CWAMKEKFdWgkdM8HMEIVKI2OrbYyM 2yluEcGdLjDhmnTFGRcy/uCVdtV9pc8=
X-Google-Smtp-Source: ABdhPJzHm9nGnqsuPSgvla375KSKBfl+tQjWYX4M6CclMEU6hkEa+JQR3LJlI6GIX5yj/+zAbX0R8Q==
X-Received: by 2002:a05:6a00:1a08:b029:1cd:404e:a70c with SMTP id g8-20020a056a001a08b02901cd404ea70cmr27222615pfv.33.1615314724864; Tue, 09 Mar 2021 10:32:04 -0800 (PST)
Received: from [10.117.7.16] ([66.129.241.10]) by smtp.gmail.com with ESMTPSA id 192sm14344554pfa.122.2021.03.09.10.32.02 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Mar 2021 10:32:04 -0800 (PST)
Date: Tue, 09 Mar 2021 10:31:55 -0800
From: Jeff Tantsura <jefftant.ietf@gmail.com>
To: rtg-dir@ietf.org, Ben Niven-Jenkins <ben@niven-jenkins.co.uk>
Cc: idr@ietf.org, draft-ietf-idr-eag-distribution.all@ietf.org
Message-ID: <d41c218c-34c6-4b0d-8691-232c5a1b9cf1@Spark>
In-Reply-To: <160620226786.32561.612670509830410882@ietfa.amsl.com>
References: <160620226786.32561.612670509830410882@ietfa.amsl.com>
X-Readdle-Message-ID: d41c218c-34c6-4b0d-8691-232c5a1b9cf1@Spark
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="6047bf21_257130a3_3f2"
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/GkyOMwlkD0alv9J5lD9quAF9lYI>
Subject: Re: [Idr] Rtgdir early review of draft-ietf-idr-eag-distribution-13
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Mar 2021 18:32:09 -0000

Hi Ben,

My apologies for belated response, and many thanks for your review, will publish the updated version ASAP.

please see inline

Cheers,
Jeff
On Nov 23, 2020, 11:17 PM -0800, Ben Niven-Jenkins via Datatracker <noreply@ietf.org>, wrote:
> Reviewer: Ben Niven-Jenkins
> Review result: Has Issues
>
> Hello,
>
> I have been selected as the Routing Directorate reviewer for this draft. The
> Routing Directorate seeks to review all routing or routing-related drafts as
> they pass through IETF last call and IESG review, and sometimes on special
> request. The purpose of the review is to provide assistance to the Routing ADs.
> For more information about the Routing Directorate, please see
> ​http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir
>
> Although these comments are primarily for the use of the Routing ADs, it would
> be helpful if you could consider them along with any other IETF Last Call
> comments that you receive, and strive to resolve them through discussion or by
> updating the draft.
>
> Document: draft-ietf-idr-eag-distribution-13.txt
> Reviewer: Ben Niven-Jenkins
> Review Date: 24 November 2020
> Intended Status: Proposed Standard
>
> Summary: I have some minor concerns about this document that I think should be
> resolved before publication.
>
> Comments: The document is of high quality and easy to read.
>
> Major Issues: No major issues found.
>
> Minor Issues:
> 1) Section 2, 2nd bullet point states “the TLV must be considered malformed.” I
> think the must in this instance is really an RFC2119 MUST, please correct this.
[jeff] ack
>
> 2) Section 2, last paragraph states “The existing AG TLV 108 and the EAG TLV
> defined in this document MAY be advertised together.” However the existing AG
> TLV is 1088 not 108, please correct this.
[jeff] already fixed in v14
>
> Nits:
> 1) Section 2, 2nd bullet point: s/The length value must MUST be multiple of
> 4./The length value MUST be a multiple of 4./
[jeff] ack
>
> 2) Section 2, 3rd bullet point: s/that are enable/that are enabled/
[jeff] ack
>
> Thanks
> Ben
>
>