[Idr] Re: Genart last call review of draft-ietf-idr-sr-policy-safi-09

Ketan Talaulikar <ketant.ietf@gmail.com> Thu, 07 November 2024 13:27 UTC

Return-Path: <ketant.ietf@gmail.com>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 38E82C217BA1; Thu, 7 Nov 2024 05:27:37 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.105
X-Spam-Level:
X-Spam-Status: No, score=-2.105 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kriWyc2OQSJG; Thu, 7 Nov 2024 05:27:33 -0800 (PST)
Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 43B7EC1EC4F8; Thu, 7 Nov 2024 05:27:22 -0800 (PST)
Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-21116b187c4so8342645ad.3; Thu, 07 Nov 2024 05:27:22 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730986042; x=1731590842; darn=ietf.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=lA4zdEOceVmyLBTEieO8b95EAKAegTFZcWgj+M7Oa3I=; b=B1kg3dj8azJADaRlxxvFQTtITotM86hqdoQ2ZY/eFyt99LjH4tj6YRYXyxflruU2d/ nYIjFV98x1rYipBkG+ODE9tjYhQcf9cc/aAa/GdjZgSPi7MuyZPsDHFng6MgTFtvJ4Xx /pUepAiIMAicnvYf1Orx9BICBfM3WQ02MBw82YfzktbIOfmQWCPyMdEZB9Siu76Otac0 BJOaHJrJNQlmqm3z/h2fIvHHKd7ttofyf22nmBZZRStAYN24O6JBlpHbdbI35mt8oxdP U/wgDIPOzTqRmVY5J0/C1Srg3FepK+XpcQoapzEFTUuMYgTqe+8IObQjpBNksYcPP40V FkIw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730986042; x=1731590842; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lA4zdEOceVmyLBTEieO8b95EAKAegTFZcWgj+M7Oa3I=; b=oKryUUJkrokag39ulZmO8EV9w8u6QZImpSAMH2ouEYUPq1Mrk/w+ff1GWiiATKUqWI L8LTkFhjgocWD53uvpASfVEHcuAveB15qMsY7gDDcjdqsGVMRz98a8F5yiAZwh4ajQFr H+jqGiPdHRU1AxCoKHLUWicX+fYLTb9uD57cu+VA01bQ9GNEC6ZnkLeRcXpaPXgpEstj VAehVDZpvkXNCzwY+z4pdc56ckQPpn4BB+YQdFepSfg8LWtYtgTgQ47i0ePLXYReNUVp rXbBQNn1z4UnFVGd53ViXIay/WXpJnx03/JReXQBeTW3RMUl5wOavu2wJSu0ez39eiv7 wmVQ==
X-Forwarded-Encrypted: i=1; AJvYcCV4uAWUQVQ1yPZHhVYFgaQUKn3nQ+Fg8lJ+SM+xt6+61mUf/vWVh3y2I16GJXOjQkHC+bpJ@ietf.org, AJvYcCVDycy1//3arNgyvHW/LHMkocD4vk+lVynrPlupf2kiLfAllBWDNV2hKOA0IlOgaU/ZCrpxqe/+yoTfKIP8LSykkJs9K79WeW+e1N32mvf0zAU=@ietf.org, AJvYcCVUxYwge5BLJiPo2L5kEsi4pzZosqwoDsXYRPpwDCKLmdG4HfMGauEcWQ19dIRkGQ6un9CTgjVmDyBp@ietf.org
X-Gm-Message-State: AOJu0YyTD53B09VKa5QF8LisX14uZYiMuJjCKW0Ct5tOllmTGoMXNyrN HIbb+xI3LEJsNUtth+TkUDEaKsmlQspcFDCKu3b11McBymyJfl288RNU0uZpj4XQsClyjoRBRki 8bnspwDpEAXCVN2GqgNPvmJnsHCrFWRHZlyE=
X-Google-Smtp-Source: AGHT+IEQm9cbsFTjWOsh++66SZq7wlHjEsQUEXacKx2xPglgHinLLrzP+2mlBKZ5IhRi8bGSRvSfUIri4khtCInt5bw=
X-Received: by 2002:a17:903:440d:b0:20e:55b0:3607 with SMTP id d9443c01a7336-2111af1cbbcmr292298075ad.2.1730986041711; Thu, 07 Nov 2024 05:27:21 -0800 (PST)
MIME-Version: 1.0
References: <173091024929.188.8561436824451864737@dt-datatracker-5f77bcf4bd-4q5pd>
In-Reply-To: <173091024929.188.8561436824451864737@dt-datatracker-5f77bcf4bd-4q5pd>
From: Ketan Talaulikar <ketant.ietf@gmail.com>
Date: Thu, 07 Nov 2024 13:27:10 +0000
Message-ID: <CAH6gdPwD1A1V7_c5xwkiAhoOTq3N+Kx8D5qJdbAbhpPt3UaTyg@mail.gmail.com>
To: Dan Romascanu <dromasca@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Message-ID-Hash: Z76VQSEK7SSGIZ5BAJ66I6VX3OHGMVMY
X-Message-ID-Hash: Z76VQSEK7SSGIZ5BAJ66I6VX3OHGMVMY
X-MailFrom: ketant.ietf@gmail.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-idr.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: gen-art@ietf.org, draft-ietf-idr-sr-policy-safi.all@ietf.org, idr@ietf.org, last-call@ietf.org
X-Mailman-Version: 3.3.9rc6
Precedence: list
Subject: [Idr] Re: Genart last call review of draft-ietf-idr-sr-policy-safi-09
List-Id: Inter-Domain Routing <idr.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/HoTI9_mQT4XLFCjjgbPpJUx9vh0>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Owner: <mailto:idr-owner@ietf.org>
List-Post: <mailto:idr@ietf.org>
List-Subscribe: <mailto:idr-join@ietf.org>
List-Unsubscribe: <mailto:idr-leave@ietf.org>

Hi Dan,

Thanks for your review. Please check inline below for responses.

On Wed, Nov 6, 2024 at 4:24 PM Dan Romascanu via Datatracker
<noreply@ietf.org> wrote:
>
> Reviewer: Dan Romascanu
> Review result: Ready with Issues
>
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
>
> For more information, please see the FAQ at
>
> <https://wiki.ietf.org/en/group/gen/GenArtFAQ>.
>
> Document: draft-ietf-idr-sr-policy-safi-09
>
> Reviewer: Dan Romascanu
> Review Date: 2024-11-06
> IETF LC End Date: 2024-11-11
> IESG Telechat date: Not scheduled for a telechat
>
> Summary:
>
> This document specifies how BGP may be used to distribute SR Policy candidate
> paths. It introduces a BGP SAFI to advertise a candidate path of a SR Policy
> and defines sub-TLVs for the Tunnel Encapsulation Attribute for signaling
> information about these candidate paths.It updates RFC9012.
>
> This document is Ready with two Minor Issues.
>
> Major issues:
>
> Minor issues:
>
> 1. Section 6.10 includes:
>
> >  Note to IANA (RFC editor to remove this before publication): The new
>    registry creation request below is also present in the draft-ietf-
>    pce-segment-routing-policy-cp.  IANA is requested to process the
>    registry creation via the first of these two documents to reach
>    publication stage and the authors of the other document would update
>    the IANA considerations suitably.
>
> As I understand, if this document reaches publication before
> draft-ietf-pce-segment-routing-policy-cp, Section 6.6 of the latest will be
> removed, and the opposite. However, the tables are not identical. In Table 10,
> Section 6.10 in this document values 5-255 are Unassigned, while in Section 6.6
> of draft-ietf-pce-segment-routing-policy-cp values 5-255 are Reserved.

KT> We say "... and the authors of the other document would *update*
the IANA considerations suitably." - so we won't be removing section
6.6 of this document. We'll do what is correct/needful under guidance
from the IANA team. If there is a different/better way to deal with
such "race conditions", we are open to adapt.

>
> 2.The Manageability Considerations section refers to
> [I-D.ietf-spring-sr-policy-yang] which is Expired.

KT> The authors of that document were reminded by the SPRING WG chairs
earlier this week. That document is a milestone deliverable for SPRING
WG and the expectation is that it will progress (soon).

Thanks,
Ketan

>
> Nits/editorial comments:
>
>
>