[Idr] Re: John Scudder's Yes on draft-ietf-idr-bgp-sendholdtimer-14: (with COMMENT)
Job Snijders <job@fastly.com> Tue, 30 July 2024 19:49 UTC
Return-Path: <job@fastly.com>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0349CC14F5EA for <idr@ietfa.amsl.com>; Tue, 30 Jul 2024 12:49:54 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.105
X-Spam-Level:
X-Spam-Status: No, score=-2.105 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=fastly.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id V0iDwLrgPJqb for <idr@ietfa.amsl.com>; Tue, 30 Jul 2024 12:49:49 -0700 (PDT)
Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 83DC8C14F5F7 for <idr@ietf.org>; Tue, 30 Jul 2024 12:49:49 -0700 (PDT)
Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-a7a94aa5080so579556466b.3 for <idr@ietf.org>; Tue, 30 Jul 2024 12:49:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1722368988; x=1722973788; darn=ietf.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=iNi0NuvYC+Z6OcJk/JmiXeKLQPZemTZUJwZlEHoBZbo=; b=MWry/hWM2p+IKIAKjM/IntyvnQgQx4sHtE4qaPOpcDop+omQBifbPJXzxkTqF/aCuh fn/lRJwc85msgB2kQ8p4Zj9zbdy2Yu7p/CU5VjIjy11fUN5ny8WpL1Fb5ta3R2jUoCry 8eP1AGUAETsD8sKvK7DwqdkaXHtM+0Yz+8+xA=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722368988; x=1722973788; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iNi0NuvYC+Z6OcJk/JmiXeKLQPZemTZUJwZlEHoBZbo=; b=C/PdRQVFqNBzaLDDr3o3AcPr5e8ELB8hZom8F5+i2wGK50B2u1jkcCxzH9l0ZaV+i8 syLB+kNQpfpPHk5Qk7yI6JzvNx0MDHiqhSa7HhMbpZV9oBELQf54vsbLV784F193E3mS leeY1BEqipvjwahZO+pKt1G8POgde0Mvey2IKp8c5pf1LqUtTeiejoaWUrD83bhsHcFp slUeDvg18OoA5SRb95si1QKa+SFw34e9J8eigDxgj0z0Uc507Pjeu3T6jhe6sDb34CWH gFWOXZOdaNOMQWizHkRh7wOn1GQr3ZBrFJYOmn9l3D8mtuC7mlLiF8Y9LZom+lMyRPmO Wduw==
X-Forwarded-Encrypted: i=1; AJvYcCWEO8c0/JwpJJgL80Xqw1taiYMReQWSW61bxz8G9vuC6lmqgz7Xh6kMymBHqiCeFDaONDYEBzWTq4Hnb18=
X-Gm-Message-State: AOJu0YwUWp/qD5CaKZ+kLrxrZgUE11lCmaMIZRXerY04bUz7rzT9FmbR Coj2gYI23L64HSvdWaPurc7qB/5GpbdRyJazWXlqoSgQOxDd39vT2AhK6A6VNUw=
X-Google-Smtp-Source: AGHT+IEvOvGfzRZGAoRC+7oKs4QHboKr/39Ff0WO3Cm2VYSU68TJ/pIMhfYD1sjBQD+OiQ+vVMEblA==
X-Received: by 2002:a17:906:d54f:b0:a7a:adac:57cd with SMTP id a640c23a62f3a-a7d3ffd4c77mr1037279366b.36.1722368978240; Tue, 30 Jul 2024 12:49:38 -0700 (PDT)
Received: from snel ([2a10:3781:276:0:16f6:d8ff:fe47:2eb7]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7d23e8bd62sm627166166b.73.2024.07.30.12.49.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jul 2024 12:49:37 -0700 (PDT)
Date: Tue, 30 Jul 2024 21:49:36 +0200
From: Job Snijders <job@fastly.com>
To: John Scudder <jgs@juniper.net>
Message-ID: <ZqlD0GgE33KP7KdF@snel>
References: <172236618407.1978053.16148746535419455499@dt-datatracker-659f84ff76-9wqgv>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <172236618407.1978053.16148746535419455499@dt-datatracker-659f84ff76-9wqgv>
X-Clacks-Overhead: GNU Terry Pratchett
Message-ID-Hash: 2JFZWBXFYIAKROHU3KWPRGLVB3I623QC
X-Message-ID-Hash: 2JFZWBXFYIAKROHU3KWPRGLVB3I623QC
X-MailFrom: job@fastly.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-idr.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: The IESG <iesg@ietf.org>, draft-ietf-idr-bgp-sendholdtimer@ietf.org, idr-chairs@ietf.org, idr@ietf.org, shares@ndzh.com
X-Mailman-Version: 3.3.9rc4
Precedence: list
Subject: [Idr] Re: John Scudder's Yes on draft-ietf-idr-bgp-sendholdtimer-14: (with COMMENT)
List-Id: Inter-Domain Routing <idr.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/L6MinGVjHn94gRhCi2lGAQ9GoHw>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Owner: <mailto:idr-owner@ietf.org>
List-Post: <mailto:idr@ietf.org>
List-Subscribe: <mailto:idr-join@ietf.org>
List-Unsubscribe: <mailto:idr-leave@ietf.org>
Dear John, On Tue, Jul 30, 2024 at 12:03:04PM -0700, John Scudder via Datatracker wrote: > ---------------------------------------------------------------------- > COMMENT: > ---------------------------------------------------------------------- > > Thanks for all your work on this document. I have one comment, related to the > use of the “OLD/NEW” idiom. Since the conceit with this idiom is that we are > doing a patch to the underlying document, this particular patch: > > ``` > NEW > > | SendHoldTime is an FSM attribute that stores the initial value for > | the SendHoldTimer. If SendHoldTime is non-zero then it MUST be > | greater than the value of HoldTime, see Section 5 for suggested > | default values. > ``` > > strictly speaking means that the reader should go look in section 5 of > RFC 4271 for the suggested default values. Of course, what you really > mean is section 5 of the present document. I don’t think this is > likely to confuse any reasonable reader. Still, it would be cleaner to > move the reference to section 5 outside of the “NEW” block, or > otherwise disambiguate. I see what you mean, I thought this semantically already is disambiguated, as the underlaying xml2rfc code is ```see <xref target="implcons"/> for``` where 'implcons' is a 'non-reference'. I can make a note to ask the RFC Editor to perhaps help ensure that in the final outputted document, the reference is visually displayed ala: ``` NEW | SendHoldTime is an FSM attribute that stores the initial value for | the SendHoldTimer. If SendHoldTime is non-zero then it MUST be | greater than the value of HoldTime, see Section 5 of | [I-D.ietf-idr-bgp-sendholdtimer] for suggested default values. ``` I've changed it in the edit-buffer like so: https://github.com/bgp/draft-ietf-idr-bgp-sendholdtimer/commit/e6b05f44355c012ec219f5689c5183e3660a68d9 Or is there a better way to do this in xml2rfc? Kind regards, Job
- [Idr] John Scudder's Yes on draft-ietf-idr-bgp-se… John Scudder via Datatracker
- [Idr] Re: John Scudder's Yes on draft-ietf-idr-bg… Job Snijders