[Idr] Genart last call review of draft-ietf-idr-ext-opt-param-11

Christer Holmberg via Datatracker <noreply@ietf.org> Thu, 15 April 2021 19:34 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: idr@ietf.org
Delivered-To: idr@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id EF2813A2C1B; Thu, 15 Apr 2021 12:34:06 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Christer Holmberg via Datatracker <noreply@ietf.org>
To: <gen-art@ietf.org>
Cc: draft-ietf-idr-ext-opt-param.all@ietf.org, idr@ietf.org, last-call@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.28.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <161851524693.27672.11525659031465457077@ietfa.amsl.com>
Reply-To: Christer Holmberg <christer.holmberg@ericsson.com>
Date: Thu, 15 Apr 2021 12:34:06 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/MGrdyJ9UdHYf8f9HG2TibWXJa4o>
Subject: [Idr] Genart last call review of draft-ietf-idr-ext-opt-param-11
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Apr 2021 19:34:07 -0000

Reviewer: Christer Holmberg
Review result: Almost Ready

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-idr-ext-opt-param-11
Reviewer: Christer Holmberg
Review Date: 2021-04-15
IETF LC End Date: 2021-04-09
IESG Telechat date: 2021-04-22

Summary: The document is easy to read, and I have no technical issues. However,
I do have a minor question, and a couple of editorial suggestions, that I'd
like the authors to address.

Major issues: N/A

Minor issues:

Q1: As far as I understand, the document only defines a new BGP OPEN Optional
Parameter Type, but does not modify/add procedures in RFC 4271. So, is the
document really an update to RFC 4271? And, when reading RFC 5429, I cannot
find any text saying that new parameter types would require an update to RFC
4271. I also looked at a few other RFCs that add new values to the BGP IANA
registry, and they were not updating any RFC.

Nits/editorial comments:

Q2: I suggest that Section 2 is renamed to  "New Optional Parameter Type code",
or something like that. OR, if the document really is updating RFC 4271,
perhaps "Update to RFC 4271".

Q3: I suggest that Section 3 is renamed to "Backward Compatibility", or
something like that.