[Idr] RtgDir review: draft-ietf-idr-sla-exchange-10

Ron Bonica <rbonica@juniper.net> Thu, 16 February 2017 17:56 UTC

Return-Path: <rbonica@juniper.net>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CE3CD129675; Thu, 16 Feb 2017 09:56:30 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.922
X-Spam-Level:
X-Spam-Status: No, score=-1.922 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=junipernetworks.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jdSnrjoonSdo; Thu, 16 Feb 2017 09:56:29 -0800 (PST)
Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0124.outbound.protection.outlook.com [104.47.37.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E6A77129406; Thu, 16 Feb 2017 09:56:25 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=junipernetworks.onmicrosoft.com; s=selector1-juniper-net; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=8M0XXR26YbU71THw+Gim6tnXQnuhlHnweeldlGJOc/A=; b=XmnQ4+aT79/Q1coth/3kppF2C+9j7/E2rnzTWhHKrtDg5mpWgVK941oz6smRfzyJVfCgt6i76zdtgrD8zGrGGY+UYXJ+29ojIFl5AsxmHWVCkEMXLHQ5ilBeSdpLOPbXK/A4vroSBMKSf/JJ5eNDkwbCl0eQwMbvf+xhhJOvUx4=
Received: from BLUPR0501MB2051.namprd05.prod.outlook.com (10.164.23.21) by BLUPR0501MB2049.namprd05.prod.outlook.com (10.164.23.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.919.10; Thu, 16 Feb 2017 17:56:24 +0000
Received: from BLUPR0501MB2051.namprd05.prod.outlook.com ([10.164.23.21]) by BLUPR0501MB2051.namprd05.prod.outlook.com ([10.164.23.21]) with mapi id 15.01.0919.013; Thu, 16 Feb 2017 17:56:24 +0000
From: Ron Bonica <rbonica@juniper.net>
To: "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "draft-ietf-idr-sla-exchange.all@ietf.org" <draft-ietf-idr-sla-exchange.all@ietf.org>, "idr@ietf.org" <idr@ietf.org>
Thread-Topic: RtgDir review: draft-ietf-idr-sla-exchange-10
Thread-Index: AdKIcLCEU+uutt39QyCrZCwOKAXyLQ==
Date: Thu, 16 Feb 2017 17:56:24 +0000
Message-ID: <BLUPR0501MB205181BB8965FA5353E28162AE5A0@BLUPR0501MB2051.namprd05.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=rbonica@juniper.net;
x-originating-ip: [66.129.241.11]
x-ms-office365-filtering-correlation-id: c867edc4-0cbe-4c11-9936-08d456951fb2
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081); SRVR:BLUPR0501MB2049;
x-microsoft-exchange-diagnostics: 1; BLUPR0501MB2049; 7:OFMFT7Xw4vxBxS4PcWaI25iPkiAuDoEynDlKhU4I17Fo3nnaRFdy6ZQ6XA+mHRP8EJfLRJv1PqHbNSlCiyIUgUXoHpnv3ZRBZ9nlQdT12g1XsLdH7AfO44nkud4HRT0zq8oJxPVhiZ3cRfjn02AR9uY0V0SzMD4x4V+4HSOg1f6XDSX77eMfd+ns90YvAl+cH+bga/eLuiOcU/bzYPhW4ewoZawAYL+BWYuxPF/FPmVhI0ogKx96buNLis6aMBrSiiwmWP5XZ6fJXr7PBOWmXCV+EncXI+CKvA9K3lryobZ/oxK0J7ZdecTyz+VU/nij5y5n6MLgpu+QNA8Ws13G/A==
x-microsoft-antispam-prvs: <BLUPR0501MB20495E4A625F398C4D5A8B0FAE5A0@BLUPR0501MB2049.namprd05.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(192374486261705);
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026)(6041248)(20161123564025)(20161123558025)(20161123555025)(20161123560025)(20161123562025)(6072148); SRVR:BLUPR0501MB2049; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0501MB2049;
x-forefront-prvs: 0220D4B98D
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(7916002)(39850400002)(39450400003)(39840400002)(39860400002)(39410400002)(199003)(189002)(81166006)(101416001)(9686003)(8676002)(81156014)(1720100001)(92566002)(2900100001)(50986999)(230783001)(189998001)(97736004)(54356999)(66066001)(106356001)(2906002)(68736007)(33656002)(122556002)(105586002)(3280700002)(86362001)(55016002)(77096006)(8936002)(6116002)(2501003)(2201001)(6436002)(25786008)(3846002)(6506006)(99286003)(102836003)(3660700001)(74316002)(305945005)(7696004)(53936002)(5660300001)(7736002)(450100001)(38730400002)(389900003); DIR:OUT; SFP:1102; SCL:1; SRVR:BLUPR0501MB2049; H:BLUPR0501MB2051.namprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en;
received-spf: None (protection.outlook.com: juniper.net does not designate permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: juniper.net
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Feb 2017 17:56:24.6902 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: bea78b3c-4cdb-4130-854a-1d193232e5f4
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0501MB2049
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/MMgsy1JGZtXeZKeTjulcqcmpsws>
Subject: [Idr] RtgDir review: draft-ietf-idr-sla-exchange-10
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Feb 2017 17:56:31 -0000

Hello,

I have been selected as the Routing Directorate reviewer for this draft. The Routing Directorate seeks to review all routing or routing-related drafts as they pass through IETF last call and IESG review. The purpose of the review is to provide assistance to the Routing ADs. For more information about the Routing Directorate, please see ​http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir

Although these comments are primarily for the use of the Routing ADs, it would be helpful if you could consider them along with any other IETF Last Call comments that you receive, and strive to resolve them through discussion or by updating the draft.

Document:  draft-ietf-idr-sla-exchange-10
Reviewer: Ron Bonica
Review Date:  2/16/2017
IETF LC End Date: TBD 
Intended Status: Standards Track

Summary: 

I have some minor concerns about this document that I think should be resolved before publication.

Comments: 

Major Issues: 

This document might benefit from discussion of operational issues. I assume that when a BGP listener learns a route with the SLA Exchange Attribute, it provisions class of service forwarding classes on interfaces. I also assume that a) it takes time to provision class of service forwarding classes and b) the number of forwarding classes that can be provisioned are finite. What does the BGP listener do when the number of forwarding classes requested exceeds its capacity to deliver? When a route flaps? How does the router protect itself

In the Security Considerations section, I am concerned about the possibility of intermediate AS's modifying the SLA Exchange Attribute. It seems that you need to have some degree of trust in every AS on the path (not only those included in the attribute)


Minor Issues: 

In Section 3.2, is the flag really needed? Doesn't an AS list containing only the receivers AS have exactly the same meaning?

Nits: 

Miscellaneous warnings:
  ----------------------------------------------------------------------------

  == The document seems to use 'NOT RECOMMENDED' as an RFC 2119 keyword, but
     does not include the phrase in its RFC 2119 key words list.


  Checking references for intended status: Proposed Standard
  ----------------------------------------------------------------------------

     (See RFCs 3967 and 4897 for information about using normative references
     to lower-maturity documents in RFCs)

  == Unused Reference: 'RFC2434' is defined on line 1279, but no explicit
     reference was found in the text

  == Unused Reference: 'RFC6793' is defined on line 1301, but no explicit
     reference was found in the text

  ** Obsolete normative reference: RFC 2434 (Obsoleted by RFC 5226)

  ** Downref: Normative reference to an Informational RFC: RFC 4272

  ** Downref: Normative reference to an Informational RFC: RFC 7132

  == Outdated reference: draft-ietf-netconf-restconf has been published as
     RFC 8040