[Idr] Éric Vyncke's Discuss on draft-ietf-idr-flow-spec-v6-19: (with DISCUSS and COMMENT)
Éric Vyncke via Datatracker <noreply@ietf.org> Wed, 04 November 2020 07:35 UTC
Return-Path: <noreply@ietf.org>
X-Original-To: idr@ietf.org
Delivered-To: idr@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 34ADB3A0C6A; Tue, 3 Nov 2020 23:35:05 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Éric Vyncke via Datatracker <noreply@ietf.org>
To: The IESG <iesg@ietf.org>
Cc: draft-ietf-idr-flow-spec-v6@ietf.org, idr-chairs@ietf.org, idr@ietf.org, Jie Dong <jie.dong@huawei.com>, aretana.ietf@gmail.com, jie.dong@huawei.com
X-Test-IDTracker: no
X-IETF-IDTracker: 7.21.0
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Éric Vyncke <evyncke@cisco.com>
Message-ID: <160447530519.19838.7495034603697648657@ietfa.amsl.com>
Date: Tue, 03 Nov 2020 23:35:05 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/NykzGeCnucHZynButyB8iJLQkkY>
Subject: [Idr] Éric Vyncke's Discuss on draft-ietf-idr-flow-spec-v6-19: (with DISCUSS and COMMENT)
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Nov 2020 07:35:05 -0000
Éric Vyncke has entered the following ballot position for draft-ietf-idr-flow-spec-v6-19: Discuss When responding, please keep the subject line intact and reply to all email addresses included in the To and CC lines. (Feel free to cut this introductory paragraph, however.) Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html for more information about IESG DISCUSS and COMMENT positions. The document, along with other ballot positions, can be found here: https://datatracker.ietf.org/doc/draft-ietf-idr-flow-spec-v6/ ---------------------------------------------------------------------- DISCUSS: ---------------------------------------------------------------------- Thank you for the work put into this document. It is indeed due time to filter also those IPv6 packets ;-) Please find below one blocking DISCUSS point, some non-blocking COMMENT points, and some nits. I hope that this helps to improve the document, Regards, -éric == DISCUSS == I am puzzled by the absence of a flow spec for the first Next-Header being a specific value and by the absence of a flowspec for the occurence of any extension header in the extension header chain. Extension headers are an important difference compared to IPv4 and could be 'nasty' as well (e.g., hop-by-hop header). Why was this not considered by the authors ? Or is there another document in the WG to address this issue ? ---------------------------------------------------------------------- COMMENT: ---------------------------------------------------------------------- == COMMENTS == -- Section 3.1 -- Smart idea to have an offset but I wonder whether "Offset < Length < 129" is true... Esp. with some IPv6 addresses with an embedded IPv4 address (32 bit) at offset 96. Isn't "Offset + Length <= 128" better ? -- Section 3.3 -- How is the upper-layer defined here? Basically, how a node can determine whether it is an extension header or an upper-layer header? While I agree that there are not too many new upper-layer protocols being specified, I would prefer to have a definition of "upper-layer" here either by listing (or referring to a IANA registry) all existing extension headers (then all 'next header' not being 'extension header' are by default 'upper layer') or vice-versa. -- Section 3.6 -- Just curious ;-) Why is bit 7 not used in this encoding ? -- Section 3.7 -- I share Ben Kaduk's concern about the encoding of the flow label in less than 20 bits. == NITS == -- Section 3.1 (and possibly others) -- Sometimes the field 'length' is all lower case and sometimes it is capitalized. -- Section 3.8.2 (and possibly others) -- Please use RFC 5952 to write IPv6 addresses.
- [Idr] Éric Vyncke's Discuss on draft-ietf-idr-flo… Éric Vyncke via Datatracker
- Re: [Idr] Éric Vyncke's Discuss on draft-ietf-idr… Christoph Loibl
- Re: [Idr] Éric Vyncke's Discuss on draft-ietf-idr… Alvaro Retana
- Re: [Idr] Éric Vyncke's Discuss on draft-ietf-idr… Eric Vyncke (evyncke)
- Re: [Idr] Éric Vyncke's Discuss on draft-ietf-idr… Susan Hares
- Re: [Idr] Éric Vyncke's Discuss on draft-ietf-idr… Eric Vyncke (evyncke)
- Re: [Idr] Éric Vyncke's Discuss on draft-ietf-idr… Robert Raszuk
- Re: [Idr] Éric Vyncke's Discuss on draft-ietf-idr… Eric Vyncke (evyncke)
- Re: [Idr] Éric Vyncke's Discuss on draft-ietf-idr… Susan Hares