Re: [Idr] AD Review of draft-ietf-idr-eag-distribution-15

[Alvaro Retana <[e-mail]>]

On April 18, 2021 at 7:47:22 PM, Jeff Tantsura wrote:


Jeff:

Hi!

Just a couple of points -- one major.  I'm starting the IETF Last Call.

Thanks!

Alvaro.



...
> > 70 1. Introduction
> >
> > 72 Administrative groups (commonly referred to as "colors" or "link
> > 73 colors") are link attributes that are advertised by link state
> > 74 protocols like IS-IS [RFC5305], OSPFv2 [RFC3630] and OSPFv3 [RFC5329]
> > 75 for traffic engineering use-cases. The BGP-LS advertisement of the
> > 76 originally defined (non-extended) administrative groups is encoded
> > 77 using the Administrative Group (color) TLV 1088 as defined in
> > 78 [RFC7752].
> >
> > [minor] "IS-IS [RFC5305], OSPFv2 [RFC3630] and OSPFv3 [RFC5329]"
> > These references should point at the protocols themselves, not the TE
> > extensions. Also, these references can be Informative.
>
> [jeff] ack, changed
> [jeff] Alvaro - this is the text from 7308, that specifically calls out TE
> documents -
> "This document defines the Extended Administrative Group (EAG) sub-TLVfor
> both OSPF [RFC3630] and IS-IS [RFC5305].” ?

The text refers to the protocols ("protocols like...").  It's ok if
you want to change the text slightly to the TE extensions.



...
> > 133 o Value: one or more sets of 32-bit bitmasks that indicate the
> > 134 administrative groups (colors) that are enabled on the link when
> > 135 those specific bits are set.
> >
> > [major] rfc7308 talks about an "Extended Admin Group" (singular!), and
> > not a set of groups. This TLV is then not in line with rfc7308.
> >
> > The whole document should be checked for (editorial) compliance with
> > the concept of a single EAG.
> >
> [jeff] ack, i believe now it reads correct

I may be wrong, but rfc7308 and the encoding on this document give the
impression that you only carry one EAG, not "one or more sets".  Did I
miss something?  If multiple EAGs can be carried I think there's an
extra length missing: the TLV only has the total length, not the
length of each EAG.