Re: [Idr] draft-ietf-bgp-gr-notification-07

"Susan Hares" <shares@ndzh.com> Wed, 15 June 2016 20:23 UTC

From: Susan Hares <shares@ndzh.com>
To: 'Mach Chen' <mach.chen@huawei.com>, draft-ietf-idr-bgp-gr-notification@tools.ietf.org, "'John G. Scudder'" <jgs@juniper.net>
Date: Wed, 15 Jun 2016 16:22:55 -0400
Message-ID: <04ee01d1c743$b50c6640$1f2532c0$@ndzh.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Thread-Index: AdHHQ6WVSH/gkUU0QaGMk9Q8aQOyzA==
Content-Language: en-us
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/P2iEZMDyKOZPSTdqXfV2Jr2FTF4>
Cc: 'Jonathan Hardwick' <Jonathan.Hardwick@metaswitch.com>, rtg-dir@ietf.org, idr@ietf.org, "'Zhangxian (Xian)'" <zhang.xian@huawei.com>, rtg-ads@tools.ietf.org
Subject: Re: [Idr] draft-ietf-bgp-gr-notification-07
Precedence: list

Mach: 

Thank you for reviewing draft-ietf-bgp-gr-notification-07.txt.

Sue 

-----Original Message-----
From: Mach Chen [mailto:mach.chen@huawei.com] 
Sent: Wednesday, June 15, 2016 5:31 AM
To: draft-ietf-idr-bgp-gr-notification@tools.ietf.org; Susan Hares; 'John G.
Scudder'
Cc: rtg-ads@tools.ietf.org; rtg-dir@ietf.org; Jonathan Hardwick; Zhangxian
(Xian); idr@ietf.org
Subject: 

Hi Authors,

I was assigned to do a QA review on draft-ietf-idr-bgp-gr-notification-07.
For more detail what's is RtgDir QA review, please refer to
https://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDirDocQa 

Overall, the document is well-written and clear, after review, I have the
following comments. 

1.  Abstract
s/BGP NOTIFICATION Message/ BGP NOTIFICATION message;

2.  Section 2:
"
    Flags for Address Family:

            This field contains bit flags relating to routes that were
            advertised with the given AFI and SAFI.

                0 1 2 3 4 5 6 7
               +-+-+-+-+-+-+-+-+
               |F|N| Reserved  |
               +-+-+-+-+-+-+-+-+

   The usage of second most significant bit "N" (which was defined in a
   previous draft version of this specification) is deprecated.  This
   bit MUST be advertised as 0 and MUST be ignored upon receipt.
"
The "N" bit was firstly introduced in a previous version of this document,
but deprecated in later version. I don't understand why a document need
deprecate a functionality introduced by itself, why not just remove it? If
we really want to keep this history, maybe a better way is to move above
text to an appendix.  

If you agree above, then the last sentence of the first paragraph of section
2 should be changed as bellow:

OLD:
"the Restart flags field and the Flags field for Address Family are
augmented as follows:"

New:
"the Restart flags field are augmented as follows:"

3.  Section 3.1

"Subcode is a BGP Error Subcode (as documented in the IANA BGP Error
   Subcodes registry) as appropriate for the ErrCode.  Similarly, Data
   is as appropriate for the ErrCode and Subcode."
This is just an introduction to the Subcode itself, it's better to
explicitly state that the subcode should be set to the Hard Reset (9).

Hope you find above review useful.

Best regards,
Mach

Re: [Idr] draft-ietf-bgp-gr-notification-07 Susan Hares