[Idr] Re: AD Review of draft-ietf-idr-bgp-sendholdtimer-10
Job Snijders <job@fastly.com> Mon, 01 July 2024 01:52 UTC
Return-Path: <jsnijders@fastly.com>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6E6B8C151097 for <idr@ietfa.amsl.com>; Sun, 30 Jun 2024 18:52:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.093
X-Spam-Level:
X-Spam-Status: No, score=-2.093 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_KAM_HTML_FONT_INVALID=0.01, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=fastly.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JLoqz4fSYlts for <idr@ietfa.amsl.com>; Sun, 30 Jun 2024 18:52:12 -0700 (PDT)
Received: from mail-oo1-xc30.google.com (mail-oo1-xc30.google.com [IPv6:2607:f8b0:4864:20::c30]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 636CBC151093 for <idr@ietf.org>; Sun, 30 Jun 2024 18:52:12 -0700 (PDT)
Received: by mail-oo1-xc30.google.com with SMTP id 006d021491bc7-5c2201ffb1bso1264662eaf.2 for <idr@ietf.org>; Sun, 30 Jun 2024 18:52:12 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1719798731; x=1720403531; darn=ietf.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=yc5Frm6lNGICo1HPnML3oAP7B8rykfhJp4wfi/xrThk=; b=JbxS2cI9mtITDdp9nJBm462/0poEf60o6XqYKLtivn86IbXfxpcIRnpVKWI3ZEVTpw Xz2CR6X2BqfobBDujjaba0QV7bE2n2wm/kOgRCsKx4oworpMqjmUSz3vAGXt+jlnT9Ar 5x/F+Wd564BPN/wGp5dbIku7bEwOQuIYJFR00=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719798731; x=1720403531; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yc5Frm6lNGICo1HPnML3oAP7B8rykfhJp4wfi/xrThk=; b=hrSuB6QIg2uqzygfoQ/YCgcpzqB22HO0dsefJTb8eaKUYTyNxC+v+0g8AoRbv7TopM V6+wdxk4tBWIWDyo+z5rvwFm8be5tQxmaDCGCr6ivFdZu0+G287PzYA6jXVtxkFkRPN8 6ZyA8ju9W96PHRey99X3yaonRsVoTxk1kSf/sTOfwyahX/YtcQJoVDCSum8LmLeLdLoS D6ZSXj5SyyniL9JxlXykTTzNQ744LxODyQY1Af02FVHCbkb9zFzn2on0k+C9Fsr+lJ/q /AbCLD5PN9nQzFqWNWwNfJXswpjaicPILMtHD1Jn7Te0gJTvqXgFJscOATReVCnVCNG4 PSTQ==
X-Forwarded-Encrypted: i=1; AJvYcCXJMCoBqCY0GlW0pAAQPUZeMXMx2havcLfP3w1CjL95AJMOr6JO3/pfvLtwvvhEHF+EmWSPnEfcjE7UXcs=
X-Gm-Message-State: AOJu0YxQb4JMeIwjZ/2uTN6ISZExEoSv+K5BGHsRXDTXS3xJH+RjIDDS TTlA1OnBS88FNUYED3VWfuvfpsj8ymAPwHhtRFq5W0pFb0jPzGXC6E7x2aaROfIBWte9J23GJVe qPuzCCl/QQXRigmTzgVYGiLdoESXamtbuC3sm2g==
X-Google-Smtp-Source: AGHT+IEADv9X1BlGjFOacZDACZSTb/Tp1ee49wBk2pvizLYcxUV42HgnRLLB1LpNBeYKdVmw26Ehvt0rCmoi314m1WY=
X-Received: by 2002:a4a:240c:0:b0:5c4:43a2:d4d9 with SMTP id 006d021491bc7-5c443a2d55fmr2269583eaf.9.1719798731146; Sun, 30 Jun 2024 18:52:11 -0700 (PDT)
MIME-Version: 1.0
References: <BN2P110MB11075E385EA61E9D9DB2918EDCD5A@BN2P110MB1107.NAMP110.PROD.OUTLOOK.COM> <BN2P110MB11072976193ABF423AC4FD6CDCD5A@BN2P110MB1107.NAMP110.PROD.OUTLOOK.COM> <CABY-gOPvMr=TrjYFyVtUokhWkaU28sD_n5d_eC4qPX45vmDbLA@mail.gmail.com>
In-Reply-To: <CABY-gOPvMr=TrjYFyVtUokhWkaU28sD_n5d_eC4qPX45vmDbLA@mail.gmail.com>
From: Job Snijders <job@fastly.com>
Date: Mon, 01 Jul 2024 10:51:59 +0900
Message-ID: <CAMFGGcCP_hg3naBeEn4APZUuV4MFCiueuQJnTqyQwPpbKzoG0w@mail.gmail.com>
To: Yingzhen Qu <yingzhen.ietf@gmail.com>
Content-Type: multipart/alternative; boundary="00000000000074a02c061c25d824"
Message-ID-Hash: PBZAA2LAIEKPT7GREMQIRTXCNINL26KK
X-Message-ID-Hash: PBZAA2LAIEKPT7GREMQIRTXCNINL26KK
X-MailFrom: jsnijders@fastly.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-idr.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: Roman Danyliw <rdd@cert.org>, "idr@ietf.org" <idr@ietf.org>
X-Mailman-Version: 3.3.9rc4
Precedence: list
Subject: [Idr] Re: AD Review of draft-ietf-idr-bgp-sendholdtimer-10
List-Id: Inter-Domain Routing <idr.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/QjuQ9cGkCghHL0wAyCwXwHsKG-U>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Owner: <mailto:idr-owner@ietf.org>
List-Post: <mailto:idr@ietf.org>
List-Subscribe: <mailto:idr-join@ietf.org>
List-Unsubscribe: <mailto:idr-leave@ietf.org>
On Mon, 1 Jul 2024 at 10:41, Yingzhen Qu <yingzhen.ietf@gmail.com> wrote: > Hi Roman, > > Thanks for the review and comments. I've uploaded version -11 to address > your comments. Please see detailed answers inline below. > > Thanks, > Yingzhen > > On Tue, Jun 25, 2024 at 8:48 AM Roman Danyliw <rdd@cert.org> wrote: > >> Hi! >> >> I'm swapping with John and stepping in as the responsible AD for >> draft-ietf-idr-bgp-sendholdtimer. I performed an AD review on >> draft-ietf-idr-bgp-sendholdtimer-10. Thanks for this document. My >> feedback is as follows: >> >> ** idnits reports: >> >> -- The document seems to lack a disclaimer for pre-RFC5378 work, but may >> have content which was first submitted before 10 November 2008. If >> you >> have contacted all the original authors and they are all willing to >> grant >> the BCP78 rights to the IETF Trust, then this is fine, and you can >> ignore >> this comment. If not, you may need to add the pre-RFC5378 >> disclaimer. >> (See the Legal Provisions document at >> https://trustee.ietf.org/license-info for more information.) >> >> Have the original authors been contact or should the alternative >> boilerplate be used? >> > > [Yingzhen]: updated to use "pre5378Trust200902". > I am not sure that’s needed. As far as I can tell idnits is being too conservative in this instance. Multiple updates to RFC 4271 have been performed over the last few years with the trust200902, where one or two sentences were copied to indicate the “new text” insertion point, for example RFC 8212. I’m also under the impression the original authors granted the IETF Trust some rights. I’d prefer if we change the boilerplate back. Kind regards, Job
- [Idr] AD Review of draft-ietf-idr-bgp-sendholdtim… Roman Danyliw
- [Idr] Re: AD Review of draft-ietf-idr-bgp-sendhol… Yingzhen Qu
- [Idr] Re: AD Review of draft-ietf-idr-bgp-sendhol… Job Snijders
- [Idr] Re: AD Review of draft-ietf-idr-bgp-sendhol… Jeffrey Haas
- [Idr] Re: AD Review of draft-ietf-idr-bgp-sendhol… Yingzhen Qu
- [Idr] Re: AD Review of draft-ietf-idr-bgp-sendhol… Yingzhen Qu