Re: [Idr] Fwd: New Version Notification for draft-spaghetti-idr-bgp-sendholdtimer-05.txt

Donatas Abraitis <donatas.abraitis@gmail.com> Wed, 03 August 2022 07:40 UTC

Return-Path: <donatas.abraitis@gmail.com>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5B614C13CCD9 for <idr@ietfa.amsl.com>; Wed, 3 Aug 2022 00:40:45 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.104
X-Spam-Level:
X-Spam-Status: No, score=-2.104 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PzISDgxndGJH for <idr@ietfa.amsl.com>; Wed, 3 Aug 2022 00:40:41 -0700 (PDT)
Received: from mail-ot1-x329.google.com (mail-ot1-x329.google.com [IPv6:2607:f8b0:4864:20::329]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 93D0FC15948E for <idr@ietf.org>; Wed, 3 Aug 2022 00:40:41 -0700 (PDT)
Received: by mail-ot1-x329.google.com with SMTP id q6-20020a05683033c600b0061d2f64df5dso10240753ott.13 for <idr@ietf.org>; Wed, 03 Aug 2022 00:40:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LB/UIJJinkxiBfqroodD1ZWp0VSOHVM4LcroOf0xIEU=; b=D/2/2MgEqGesB7mnyJzqWflu5NOkIUfGvaDHlJREUZrnFB6GJ3E8FrlfaD/EPSR2Kf A99r5fkie+6/Y4dgAnh/TdFYrOc2v8v3luA3tszgmbYFqQ+gSdmTLBUM/KgJfhT8U7wC 4eSrkURJNbCMD6lK9EnHUaDg67wtGSAYYo9RLo8ZQpGZ0lHkgvbP6a1HDMOriktDmPp/ TZr/t5MS2+UWQgXfcq9yA9BTnSkBH5FAVvuIPZIUcMcrR03PfESucuqwZWJlKj8y9M+g 2cgokPYlAyrUezmkXa86USYgnxBM90UbuqMza2G8VFbaqZ8KlNmeHZ9zmG1pcaiVnFOZ i/Lw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LB/UIJJinkxiBfqroodD1ZWp0VSOHVM4LcroOf0xIEU=; b=VA3hwN6uEvz8ykhD/VOmS2clCwHbNUDJR1mjF9chrwn7EEeg0wbtGSc9iKELNu8TJd hzQw6Gy7+3ep7ou3suoxed3TauLxNPT9L6HBxbyKBjoxMN7L/mt5QSnAKOmGdyVHyz4d PDrHRMjdar4EBuMBbwp1tnPwC0FtCpwEc2ZMzvizTUcHiUN7rAfySWkZJ0e+PbxHNbe5 BhhvOgFHY+HvTyMCqHTa68DzFO/+9zGfyn/lD27NE26GHu3kUdsHMkhIPT3/YrHFowNY Qg5ikM4e5v+E4qjuqysu0laWuILl/pSecrji8lhSEJncOXKRUisO8ThohwD0SyZeYje+ tPIg==
X-Gm-Message-State: AJIora+c4Dqk8eUWR1UKlS3i4bVsAaD6IG6HYqf4+mPGK8djDqi6bbiQ nn/K62GwhAwZ81z68aOl/3oIM3M7CYbdQjt5bLM=
X-Google-Smtp-Source: AGRyM1tPa9pmnwnz5oojO88ug4N29QwwOXOMub2e2fWtm1stUcuxkXUgJwbRNYShueHk6Uqvz95oXT2qKkW/UZjPqrU=
X-Received: by 2002:a05:6830:1b68:b0:61d:2520:59dd with SMTP id d8-20020a0568301b6800b0061d252059ddmr8690062ote.217.1659512440489; Wed, 03 Aug 2022 00:40:40 -0700 (PDT)
MIME-Version: 1.0
References: <CAOj+MME7XnW7kDXL4muh4Qp1UvabQ9amUoU0Sn3h2axqKzswzA@mail.gmail.com> <77F3E1F0-486F-47DF-ABE4-EFDB9C2FB6D8@gmail.com> <CAOj+MMGR4f3eLEDZY++1m4Lpo9joG4L9OrWbeF6kREn-9a9onA@mail.gmail.com> <c6e44213-7667-0f67-71a4-634411cd102b@foobar.org> <CAOj+MMFajL6E42WCzC0ZqrfSBZjU-0B=ZzmtvCRPkuMzU8z5QA@mail.gmail.com> <Yun6e5jSb0OYZGAX@shrubbery.net>
In-Reply-To: <Yun6e5jSb0OYZGAX@shrubbery.net>
From: Donatas Abraitis <donatas.abraitis@gmail.com>
Date: Wed, 03 Aug 2022 10:40:28 +0300
Message-ID: <CAPF+HwXTqXvPx=MpZheh4-_o6=mXLEzURARtUce4HHXS6f1bRQ@mail.gmail.com>
To: heasley <heas@shrubbery.net>
Cc: Robert Raszuk <robert@raszuk.net>, "idr@ietf. org" <idr@ietf.org>, Job Snijders <job=40fastly.com@dmarc.ietf.org>
Content-Type: multipart/alternative; boundary="000000000000840bdc05e551596b"
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/T09KqVEZhD1_WzQ0rF7UWLgA0Vs>
Subject: Re: [Idr] Fwd: New Version Notification for draft-spaghetti-idr-bgp-sendholdtimer-05.txt
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Aug 2022 07:40:45 -0000

Hi, All!

did I miss or it's not included how to handle SendHoldTimer_Expires if
Graceful-Restart Notification support is enabled (rfc8538)?

If rfc8538 is negotiated and HoldTimer_Expires happens, routes are retained.

I believe with this timer, we SHOULD do the same?

On Wed, Aug 3, 2022 at 7:33 AM heasley <heas@shrubbery.net> wrote:

> Sun, Jul 31, 2022 at 11:46:12PM +0200, Robert Raszuk:
> > >
> > > > If the RCV window is 0 how can TCP send anything to the peer
> including
> > > > TCP RST ?
> > >
> > > the payload of a rst packet can be zero length. also, psh may be set.
> > >
> >
> > That does not mean that remote peer with receive it and process it.
> > Especially if it is hosed.
>
> Even if the remote (stuck) peer does not process the FIN, the local
> end will close the session and stop forwarding traffic that direction.
> That is an improvement, from an operator's PoV, both for forwarding
> errors and local resources.
>
> > > > If the peer is saturated, how good is it to assign a new IANA
> > > > error notification code if it can not be sent to the peer ?
> > >
> > > same as draft-ietf-idr-bfd-subcode: it's to allow the sending side
> > > to log the failure in the bgpPeerLastError oid of the relevant bgp
> > > mib, which will be visible to monitoring systems.
> > >
> >
> > Well it is not about bgp peer's error .. it is about our side not able to
> > sent much. so if this is just no keepalives it needs to be lot's of them
> to
> > saturate the socket. Otherwise how would BGP know that its socket to the
> > peer does not drain ?
>
> The buffer is not necessarily filled by KAs, it can be NLRI.  Technically,
> the window could have closed for any reason the peer wishes and might not
> have been caused by bgp itself.  Also, the buffer is not necessarily large
> and how long it takes to fill is irrelevant.
>
> A different notification allows the operator to differentiate between
> causes
> of session failure, aiding debugging.
>
> _______________________________________________
> Idr mailing list
> Idr@ietf.org
> https://www.ietf.org/mailman/listinfo/idr
>


-- 
Donatas