Re: [Idr] draft-ietf-idr-ext-opt-param-06.txt - 2 Week WG LC (7/30 to 8/13/2019)

<bruno.decraene@orange.com> Wed, 31 July 2019 09:17 UTC

Return-Path: <bruno.decraene@orange.com>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5AC92120122 for <idr@ietfa.amsl.com>; Wed, 31 Jul 2019 02:17:43 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.598
X-Spam-Level:
X-Spam-Status: No, score=-2.598 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9CruwLO3EEjg for <idr@ietfa.amsl.com>; Wed, 31 Jul 2019 02:17:41 -0700 (PDT)
Received: from relais-inet.orange.com (relais-inet.orange.com [80.12.66.41]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B2B4812011F for <idr@ietf.org>; Wed, 31 Jul 2019 02:17:40 -0700 (PDT)
Received: from opfedar01.francetelecom.fr (unknown [xx.xx.xx.2]) by opfedar21.francetelecom.fr (ESMTP service) with ESMTP id 45z79t6FBlz7tx1; Wed, 31 Jul 2019 11:17:38 +0200 (CEST)
Received: from Exchangemail-eme6.itn.ftgroup (unknown [xx.xx.13.107]) by opfedar01.francetelecom.fr (ESMTP service) with ESMTP id 45z79t56XMzBrLx; Wed, 31 Jul 2019 11:17:38 +0200 (CEST)
Received: from OPEXCAUBM43.corporate.adroot.infra.ftgroup ([fe80::b846:2467:1591:5d9d]) by OPEXCAUBM8F.corporate.adroot.infra.ftgroup ([::1]) with mapi id 14.03.0439.000; Wed, 31 Jul 2019 11:17:38 +0200
From: <bruno.decraene@orange.com>
To: Susan Hares <shares@ndzh.com>, "idr@ietf.org" <idr@ietf.org>
Thread-Topic: [Idr] draft-ietf-idr-ext-opt-param-06.txt - 2 Week WG LC (7/30 to 8/13/2019)
Thread-Index: AdVG8AEgtJ8an9KITLaaaGetwJsC1QAg/HfA
Date: Wed, 31 Jul 2019 09:17:37 +0000
Message-ID: <1810_1564564658_5D415CB2_1810_231_1_53C29892C857584299CBF5D05346208A48BC18C5@OPEXCAUBM43.corporate.adroot.infra.ftgroup>
References: <000801d546f0$b9d27310$2d775930$@ndzh.com>
In-Reply-To: <000801d546f0$b9d27310$2d775930$@ndzh.com>
Accept-Language: fr-FR, en-US
Content-Language: fr-FR
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.114.13.245]
Content-Type: multipart/alternative; boundary="_000_53C29892C857584299CBF5D05346208A48BC18C5OPEXCAUBM43corp_"
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/TLDmxKPwDGFkRRpm9Wk0_p_obKU>
Subject: Re: [Idr] draft-ietf-idr-ext-opt-param-06.txt - 2 Week WG LC (7/30 to 8/13/2019)
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 31 Jul 2019 09:17:43 -0000

Hi Sue,

Fully support.
I'm also fine with the _current_ version of the document.

Nevertheless, I'll try some comments, possibly useless but at minimum to show to the shepherd/AD that I've read and reviewed the doc.


1.  Introduction
[...]
The Parameter Length field of individual Optional Parameters is similarly extended.

I would rather remove 'similarly' or change it to 'also'. As although the technical specification is crystal clear, I fear that the sentence could be interpreted as the length field for individual optional parameters been extended the same way (length 255, followed by extended length) while this is not the case.

---

The (non-extended) length field is set to

   255, as is the subsequent octet that in the non-extended format would

   be the first Optional Parameter Type.  The subsequent two octets

   carry the actual length.

This works so let it be so.
One could have argued that this encoding is borderline as per RFC 4271. May be an encoding  more in line with 4271 could have been Type: 255, Length: 2, Value: actual/extended length. (i.e. adding/keeping the 'length' field of the Optional Parameter type 255). That would also have been more friendly for protocol parser (e.g. wireshark) especially since there is a chance that network operator get surprised the first time that the BGP session get rejected and may want to have a look at the open message).
Note that I understand that my comment is way too late ... and also a matter of opinion.
---

   In the event that the length of Optional Parameters in the BGP OPEN

   message does not exceed 255, the encodings of the base BGP

   specification [RFC4271<https://tools.ietf.org/html/rfc4271>] MUST be used without alteration.

Could the document define the error handling if this MUST is not followed? I believe any option (notification or silently ignore) works, but in general I have a preference for error handling to be covered by the spec.

That may also be the opportunity to remove the following sentence "If the value of this field is zero, no Optional Parameters are present (this would never be expected to happen with the extended encoding, however). > which is both not general enough (does not cover length 1-254) and appears in the general specification/behavior while it's about error handling.
---
As of 2019, I feel that this extension may have been an opportunity to also enable the use of BGP extended message length for the BGP OPEN message. (if the "BGP Extended Message" capability was also exchanged.). Alternatively, the burden of defining this could also been in draft-ietf-idr-bgp-extended-messages. But probably too late for both documents so let's move forward.

Thanks,
Regards,
--Bruno


From: Idr [mailto:idr-bounces@ietf.org] On Behalf Of Susan Hares
Sent: Tuesday, July 30, 2019 6:06 PM
To: idr@ietf.org
Subject: [Idr] draft-ietf-idr-ext-opt-param-06.txt - 2 Week WG LC (7/30 to 8/13/2019)

This begins a 2 week working group last call on draft-ietf-idr-ext-opt-param-06.txt from 7/30 to 8/13/2019.

You can access the draft at:

https://datatracker.ietf.org/doc/draft-ietf-idr-ext-opt-param/

John and Enke - I am counting on you gather information on the 2 implementations and post this on the IDR Wiki during these 2 weeks.

For the WG, consider if:


1)      The technology is ready for publication or if there are flaws that prevent its publication,

2)      Is this technology useful to BGP deployments?

3)      Are there any minor editorial errors the authors should address before publication.


Cheerily, Sue Hares




_________________________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.