Re: [Idr] I-D Action: draft-ietf-idr-bgp-model-04.txt

Mahesh Jethanandani <mjethanandani@gmail.com> Fri, 22 March 2019 02:02 UTC

Return-Path: <mjethanandani@gmail.com>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 96E19130DDA for <idr@ietfa.amsl.com>; Thu, 21 Mar 2019 19:02:28 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.998
X-Spam-Level:
X-Spam-Status: No, score=-0.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XUXKtKmmqqAN for <idr@ietfa.amsl.com>; Thu, 21 Mar 2019 19:02:26 -0700 (PDT)
Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EB41012AF7E for <idr@ietf.org>; Thu, 21 Mar 2019 19:02:25 -0700 (PDT)
Received: by mail-pg1-x536.google.com with SMTP id y3so338940pgk.12 for <idr@ietf.org>; Thu, 21 Mar 2019 19:02:25 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=U7C4wtkZjC+SCTd8Xm9PMJUgGXLRysrcEQdU6JPULGI=; b=WWvqoY/aA0m9jHetwQVW9oD67Yq4mhFr1l6dY23iYcdSwdIB5y9kf77qtig+GFdHnL FBxznY+7HM5NL76KXh2Bz3JVfyJWZQeuBd1v1CtGgTTvKCak+g1W0wqxTn9/MtYGzIcw y9CdpXezH1wDvlsskrG9AoNjAhzWUtBRdwlyVA8oVhChdsB9IPTMhzxWYRxhWj0gY2OW 4I73oadpbXfVkLISxLh7BrCOSOLXi3CsgoJWBHqlCWUZdMr6KdYkYxWgz8S503TO11Dp lOwL01IXpmhY679MwumIAKtj4vh0oWIOqpJue6Y6EOLDN9qIi/aAckguoUm9vIrvzJ83 d05Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=U7C4wtkZjC+SCTd8Xm9PMJUgGXLRysrcEQdU6JPULGI=; b=hqEeS8kx7AueNO/cnQJbYtl4bpd9TE+kH7DuXUvHuD+5NGTcGU0DmJ2CcyziRBuzWK b/EVJbSD79aq94FLlCVvj/nA5Beu+BSxQp95Q2qUCUA3Y2W5bQF/WrlQPE0rzQXKBnvr yLuba5uYtV0mY8/T1YAcSK0bZJtMUO4wLyxdUE0iC5uP/gfmUjesnokRKMCdy+l7UBww uAGJgwIy1ZXpVmKZj48Xo6dqDVC9hcLanxjlsbZfxq5FQwKZwPIcv67f0wkysCv0wWN/ LiTRssZ7hUjK9BgbvA+5hgq/epB6BoWo/Q6uouJEtZe7ZJZaY+UVCVbqlzz7dLd2wpQv ruwg==
X-Gm-Message-State: APjAAAW+3EMmAC2lUN5Tj2xaOetAuzaw9QBICQ18BxHPchKaUsmVaKgy aU1nF6G1l88+iLR+o2AXWqU=
X-Google-Smtp-Source: APXvYqxcbnShwqCBOvV6kaD/20CeK5Bnhte74B1fQ9nVpd+0ya08YEij++mknNDQ9XhZGQIauorpcA==
X-Received: by 2002:a65:49c4:: with SMTP id t4mr6425630pgs.421.1553220144985; Thu, 21 Mar 2019 19:02:24 -0700 (PDT)
Received: from [10.33.123.214] ([66.170.99.1]) by smtp.gmail.com with ESMTPSA id i16sm9937876pgk.51.2019.03.21.19.02.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Mar 2019 19:02:23 -0700 (PDT)
From: Mahesh Jethanandani <mjethanandani@gmail.com>
Message-Id: <AF042808-DC84-4D10-A151-253C72CE65E0@gmail.com>
Content-Type: multipart/alternative; boundary="Apple-Mail=_EE21D333-DC32-43A4-B7DD-057EFC73A496"
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
Date: Thu, 21 Mar 2019 19:02:22 -0700
In-Reply-To: <CAEz6PPQ1un2i4U3-AYPRS+EEaiRk+N0d-3L5A9U7Kvmg2ti=DQ@mail.gmail.com>
Cc: idr@ietf.org
To: Xufeng Liu <xufeng.liu.ietf@gmail.com>
References: <155120498877.852.8582818799698080818@ietfa.amsl.com> <68805692-5B0B-4406-92DD-50529E4F8F8D@gmail.com> <CAEz6PPRvvTXOu7akEQGSCE1J+7TzLgkAOeszLhG3YroxuZ9JWw@mail.gmail.com> <F1E6C050-2592-444C-BBFF-2BD1149D3E48@gmail.com> <CAEz6PPQ1un2i4U3-AYPRS+EEaiRk+N0d-3L5A9U7Kvmg2ti=DQ@mail.gmail.com>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/eC_O5SQHcQPsLKEobCvIRIwxDOc>
Subject: Re: [Idr] I-D Action: draft-ietf-idr-bgp-model-04.txt
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Mar 2019 02:02:29 -0000

The next version of the draft (-05) to be posted on Monday, will update the model to mirror the structure similar to OSPF and IS-IS.

> On Mar 20, 2019, at 7:29 AM, Xufeng Liu <xufeng.liu.ietf@gmail.com> wrote:
> 
> Hi Mahesh,
> 
> On Tue, Mar 19, 2019 at 6:48 PM Mahesh Jethanandani <mjethanandani@gmail.com <mailto:mjethanandani@gmail.com>> wrote:
> Hi Xufeng,
> 
>> On Mar 19, 2019, at 6:31 AM, Xufeng Liu <xufeng.liu.ietf@gmail.com <mailto:xufeng.liu.ietf@gmail.com>> wrote:
>> 
>> Hi Mahesh,
>> 
>> Thanks for the update. 
>> 
>> I'd like to comment on the new changes at a high level:
>> 
>> 1) rib extension
>> This paradigm is inconsistent with other protocol models like ospf and isis, where the protocol specific routes are kept under the protocol instance tree, not under the /rt:routing/rt:ribs. Based on RFC8349, the /rt:routing/rt:ribs tree is used to model the routes per routing instance, which is better mapped to the Route Manager (whose name varies depending on the implementations).
>> 
> 
> While that might be true, routes in the BGP model currently are maintained at the per-address family level.
> 
> It is fine that routes are maintained at per-address family level, which is also done by other routing protocols. The question is how the tree hierarchy is structured. 
> OSPF model has the following:
> 
> module: ietf-routing
>   +--rw routing
>   |  +--rw control-plane-protocols
>   |  |  +--rw control-plane-protocol* [type name]
>   |  |     +--rw ospf:ospf
>   |  |        +--ro ospf:protected-routes {fast-reroute}?
>   |  |        |  +--ro ospf:af-stats* [af prefix alternate]
>   |  |        |     +--ro ospf:af   iana-rt-types:address-family
>   |  |        +--ro ospf:unprotected-routes {fast-reroute}?
>   |  |        |  +--ro ospf:af-stats* [af prefix]
>   |  |        |     +--ro ospf:af        iana-rt-types:address-family
>   |  |        +--ro ospf:local-rib
>   |  |        |  +--ro ospf:route* [prefix]
>   |  |        |     +--ro ospf:prefix        inet:ip-prefix
>   |  |        |     +--ro ospf:next-hops
>   |  |        +--ro ospf:statistics
>   |  |        +--ro ospf:database
>   |  |        |  +--ro ospf:as-scope-lsa-type* [lsa-type]
> 
> ISIS model has the following:
> 
> module: ietf-routing
>   +--rw routing
>   |  +--rw control-plane-protocols
>   |  |  +--rw control-plane-protocol* [type name]
>   |  |     +--rw isis:isis
>   |  |        +--rw isis:interfaces
>   |  |        |  +--rw isis:interface* [name]
>   |  |        |     +--rw isis:name   if:interface-ref
>   |  |        +--ro isis:database
>   |  |        |  +--ro isis:level-db* [level]
>   |  |        |     +--ro isis:level    level-number
>   |  |        |     +--ro isis:lsp* [lsp-id]
>   |  |        |        +--ro isis:decoded-completed?   boolean
>   |  |        |        +--ro isis:raw-data?     yang:hex-string
>   |  |        |        +--ro isis:lsp-id        lsp-id
>   |  |        +--ro isis:local-rib
>   |  |        |  +--ro isis:route* [prefix]
>   |  |        |     +--ro isis:prefix       inet:ip-prefix
>   |  |        |     +--ro isis:next-hops
> 
> 
> This BGP model uses operational state sub-tree mostly from the OpenConfig model, but OpenConfig does not augment ietf-routing and uses separate global tree. If we keep the OpenConfig sub-tree, it would be better to structure the BGP rip as following:
> 
> module: ietf-routing
>   +--rw routing
>   |  +--rw control-plane-protocols
>   |  |  +--rw control-plane-protocol* [type name]
>            +--rw bgp:bgp
>               +--rw global!
>               +--rw neighbors
>               |  +--rw neighbor* [neighbor-address]
>               +--rw peer-groups
>                  +--rw peer-group* [peer-group-name]
>               +--ro bgp-rib
>                  +--ro attr-sets
>                  |  +--ro attr-set* [index]
>                  |     +--ro index                   uint64
>                  +--ro afi-safis
>                     +--ro afi-safi* [afi-safi-name]
>                        +--ro afi-safi-name       identityref
>                        +--ro ipv4-unicast
>                        |  +--ro loc-rib
>                        |  |  +--ro routes
>                        |  |     +--ro route* [prefix origin path-id]
>                        +--ro ipv6-unicast
>                        |  +--ro loc-rib
>                        |  |  +--ro routes
>                        |  |     +--ro route* [prefix origin path-id]
>                        +--ro ipv4-srte-policy
>                        |  +--ro loc-rib
>                        |  |  +--ro routes
>                        |  +--ro neighbors
>                        |     +--ro neighbor* [neighbor-address]
>                        +--ro ipv6-srte-policy
>                           +--ro loc-rib
>                           |  +--ro routes
> 
> Thanks,
> - Xufeng
>  
>> 2) module ietf-bgp is missing
>> Is it intentional to remove the main module ietf-bgp? The description says that bgp model augments the ietf-routing, but there is no such an augment statement in the draft. I assume that the augment statement is in the main module ietf-bgp.
>> 
> 
> That was indeed a cut-and-paste error. The next version of the draft will have the ietf-bgp module.
> 
> Thanks.
> 
>> 
>> Thanks,
>> - Xufeng
>> 
>> On Tue, Feb 26, 2019 at 1:20 PM Mahesh Jethanandani <mjethanandani@gmail.com <mailto:mjethanandani@gmail.com>> wrote:
>> This update of the draft adds support for:
>> 
>> - augmentation of the Routing Management Model.
>> - augmentation of the routing policy model
>> - support for RIB
>> 
>> Comments welcome.
>> 
>> > On Feb 26, 2019, at 10:16 AM, internet-drafts@ietf.org <mailto:internet-drafts@ietf.org> wrote:
>> > 
>> > 
>> > A New Internet-Draft is available from the on-line Internet-Drafts directories.
>> > This draft is a work item of the Inter-Domain Routing WG of the IETF.
>> > 
>> >        Title           : BGP YANG Model for Service Provider Networks
>> >        Authors         : Keyur Patel
>> >                          Mahesh Jethanandani
>> >                          Susan Hares
>> >       Filename        : draft-ietf-idr-bgp-model-04.txt
>> >       Pages           : 138
>> >       Date            : 2019-02-26
>> > 
>> > Abstract:
>> >   This document defines a YANG data model for configuring and managing
>> >   BGP, including protocol, policy, and operational aspects based on
>> >   data center, carrier and content provider operational requirements.
>> > 
>> > 
>> > The IETF datatracker status page for this draft is:
>> > https://datatracker.ietf.org/doc/draft-ietf-idr-bgp-model/ <https://datatracker.ietf.org/doc/draft-ietf-idr-bgp-model/>
>> > 
>> > There are also htmlized versions available at:
>> > https://tools.ietf.org/html/draft-ietf-idr-bgp-model-04 <https://tools.ietf.org/html/draft-ietf-idr-bgp-model-04>
>> > https://datatracker.ietf.org/doc/html/draft-ietf-idr-bgp-model-04 <https://datatracker.ietf.org/doc/html/draft-ietf-idr-bgp-model-04>
>> > 
>> > A diff from the previous version is available at:
>> > https://www.ietf.org/rfcdiff?url2=draft-ietf-idr-bgp-model-04 <https://www.ietf.org/rfcdiff?url2=draft-ietf-idr-bgp-model-04>
>> > 
>> > 
>> > Please note that it may take a couple of minutes from the time of submission
>> > until the htmlized version and diff are available at tools.ietf.org <http://tools.ietf.org/>.
>> > 
>> > Internet-Drafts are also available by anonymous FTP at:
>> > ftp://ftp.ietf.org/internet-drafts/ <ftp://ftp.ietf.org/internet-drafts/>
>> > 
>> > _______________________________________________
>> > Idr mailing list
>> > Idr@ietf.org <mailto:Idr@ietf.org>
>> > https://www.ietf.org/mailman/listinfo/idr <https://www.ietf.org/mailman/listinfo/idr>
>> 
>> Mahesh Jethanandani
>> mjethanandani@gmail.com <mailto:mjethanandani@gmail.com>
>> 
>> 
>> 
>> _______________________________________________
>> Idr mailing list
>> Idr@ietf.org <mailto:Idr@ietf.org>
>> https://www.ietf.org/mailman/listinfo/idr <https://www.ietf.org/mailman/listinfo/idr>
> 
> Mahesh Jethanandani
> mjethanandani@gmail.com <mailto:mjethanandani@gmail.com>
> 
> 
> 

Mahesh Jethanandani
mjethanandani@gmail.com