Re: [Idr] Fwd: New Version Notification for draft-spaghetti-idr-bgp-sendholdtimer-05.txt

heasley <heas@shrubbery.net> Wed, 03 August 2022 04:33 UTC

Return-Path: <heas@shrubbery.net>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9A455C13C233 for <idr@ietfa.amsl.com>; Tue, 2 Aug 2022 21:33:02 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.907
X-Spam-Level:
X-Spam-Status: No, score=-1.907 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=unavailable autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FXrBvOBs9sQA for <idr@ietfa.amsl.com>; Tue, 2 Aug 2022 21:33:00 -0700 (PDT)
Received: from sea.shrubbery.net (sea.shrubbery.net [129.250.47.99]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B7C69C13C224 for <idr@ietf.org>; Tue, 2 Aug 2022 21:33:00 -0700 (PDT)
Received: by sea.shrubbery.net (Postfix, from userid 7053) id 40011389D5F; Wed, 3 Aug 2022 04:32:59 +0000 (UTC)
Date: Wed, 03 Aug 2022 04:32:59 +0000
From: heasley <heas@shrubbery.net>
To: Robert Raszuk <robert@raszuk.net>
Cc: Nick Hilliard <nick@foobar.org>, "idr@ietf. org" <idr@ietf.org>, Job Snijders <job=40fastly.com@dmarc.ietf.org>
Message-ID: <Yun6e5jSb0OYZGAX@shrubbery.net>
References: <CAOj+MME7XnW7kDXL4muh4Qp1UvabQ9amUoU0Sn3h2axqKzswzA@mail.gmail.com> <77F3E1F0-486F-47DF-ABE4-EFDB9C2FB6D8@gmail.com> <CAOj+MMGR4f3eLEDZY++1m4Lpo9joG4L9OrWbeF6kREn-9a9onA@mail.gmail.com> <c6e44213-7667-0f67-71a4-634411cd102b@foobar.org> <CAOj+MMFajL6E42WCzC0ZqrfSBZjU-0B=ZzmtvCRPkuMzU8z5QA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <CAOj+MMFajL6E42WCzC0ZqrfSBZjU-0B=ZzmtvCRPkuMzU8z5QA@mail.gmail.com>
X-PGPkey: http://www.shrubbery.net/~heas/public-key.asc
X-note: live free, or die!
X-homer: i just want to have a beer while i am caring.
X-Claimation: an engineer needs a manager like a fish needs a bicycle
X-reality: only YOU can put an end to the embarrassment that is Tom Cruise
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/eHfVtA0KwhwexjyEF3JxGeIlkx4>
Subject: Re: [Idr] Fwd: New Version Notification for draft-spaghetti-idr-bgp-sendholdtimer-05.txt
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Aug 2022 04:33:02 -0000

Sun, Jul 31, 2022 at 11:46:12PM +0200, Robert Raszuk:
> >
> > > If the RCV window is 0 how can TCP send anything to the peer including
> > > TCP RST ?
> >
> > the payload of a rst packet can be zero length. also, psh may be set.
> >
> 
> That does not mean that remote peer with receive it and process it.
> Especially if it is hosed.

Even if the remote (stuck) peer does not process the FIN, the local
end will close the session and stop forwarding traffic that direction.
That is an improvement, from an operator's PoV, both for forwarding
errors and local resources.

> > > If the peer is saturated, how good is it to assign a new IANA
> > > error notification code if it can not be sent to the peer ?
> >
> > same as draft-ietf-idr-bfd-subcode: it's to allow the sending side
> > to log the failure in the bgpPeerLastError oid of the relevant bgp
> > mib, which will be visible to monitoring systems.
> >
> 
> Well it is not about bgp peer's error .. it is about our side not able to
> sent much. so if this is just no keepalives it needs to be lot's of them to
> saturate the socket. Otherwise how would BGP know that its socket to the
> peer does not drain ?

The buffer is not necessarily filled by KAs, it can be NLRI.  Technically,
the window could have closed for any reason the peer wishes and might not
have been caused by bgp itself.  Also, the buffer is not necessarily large
and how long it takes to fill is irrelevant.

A different notification allows the operator to differentiate between causes
of session failure, aiding debugging.