Re: [Idr] RtgDir review: draft-ietf-idr-bgp-ls-flex-algo-05.txt

"Ketan Talaulikar (ketant)" <ketant@cisco.com> Tue, 17 November 2020 03:32 UTC

Return-Path: <ketant@cisco.com>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 72B973A0869; Mon, 16 Nov 2020 19:32:31 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.601
X-Spam-Level:
X-Spam-Status: No, score=-9.601 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=S9sYGkcW; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=pqA8c03T
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DeQ8B0-Y--uK; Mon, 16 Nov 2020 19:32:29 -0800 (PST)
Received: from alln-iport-8.cisco.com (alln-iport-8.cisco.com [173.37.142.95]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DF1923A0858; Mon, 16 Nov 2020 19:32:28 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=3516; q=dns/txt; s=iport; t=1605583949; x=1606793549; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Sg7mq2AK6zWA4Za/idMAAjQ2r8MPEDX2l/3zLZyhI0Y=; b=S9sYGkcW+JwGgI75AiNfuEhKmAt0hcGPcb3UhtHAPoACXvH6BhVHpXd6 dw0URcsF8x0+FYEGys+Vy7IniwD2b2xMMg1y8KAynY7UVgI5BJYQh7Svf Abz3uMG/3LNW/b8S/jTyfgwyHYdSrFWjeSQLkhefu4JBk09ZG+KrzoSjO 4=;
X-IPAS-Result: =?us-ascii?q?A0CbAADOQLNffYgNJK1iHQEBAQEJARIBBQUBQIE8BwELA?= =?us-ascii?q?YFRUXtZLy4KhDKDSQONWooWjm2BLoElA1QLAQEBDQEBHg8CBAEBhEoCF4IJA?= =?us-ascii?q?iU1CA4CAwEBAQMCAwEBAQEFAQEBAgEGBBQBAYY8DIVyAQEBBBIREQwBATcBC?= =?us-ascii?q?wQCAQgRAwEBAQMCJgICAh8RFQgIAgQBDQUIGoMFglUDLgEOowwCgTyIaHaBM?= =?us-ascii?q?oMEAQEFgTMBg1cNC4IQCYEOKgGCcoJmEjxChlcbgUE/gRFDgk8+gVRHNwsCA?= =?us-ascii?q?oFfgxUzgiyQTIMckyyQGy9UCoJtiAyBA4xzhTWDGYEqiGyUSpNSggCIfYJuj?= =?us-ascii?q?jKENgIEAgQFAg4BAQWBVgMzgVlwFYJwAQEyCUcXAg2OH4NxhRSFRHQCNQIGC?= =?us-ascii?q?gEBAwl8jDsBgRABAQ?=
IronPort-PHdr: =?us-ascii?q?9a23=3AnhztaRI49zmeGiACv9mcpTVXNCE6p7X5OBIU4Z?= =?us-ascii?q?M7irVIN76u5InmIFeGvKk/g1rAXIGd4PVB2KLasKHlDGoH55vJ8HUPa4dFWB?= =?us-ascii?q?JNj8IK1xchD8iIBQyeTrbqYiU2Ed4EWApj+He2YkdQEcf6IVbVpy764TsbAB?= =?us-ascii?q?6qMw1zK6z8EZLTiMLi0ee09tXTbgxEiSD7b6l1KUC9rB7asY8dho4xJw=3D=?= =?us-ascii?q?3D?=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-AV: E=Sophos;i="5.77,484,1596499200"; d="scan'208";a="610440094"
Received: from alln-core-3.cisco.com ([173.36.13.136]) by alln-iport-8.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 17 Nov 2020 03:32:25 +0000
Received: from XCH-ALN-001.cisco.com (xch-aln-001.cisco.com [173.36.7.11]) by alln-core-3.cisco.com (8.15.2/8.15.2) with ESMTPS id 0AH3WP20021538 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Tue, 17 Nov 2020 03:32:25 GMT
Received: from xhs-rcd-002.cisco.com (173.37.227.247) by XCH-ALN-001.cisco.com (173.36.7.11) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 16 Nov 2020 21:32:24 -0600
Received: from xhs-aln-001.cisco.com (173.37.135.118) by xhs-rcd-002.cisco.com (173.37.227.247) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 16 Nov 2020 21:32:24 -0600
Received: from NAM12-DM6-obe.outbound.protection.outlook.com (173.37.151.57) by xhs-aln-001.cisco.com (173.37.135.118) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Mon, 16 Nov 2020 21:32:24 -0600
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WLVznfOMf3YOJ4RoSBstb3VuhdrTBkQfI2ramBfmWLHXtzjPXdQ/hHEnwm/X2HDZsqHwxrHVuTiaRBgHgkrk1Jnqw/BLcHWkH9cNdTl/KQfDqaGKuloBHP2WR2cHWtrzPwnZJkBqGiujQ9LlTN8Dv7Ag8yP57AOxvvoSbgawK6fmG+jr6BL0Jz+u9vlLH05qWAQTpLSC9xBMBikiTK6uDi28UfGT6MuIXkVOYa4ElukLHXzAINVQeJjU4imIiCAzbhO3RzM8KXz99onx8EiTkK/PiDz6psfJU3iBCaTxkAiZGOwidj5DtU9+HW3uqYxu7Jt/VhOjHD20o3+24/NUVw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Sg7mq2AK6zWA4Za/idMAAjQ2r8MPEDX2l/3zLZyhI0Y=; b=cm9KWovhevdHh7GUaqQ/eXOZLWEjWURJyeLHI7uLB2F74+6tQmZ/S9FQBk9/XB9YHK24RjZMQRhVYZN4YYDw7AwhPiw5U63Y3b/+WqqLTSSkj3/JVfViUBD3vUTHAT5xkBhcfbg8oFNBN/TzDtMWMmbQajqEBAO85E4FmQHGEHkpGiTzocR6PdCSOaxA35D3Jmu3WhelMcsStMhRUSECTiM0vT4XcQaPCHsOoriDtdAG4qo2o+NnZMevAnbQxZLQkL7BYsQCuicBKjfrBRMpc5aTnEOFJdJ2zMS42yXJR0YHK9xEtHmZqOdvSZxMAzt0yo+jWJYt1SNhqgQD1zz82w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Sg7mq2AK6zWA4Za/idMAAjQ2r8MPEDX2l/3zLZyhI0Y=; b=pqA8c03T42Iq194DFem1neDZnqfB5CNZRyPDKEWhyrZGdZm6sYk4XgxGMI55J+eYC8G/ACbWhXYoRuV+aakUeEkvUqtJR+obHoMPKNJ7+FDYnFlQz2julaokqCi3jYGRdYU7RLT3mEbtlAW4LUna9DssYQhkCw3VVw1JqTgqjWM=
Received: from MW3PR11MB4570.namprd11.prod.outlook.com (2603:10b6:303:5f::22) by CO1PR11MB4962.namprd11.prod.outlook.com (2603:10b6:303:99::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.28; Tue, 17 Nov 2020 03:32:23 +0000
Received: from MW3PR11MB4570.namprd11.prod.outlook.com ([fe80::d4d5:97f0:17b5:2f77]) by MW3PR11MB4570.namprd11.prod.outlook.com ([fe80::d4d5:97f0:17b5:2f77%5]) with mapi id 15.20.3564.028; Tue, 17 Nov 2020 03:32:21 +0000
From: "Ketan Talaulikar (ketant)" <ketant@cisco.com>
To: "Andrew G. Malis" <agmalis@gmail.com>, "<rtg-ads@ietf.org>" <rtg-ads@ietf.org>
CC: Routing Directorate <rtg-dir@ietf.org>, "draft-ietf-idr-bgp-ls-flex-algo.all@ietf.org" <draft-ietf-idr-bgp-ls-flex-algo.all@ietf.org>, "idr@ietf.org" <idr@ietf.org>
Thread-Topic: RtgDir review: draft-ietf-idr-bgp-ls-flex-algo-05.txt
Thread-Index: AQHWvGNtSRXj7hdjo0G93bt3DjjaNanLqstw
Date: Tue, 17 Nov 2020 03:32:21 +0000
Message-ID: <MW3PR11MB4570D4791F9BDBABA612AAA6C1E20@MW3PR11MB4570.namprd11.prod.outlook.com>
References: <CAA=duU3h29Fzdy=nfAwafBc32CA1fjTMU1LO4jBfYdbT59RHNA@mail.gmail.com>
In-Reply-To: <CAA=duU3h29Fzdy=nfAwafBc32CA1fjTMU1LO4jBfYdbT59RHNA@mail.gmail.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=cisco.com;
x-originating-ip: [72.163.220.11]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 0d8a5f2f-bade-470c-27d6-08d88aa964e6
x-ms-traffictypediagnostic: CO1PR11MB4962:
x-microsoft-antispam-prvs: <CO1PR11MB4962B584A8EB3A5C3105CABEC1E20@CO1PR11MB4962.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: n1QvCjtOU8D/6ziUGBH8CxCQSQwc7pCgz1t8RcCBxGTYMirGErPy7RCvmM2CXE9CeToi5z5s9lmMGTgBrrE6hSXNgWB5PkSSpD1KP9vSWwqY5Gg5UQvxewlFRBT7Rp5Vov04h0XnfMfMtrSATJ+0KYMLZJFyj5L0Qat6si+0NgxVnOY7IjhbC3NZRwDomC7OdcVkAB7LAXTJmCOLt8WI8R0799gUiy8+QIhqfNh7KCrGCC3PmUenF/dxrYjWpTfelybhC5FxCakgNsG59AsgE5NULnjjnOV5CgstdKzbgU8InLl5ABegtIJFoPsM7kmLW+aE/+LVdXQsSxawIDLss282X+7p8RbcCg4YLSMGfutExocmq1hyF0uFRdb96vTtNHcSGyK28fMu/a1sR316lZh44sIYPIYptp9S4cbq9SbE/gx9IaEnvudYKU1bJ6Gv
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW3PR11MB4570.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(376002)(396003)(136003)(39860400002)(346002)(366004)(5660300002)(64756008)(66446008)(7696005)(66476007)(186003)(966005)(76116006)(53546011)(66556008)(9686003)(66946007)(6506007)(4326008)(54906003)(110136005)(316002)(55016002)(83380400001)(2906002)(52536014)(86362001)(478600001)(26005)(8936002)(8676002)(33656002)(71200400001)(491001); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata: uCEqKrWSUcrTsEFbRAWIz179NSMeq9cEnwWAQlQvHEZV9QIRV47OOtLJMBExCatZWzCAp6047U0uDVTnABvnsP4KiiKSG3LeAZPI3+3p0aUrv7m5wsWG11oGHMl+41UyJsJhofc37AtOiao1ry1VgdijKGFbNzSiXSH2UslvAS2DdzyH/Pm2SX55Zhq20q0r/Z0B++fPE9/d+z8UOrKCAlApfjRNA331Jl67iJtya0GcR/KRXvT/IS8varEH3tIyuYmt0121oFIxptUOF0BUogaFg/xVtIGgtImnHlUi1j2ADiCqBz2F25xN6xdQ0pQ5iezzj7aOsHfUqOMZONOUDu413RHEXbnuF4iJR9NA2lIi4POg5fiz/eUTZmrEVr8jGqAXr0tkWnCYZXaJEs/7gUnc0AGq24c6Lmm/UEtYo5LvtOfV7gONmYK6a3i9mClpuuhhnfOk0u54rxamzgrAhmDw8ssWQBdNPxlgvcXe2e1su9pCrb4wnKd0X86LBJn6YiQDUgNyH2ngRppPDFOWvlT6NHRY+MbH3HnmC6DsMW2VCpIpOI2/V7qOihdSxDxwEYFJyOySEtVoJyYqg8MXzbfHH44uRAoxGKblqARypaK7Q/pBOGg0oaWun27DYkBZKaruG+wfuxjwoUWVffXMQiya6OzU1heOA6s7U+2HSfZMRhFC3k7lgsKdBOObOAFN571fc6BQmCw/LKioPRUXWGYO0W7lr1lt4jROXP8ULFo3DLXbo1ibaQJnXny/Ut9s2eyL+Rydc3gjNDc+d13KEds4KvfjUfBopo2R+UtqTwUk9XrDgiHTemwCyDjtR158OVA0qLHcWPN7uX8TT2pFumwE7oxz7NZ1dIEuBAt/A3BQQRjTvp5UBy06R27emG3DPa8a65YstXKiu8qT8Z7H6w==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4570.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d8a5f2f-bade-470c-27d6-08d88aa964e6
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Nov 2020 03:32:21.9368 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /DwSzTjUvo8i7yR+4pMeaObcxabP6qsmU6vnR0jU2e0tCm+DoFtDeaWQazJyfa+tVSC8gjbBpbx0DXosSuL/eg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4962
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.36.7.11, xch-aln-001.cisco.com
X-Outbound-Node: alln-core-3.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/gYlPyBKsalEi0ePFrPs-ME4ftKw>
Subject: Re: [Idr] RtgDir review: draft-ietf-idr-bgp-ls-flex-algo-05.txt
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Nov 2020 03:32:32 -0000

Hi Andy,

Thanks for your review.

The authors have already requested the IDR WG chairs for early allocation for the pending codepoints on behalf of the WG [1].

Also, ack on the inclusion of the URL for the IANA registry pointer. Will include that in the next update.

Thanks,
Ketan

[1] https://mailarchive.ietf.org/arch/msg/idr/4JlklIa30OqS5Rw3Z8tf5hXM59A/

-----Original Message-----
From: Andrew G. Malis <agmalis@gmail.com> 
Sent: 17 November 2020 03:27
To: <rtg-ads@ietf.org> <rtg-ads@ietf.org>
Cc: Routing Directorate <rtg-dir@ietf.org>rg>; draft-ietf-idr-bgp-ls-flex-algo.all@ietf.org; idr@ietf.org
Subject: RtgDir review: draft-ietf-idr-bgp-ls-flex-algo-05.txt

Hello,

I have been selected as the Routing Directorate reviewer for this draft.
The Routing Directorate seeks to review all routing or routing-related drafts as they pass through IETF last call and IESG review, and sometimes on special request (in this case, WG last call). The purpose of the review is to provide assistance to the Routing ADs. For more information about the Routing Directorate, please see http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir

Although these comments are primarily for the use of the Routing ADs, it would be helpful if you could consider them along with any other WG Last Call comments that you receive, and strive to resolve them through discussion or by updating the draft.

Document: draft-ietf-idr-bgp-ls-flex-algo-05.txt
Reviewer: Andy Malis
Review Date: Nov. 16, 2020
WG LC End Date: Nov. 23, 2020
Intended Status: Standards Track

Summary:

I have some minor concerns about this document that I think should be resolved before publication.

Overall, the draft is straightforward and easy to follow. In particular, I appreciated the summary of draft-ietf-lsr-flex-algo as a part of the introduction.

Once the comments below have been addressed, it should be ready to be forwarded to the IESG for approval.

Major Issues:

No major issues found.

Minor Issues:

While at least one early implementation has been publicly disclosed, an early IANA allocation is required for the Flex Algorithm Exclude SRLG TLV so that early implementations can interoperate.

It would also be helpful for the reader if Section 5 (IANA Considerations) contained the URL reference to the IANA "BGP-LS Node Descriptor, Link Descriptor, Prefix Descriptor, and Attribute TLVs" registry at https://www.iana.org/assignments/bgp-ls-parameters/bgp-ls-parameters.xhtml#node-descriptor-link-descriptor-prefix-descriptor-attribute-tlv