[Idr] Re: Shepherd draft-zzd-idr-sr-policy-scheduling-04 - I actually reviewed-05

[Susan Hares <[e-mail]>]

Please note that I actually reviewed draft-zzd-idr-sr-policy-scheduling-05.txt

Sue .


From: Susan Hares
Sent: Friday, September 6, 2024 1:04 AM
To: [e-mail]
Cc: Dongjie (Jimmy) <[e-mail]>; Tianran Zhou <[e-mail]>; [e-mail]; [e-mail]
Subject: Shepherd draft-zzd-idr-sr-policy-scheduling-04

Li, Tianran, Jie, Minxue, and Nkosinathi:

Thank you for the interesting work in
draft-zz-idr-sr-policy-scheduling-05

Below I've provided you a short shepherd's review.
Please let me know if you have any questions regarding this draft?

Would you mind answering some questions about this draft:


  1.  Are you planning any technical additions to this draft prior an IDR WG adoption?



  1.  Will you request WG Adoption in the next 3 months?



If you make the changes listed below, this draft

appears to be ready for a WG adoption call.



If you are close to a WG adoption, it might be nice

to review this draft at the September 9, 2024 IDR interim.


  1.  Does this addition apply to all segment types?



  1.  Are you working on an implementation?


Cheerily, Sue



================
Shepherd Review for:
draft-zzd-idr-sr-policy-scheduling-04


status: individual draft
draft-status: Proposed Standard,
version: revision needed (-05)
implementations: unknown
Authors: 5 authors
Summary: Almost ready for WG adoption call


Detailed Shepherd's review,

Issue-1. Abstract, specify SR Policy Candidate Path distribution

Old text:/
   This document proposes extensions to BGP SR Policy to indicate the
   scheduling time of each candidate path(segment list) and its
   associated attributes./

Old text:/

   This document proposes extensions to BGP mechanism to pass
   explicit SR Policy Candidate Paths in order to indicate the
   scheduling time of each candidate path(segment list) and its
   associated attributes./

Issue-2. Section 1, Update to [draft-ietf-idr-sr-policy-safi]

Old text:/
   [I-D.ietf-idr-segment-routing-te-policy] specifies how BGP may be
   used to distribute SR Policy candidate paths.  It introduces a BGP
   SAFI with new NLRI to advertise a candidate path of a Segment Routing
   (SR) Policy./

new text:/
   [I-D.ietf-idr-sr-policy-safi] specifies how BGP may be
   used to distribute explicit SR Policy candidate paths.  It introduces a BGP
   SAFI with new NLRI (SR Policy) and a new tunnel type for the BGP Tunnel
   Encapsulation Attribute (SR Policy) to advertise a candidate path
   of a Segment Routing (SR) Policy./

Old text:/
   In order to solve these problems, this document proposes extensions
   to BGP SR Policy to indicate the scheduling time of each candidate
   path(segment list) and its associated attributes. /

new text:/
   In order to solve these problems, this document proposes extensions
   to BGP SR Policy as defined in [draft-ietf-idr-sr-policy-safi]
   to indicate the scheduling time of each explicit candidate
   path (segment list). /

Issue-3: Section 3, update to latest drafts

replace [draft-ietf-idr-segment-routing-te-policy] to
[draft-ietf-idr-sr-policy-safi].

old text:/
   The NLRI defined in [I-D.ietf-idr-segment-routing-te-policy] contains
   the SR Policy candidate path.  The content of the SR Policy Candidate
   Path is encoded in the Tunnel Encapsulation Attribute defined in
   [RFC9012] using a new Tunnel-Type called SR Policy Type with
   codepoint 15. /

new text:/
The NLRI defined in [I-D.ietf-idr-sr-policy-safi] contains
   the SR Policy candidate for an explicit policy.  The content of the SR Policy Candidate
   Path is encoded in the Tunnel Encapsulation Attribute defined in
   [RFC9012] using a new Tunnel-Type called SR Policy (code point 15)./


Issue-4: Section 3, English text

old text:/ The new SR Policy
   encoding structure is expressed as below:/

new text:/ The new SR Policy TLV structure
   is listed below:/

Issue-5: Section 4.1 and 4.2

Please Give ranges on the definitions.

Here are a few questions that your text should answer:

1) Is group number zero valid? Are there any invalid group numbers?

2) Is index of zero valid?

3) Provide clearer diagram on time block.

[index, reserved] [enable time] [disable time]
are 12 octets of repeating information.

Issue-6: Add information to security section

See [draft-ietf-idr-sr-policy-safi] security section.
What you need to update here is the protection of
the critical information for the Scheduled Time Information
Sub-TLVs you have added.

Issue-7: Please add a manageability section

The movement of traffic between SR Candidate
paths based on time may take different skills
to debug problems in code or configuration.

Please provide a short manageability section.