[Idr] Lars Eggert's No Objection on draft-ietf-idr-bgp-ls-app-specific-attr-11: (with COMMENT)

Lars Eggert via Datatracker <noreply@ietf.org> Wed, 25 May 2022 08:32 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: idr@ietf.org
Delivered-To: idr@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id DD6ABC14F612; Wed, 25 May 2022 01:32:26 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Lars Eggert via Datatracker <noreply@ietf.org>
To: The IESG <iesg@ietf.org>
Cc: draft-ietf-idr-bgp-ls-app-specific-attr@ietf.org, idr-chairs@ietf.org, idr@ietf.org, shares@ndzh.com, keyur@arrcus.com, keyur@arrcus.com
X-Test-IDTracker: no
X-IETF-IDTracker: 8.3.0
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Lars Eggert <lars@eggert.org>
Message-ID: <165346754690.41853.11285876913145591922@ietfa.amsl.com>
Date: Wed, 25 May 2022 01:32:26 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/jGvzUi5k_s459YqWeSKYN7BhP7E>
Subject: [Idr] Lars Eggert's No Objection on draft-ietf-idr-bgp-ls-app-specific-attr-11: (with COMMENT)
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.34
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 25 May 2022 08:32:27 -0000

Lars Eggert has entered the following ballot position for
draft-ietf-idr-bgp-ls-app-specific-attr-11: No Objection

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/ 
for more information about how to handle DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-idr-bgp-ls-app-specific-attr/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

# GEN AD review of draft-ietf-idr-bgp-ls-app-specific-attr-11

CC @larseggert

Thanks to Russ Housley for the General Area Review Team (Gen-ART) review
(https://mailarchive.ietf.org/arch/msg/gen-art/T9RNz1ar99diDYpCMY75m1asL2w).

## Comments

### Section 2, paragraph 5
```
     where:
```
It might be helpful to state the length of the (fixed-length) fields in
the bullet list below, so readers don't have to count bits in Figure 1.

### Inclusive language

Found terminology that should be reviewed for inclusivity; see
https://www.rfc-editor.org/part2/#inclusive_language for background and more
guidance:

 * Term `traditional`; alternatives might be `classic`, `classical`, `common`,
   `conventional`, `customary`, `fixed`, `habitual`, `historic`,
   `long-established`, `popular`, `prescribed`, `regular`, `rooted`,
   `time-honored`, `universal`, `widely used`, `widespread`

## Nits

All comments below are about very minor potential issues that you may choose to
address in some way - or ignore - as you see fit. Some were flagged by
automated tools (via https://github.com/larseggert/ietf-reviewtool), so there
will likely be some false positives. There is no need to let me know what you
did with these suggestions.

### Boilerplate

Document still refers to the "Simplified BSD License", which was corrected in
the TLP on September 21, 2021. It should instead refer to the "Revised BSD
License".

### Grammar/style

#### Section 2, paragraph 14
```
rlying IGPs are also encoded in a similar manner in BGP-LS. The following ta
                             ^^^^^^^^^^^^^^^^^^^
```
Consider replacing this phrase with the adverb "similarly" to avoid wordiness.

## Notes

This review is in the ["IETF Comments" Markdown format][ICMF], You can use the
[`ietf-comments` tool][ICT] to automatically convert this review into
individual GitHub issues. Review generated by the [`ietf-reviewtool`][IRT].

[ICMF]: https://github.com/mnot/ietf-comments/blob/main/format.md
[ICT]: https://github.com/mnot/ietf-comments
[IRT]: https://github.com/larseggert/ietf-reviewtool