[Idr] Secdir last call review of draft-ietf-idr-bgp-extended-messages-35

Rich Salz via Datatracker <noreply@ietf.org> Fri, 02 August 2019 20:19 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: idr@ietf.org
Delivered-To: idr@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 4F15512019B; Fri, 2 Aug 2019 13:19:18 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Rich Salz via Datatracker <noreply@ietf.org>
To: secdir@ietf.org
Cc: idr@ietf.org, draft-ietf-idr-bgp-extended-messages.all@ietf.org, ietf@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.99.1
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Rich Salz <rsalz@akamai.com>
Message-ID: <156477715825.20942.4335500049855564504@ietfa.amsl.com>
Date: Fri, 02 Aug 2019 13:19:18 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/lLsBj3cAQB8JAveaEbRt-62I0mA>
Subject: [Idr] Secdir last call review of draft-ietf-idr-bgp-extended-messages-35
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Aug 2019 20:19:22 -0000

Reviewer: Rich Salz
Review result: Ready

This is the secdir review, intended for the security AD's.  Others should treat
this as normal last-call comments.

This describes a BGP extension code to increase the size of BGP messages. It
nicely explains deployment issues (if a BGP node doesn't understand the
extension), and security issues.

The extension is disallowed for two operations, although only one has a
rationale; it was left to reader to intuit that KEEPALIVE doesn't need the
longer size. I suggest making that explicit.  That is a nit.

Looks good; ship it.