Re: [Idr] Genart last call review of draft-ietf-idr-ext-opt-param-11

John Scudder <jgs@juniper.net> Wed, 21 April 2021 21:24 UTC

Return-Path: <jgs@juniper.net>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A9BBA3A3773; Wed, 21 Apr 2021 14:24:45 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=juniper.net header.b=cR297u8x; dkim=pass (1024-bit key) header.d=juniper.net header.b=B62Z9tHD
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ndtR4Rc5reFD; Wed, 21 Apr 2021 14:24:41 -0700 (PDT)
Received: from mx0b-00273201.pphosted.com (mx0b-00273201.pphosted.com [67.231.152.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D39323A3771; Wed, 21 Apr 2021 14:24:37 -0700 (PDT)
Received: from pps.filterd (m0108161.ppops.net [127.0.0.1]) by mx0b-00273201.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 13LLAi4K000826; Wed, 21 Apr 2021 14:24:33 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=PPS1017; bh=Co8htACWDS3D6dk/my+dI1xPxUDGgMs652dacFNOwrw=; b=cR297u8xTLfXh11sLqKqt9WC/dvkjYhxUii2uy7wT+Ytwb1rXo4QdGFRggg+els14l+5 AMHy+OB3hGNixiz92HGovO8EVDYJRVnL17zhLFyfiMjuW/Kh59h/o8lj4sFYRsrBfaEA v2PLh7MKb1XSiGj7ulLmR1haPHoDFxSSMmkSytxKAcy5ysaAg9MAqidVyIY9f7iDcmLK vmCzbIK7vrSQwheLnfaumcFTeivbb9Fg+Q15ROahQxJ9VoRmY/vp1+oFsdnySpWen1UE J75vZN0he75uCLIqS5zZ68vsVN1x8L9+WlU3TxVsuB6Q0sRjaGlULfcoYGeh1DHf7lrh ag==
Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2100.outbound.protection.outlook.com [104.47.58.100]) by mx0b-00273201.pphosted.com with ESMTP id 382fqrhkag-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 21 Apr 2021 14:24:33 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QvD6fUqIdZvrtN9lYtbRt0jhFnSBtApFw9SMo1UsacPfhPXKPn2CgMmrwIJB69QDiGvrKPzGiYa2R9DTwE9XHWhedlnHcsOc3lK4CJNzJU4eaC1NepPetgyqCiYb4DCMOV7kQuPjyMXd2LiwD8WDrb1bC1Dg/NjPzQ8ydDKgC9u8xg+WPNwIYNJvFcS0lgQh+Wfb2IgH9MjpC95i3WzTDx12pMPSZ0oXh9WSnr7FSniKbZ11DDFfXUUblMOd+/IybAtwVD7PnF+vm0d7/AdXZy0Zsi8aVn/16ssv5eRQtzCQFRYvND7UFfJXu6Xfe1DIwCvBzNGEWiJfOHRgFhF6Ug==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Co8htACWDS3D6dk/my+dI1xPxUDGgMs652dacFNOwrw=; b=HW/kvrFpH+sjbh1WTMAvKPMcWsP/EFp25aucnA0Pi2/FpaTU/3VFDJYOoLhVx91iAQXTHasOGa++3uRoHQHNNfZpfU80WFC7z2KATBRrt3wxvtRp7rqGlVwpzAkzrTrzIfAe8kgWfiky6tpuHUxK6pZhdARKkFvZfPzbo7ulnBuAf5n/vmIYPa94hP7P56Z+/X9C3+DuKwO8dmlLJ+gWJ5rAGPwSPwqj3hBB2Yz0jR6u8FyqyE1dupHFUxH6kjTLz10Azld0RVVqD39HHERsMX8gXvEFKeDPyLUWc77dlobjWYgV0urGUMBE7RY5eBV67UEPU9GmVm0dHTrk10pCqw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=juniper.net; dmarc=pass action=none header.from=juniper.net; dkim=pass header.d=juniper.net; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Co8htACWDS3D6dk/my+dI1xPxUDGgMs652dacFNOwrw=; b=B62Z9tHDZif6inT0DBLFKYFLM10KD5y2g1ZP1IVY3JY1FIJWpjvj2ES0eu+t+FzGRm6NLxkBh030qNTGM1mky46QsL/l+XyfrFeBiYk8Px14KmUE4gWs2PKOYg7tAtz673Cap/7OwNyNHcpynXkUPTdq9PD5OcTEdgPJp+MOQQ0=
Received: from BN8PR05MB6098.namprd05.prod.outlook.com (2603:10b6:408:45::29) by BN7PR05MB4210.namprd05.prod.outlook.com (2603:10b6:406:89::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.12; Wed, 21 Apr 2021 21:24:30 +0000
Received: from BN8PR05MB6098.namprd05.prod.outlook.com ([fe80::4d47:2d3c:d3c5:2e14]) by BN8PR05MB6098.namprd05.prod.outlook.com ([fe80::4d47:2d3c:d3c5:2e14%3]) with mapi id 15.20.4065.021; Wed, 21 Apr 2021 21:24:30 +0000
From: John Scudder <jgs@juniper.net>
To: Christer Holmberg <christer.holmberg@ericsson.com>
CC: "gen-art@ietf.org" <gen-art@ietf.org>, "draft-ietf-idr-ext-opt-param.all@ietf.org" <draft-ietf-idr-ext-opt-param.all@ietf.org>, "idr@ietf.org" <idr@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>
Thread-Topic: Genart last call review of draft-ietf-idr-ext-opt-param-11
Thread-Index: AQHXMi5QFpts+gbOQkiHOsnqDY8cbqq/hREA
Date: Wed, 21 Apr 2021 21:24:30 +0000
Message-ID: <E9D6193D-2485-498F-8D1C-42F207724CD2@juniper.net>
References: <161851524693.27672.11525659031465457077@ietfa.amsl.com>
In-Reply-To: <161851524693.27672.11525659031465457077@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3608.120.23.2.4)
authentication-results: ericsson.com; dkim=none (message not signed) header.d=none;ericsson.com; dmarc=none action=none header.from=juniper.net;
x-originating-ip: [163.116.133.117]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 3bbce6a8-d841-4b2c-f382-08d9050bd9cb
x-ms-traffictypediagnostic: BN7PR05MB4210:
x-microsoft-antispam-prvs: <BN7PR05MB42108318F8198083710B0C2AAA479@BN7PR05MB4210.namprd05.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: y9FFmc64kV2oyn7Ww36l4a/Gqo5SqoaOVg7B9mqANmFcKrMlWfv4vgQEwqAeAx2k4PCUl/fhhp/ogkUrczX8E8h9B0zX+mfzybXh4Ksn7nKSabOyknQoxgsxx0q6ftrs5oDynjea26i1w9IxJyMd0YwArDlRDChvNeaO21X5mXFuiXXmvek5h2w362hTQfxKy4hrhAnR3ZIRdeVldZ4nhaa7UlDiiUd2crN/lB6Lg1WZfBNSBEWc1FgI179MS+HMbdCbVVCVA2KaDVicPzNCJPkOEkDzlrldVCv+OCxcGvhohKo2SzhwrEK5h1UeilKKbM9gINpwMXUmEb0jOc9TC65mgoUXRt1sFoJ4fvdKLjtT5krRdnN5VvUjuNjkot2cCGn6yqUch5TYDwLMQWvuMvFyq4QF5F8D36CGmz0TGu8zkDLFm73yCIiIOkmnvAiGlK7bUmEsxT9W9rTO22IuUyEuoh2p94kDUdI/5KAhibejNKkVTBRiEtqZHtUVNl7OZHk04Qq0vOwErGRc4BMtfP24y0bfzLnKvA3vOiEeSgwcXulCzVIfzyS8zFfBR4vp9HQzYRv3FXGnnQomgC5Z+aFIUiDm5JwDBBAHndNFlMZeNjVmDbZ0AFhzB9sEPxWQCdxLsSrbqtLUfIglfAEyFcG4j2xReCVtnPNtV83uyu045YtobQhOO5Gg4gOjfkjI/70J7MZj2FrCJ8wns2MV1fZuRsDgS6iaRoPG8AzrB5lJ041CJDOnGggdvFYB8Jw1
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR05MB6098.namprd05.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(136003)(39860400002)(396003)(346002)(366004)(122000001)(66476007)(186003)(66446008)(76116006)(26005)(64756008)(6486002)(8936002)(91956017)(66946007)(38100700002)(83380400001)(54906003)(5660300002)(33656002)(66556008)(316002)(66574015)(8676002)(478600001)(71200400001)(4326008)(6916009)(2616005)(86362001)(2906002)(6506007)(6512007)(53546011)(36756003)(45980500001); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata: =?utf-8?B?Y1dGOElZQVZXVERwcVlXVi8zMVZDb2hueDQ4VUVGUGloTjl0UmtuLzIrSGVj?= =?utf-8?B?MHg5U3M4VXJxc0ZQVkNWeEl3UGZuNmFMZVJSdXpRSUxWWDEyUzdTK3BDM1dz?= =?utf-8?B?TVQyUjQyNFFtbit3Z2xxS2ZzcUVFZ2RXalRiZkg5cldoYXpnYXBCYkRPTnhu?= =?utf-8?B?SWNMUWJEb2lURkF3ekwra1p1MCtYaUFHLzNpaG1NMmJlMHFPZ1FtelJCM2Nv?= =?utf-8?B?QUhpci9LMzBKc1RCZUtMYkFvUGxBYW1NSk8vU0llTkh6aVBTclErV2NNbUN4?= =?utf-8?B?UVJ1Q1BxRGtKY3NXd2xPNDhXNnlDODY4Y3NPY3V6MFVIRmlaWjh6LzQ4dkl0?= =?utf-8?B?QzNLUjBOenhpdC8rck9SUkZoYzcyUVkrTmF4N0htR2d2bDFIQUVlUlNSSE1C?= =?utf-8?B?YVd3cVdiTFZybnRBNXNmTzJaRndoaGQ2YmlBdzREaG1rZ1dNOFZPSXVZL3RB?= =?utf-8?B?Uk9abnM3MmpmQjUySDl4QmhFOWpJcjBQSDFtcVhPZmFRNjVVZTlCYWdSZVM5?= =?utf-8?B?VlhuZm40KzkxTE1HRWM2WnNsM3c5a0ZacWMwSVlhd1grQ3VlWDJkTmtWK3Y5?= =?utf-8?B?UjBIak03RGxLekszZjBJREtDU3pLTW9KWTBCaDZESldSZnFCbklvWHkvRnA4?= =?utf-8?B?YVlMNm9ZbVZLTXo1SDVQMjNudGVLdVVQQUJhVERoQ2lPWjFhaWswdmUxazhz?= =?utf-8?B?RC9MOXJ6aHFrL0FhOEFQczdYamlzcmlVdEk4cnZpMDVxaXJCSm9yNFY2L0lv?= =?utf-8?B?R2NsZWxxYTBxN0JKTFE3SmlnamcvdlpNVlQrR1piRGxDNWVWcyt3U1h4cXRJ?= =?utf-8?B?UDlKb1ZWbW1nQ3p4NFZGZDA1Q1pEVzYvQll6QUpLZEhPNWdFSU9MQVA4Syty?= =?utf-8?B?Ni9yZW54UW9VT3VKOUZaUnIvRHdMQm5WcVBqK24rNkM5dzhMK0ZXcXFFOGhE?= =?utf-8?B?V0YrSDl1RlhXUVV4VFdYaUo4ZUQzeDNHUDJrM2t6eE9ITEdwUHc5Vi8yMXN6?= =?utf-8?B?OWZUeTFGUE5CVmNrTGp0UVprYTRFMG9PRzJMNExtck8yWVZsVllzWE1zSTI1?= =?utf-8?B?VWI4YlF1RmxEZXY3SkJueG55VWN2d3hZYUw3QXhBTjF2MHhZbHYyL1hDZkx6?= =?utf-8?B?Y2dkaTNQcUZsTDFEUnBPT2ZBdDBrTVV0UFBjVnpDOWNWaEtodHhuTTkzanJ5?= =?utf-8?B?RHpqTno4ektSdUFxZ09ZYmpxWGVvdmJyOGhkckpuLzJreXNaSzBZUnNWMWhy?= =?utf-8?B?QzMvLzNkR3NSRmdUcDlzdW1uQWlFVlh3dHpCL2tuQ1MyT09CNzFjZ2FLRkl6?= =?utf-8?B?RnVYVUpjdkVZU0cyTzZqTllHNXc0UDd5dGwwMFRuOXJHSjhNZHhYSmxyV01a?= =?utf-8?B?aXdZa28vU2Iwek9FMXpUbDUvNzhtQnp0RlRHRkRrbE1jSnh1MmpMSnZ5dTRP?= =?utf-8?B?aVk0bkpwTWpVdjYvaTNIaE5uMzFLd050QXpMNklGblNaUkpvWFA2SmwvdkJL?= =?utf-8?B?T2svb1V0WUNFTXVlQ0ZuZWMxWHZhUEZTcXNxRVA1OUhveElkVGwrdjJLNHU0?= =?utf-8?B?N2NFOEVCVVkxc0xoMmFNL05EMHNGK1JJNUF5c3plWHVFQ0VocXBSR1U1YlIv?= =?utf-8?B?QllubExBY3orTDU5UytvcUN1eTVUTlBCek54ajB1MERnbGhSemZGeEdVQkY5?= =?utf-8?B?dmdTeUQrRHNyVGVNUzNQdEttRWUvQi8xQXJ3NVRSNUxEb3gxeXVaeWxFL1VZ?= =?utf-8?B?SlFiRlJFVVJhZ2JnMk9zRGZVbEp2aW1ZU2t5Rzh3NzhkUm1hNHJyYWpNWEl6?= =?utf-8?B?amhCNER5WWw5REZ3VmpmZz09?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <5E8C121A5D5BFE42A275AE3457AA4FB5@namprd05.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: juniper.net
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN8PR05MB6098.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3bbce6a8-d841-4b2c-f382-08d9050bd9cb
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2021 21:24:30.5187 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: bea78b3c-4cdb-4130-854a-1d193232e5f4
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6h9X+XAp8w/7OQvsKWPipkXFRZmILfYoxb3zIGYv/4f18Tg2ZNrIi9s5vMmeZNPH
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR05MB4210
X-Proofpoint-ORIG-GUID: jtjY1CkTRAEa9tNIY8PiyETwD2tKkgfD
X-Proofpoint-GUID: jtjY1CkTRAEa9tNIY8PiyETwD2tKkgfD
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-04-21_06:2021-04-21, 2021-04-21 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 priorityscore=1501 suspectscore=0 adultscore=0 mlxlogscore=999 impostorscore=0 malwarescore=0 phishscore=0 mlxscore=0 bulkscore=0 clxscore=1011 spamscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2104210142
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/p5yEBwmVktso-KaMW2GGR7HBM7M>
Subject: Re: [Idr] Genart last call review of draft-ietf-idr-ext-opt-param-11
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Apr 2021 21:24:46 -0000

Hi Christer,

Thanks for your review.

> On Apr 15, 2021, at 3:34 PM, Christer Holmberg via Datatracker <noreply@ietf.org> wrote:
> 
> [External Email. Be cautious of content]
> 
> 
> Reviewer: Christer Holmberg
> Review result: Almost Ready
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://urldefense.com/v3/__https://trac.ietf.org/trac/gen/wiki/GenArtfaq__;!!NEt6yMaO-gk!SpXM0yYhkqFsTZDByFUPco5EutovKUYeL5VoR2Wb7DUHLrZxG7pdNLoL2KrhyA$ >.
> 
> Document: draft-ietf-idr-ext-opt-param-11
> Reviewer: Christer Holmberg
> Review Date: 2021-04-15
> IETF LC End Date: 2021-04-09
> IESG Telechat date: 2021-04-22
> 
> Summary: The document is easy to read, and I have no technical issues. However,
> I do have a minor question, and a couple of editorial suggestions, that I'd
> like the authors to address.
> 
> Major issues: N/A
> 
> Minor issues:
> 
> Q1: As far as I understand, the document only defines a new BGP OPEN Optional
> Parameter Type, but does not modify/add procedures in RFC 4271. So, is the
> document really an update to RFC 4271? And, when reading RFC 5429, I cannot
> find any text saying that new parameter types would require an update to RFC
> 4271. I also looked at a few other RFCs that add new values to the BGP IANA
> registry, and they were not updating any RFC.

The document modifies the way a router parses the OPEN. It doesn’t just add a new type, indeed the new type is only added as a special token to tell the router to use the new procedures.

> Nits/editorial comments:
> 
> Q2: I suggest that Section 2 is renamed to  "New Optional Parameter Type code",
> or something like that. OR, if the document really is updating RFC 4271,
> perhaps "Update to RFC 4271".

I’ve adopted your second suggestion.

> Q3: I suggest that Section 3 is renamed to "Backward Compatibility", or
> something like that.

Done.

—John