Re: [Idr] Genart last call review of draft-ietf-idr-ext-opt-param-11

John Scudder <jgs@juniper.net> Wed, 21 April 2021 21:24 UTC

From: John Scudder <jgs@juniper.net>
To: Christer Holmberg <christer.holmberg@ericsson.com>
CC: "gen-art@ietf.org" <gen-art@ietf.org>, "draft-ietf-idr-ext-opt-param.all@ietf.org" <draft-ietf-idr-ext-opt-param.all@ietf.org>, "idr@ietf.org" <idr@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>
Thread-Topic: Genart last call review of draft-ietf-idr-ext-opt-param-11
Thread-Index: AQHXMi5QFpts+gbOQkiHOsnqDY8cbqq/hREA
Date: Wed, 21 Apr 2021 21:24:30 +0000
Message-ID: <E9D6193D-2485-498F-8D1C-42F207724CD2@juniper.net>
References: <161851524693.27672.11525659031465457077@ietfa.amsl.com>
In-Reply-To: <161851524693.27672.11525659031465457077@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
Content-ID: <5E8C121A5D5BFE42A275AE3457AA4FB5@namprd05.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 3bbce6a8-d841-4b2c-f382-08d9050bd9cb
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2021 21:24:30.5187 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: bea78b3c-4cdb-4130-854a-1d193232e5f4
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6h9X+XAp8w/7OQvsKWPipkXFRZmILfYoxb3zIGYv/4f18Tg2ZNrIi9s5vMmeZNPH
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR05MB4210
X-Proofpoint-ORIG-GUID: jtjY1CkTRAEa9tNIY8PiyETwD2tKkgfD
X-Proofpoint-GUID: jtjY1CkTRAEa9tNIY8PiyETwD2tKkgfD
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-04-21_06:2021-04-21, 2021-04-21 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 priorityscore=1501 suspectscore=0 adultscore=0 mlxlogscore=999 impostorscore=0 malwarescore=0 phishscore=0 mlxscore=0 bulkscore=0 clxscore=1011 spamscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2104210142
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/p5yEBwmVktso-KaMW2GGR7HBM7M>
Subject: Re: [Idr] Genart last call review of draft-ietf-idr-ext-opt-param-11
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Apr 2021 21:24:46 -0000

Hi Christer,

Thanks for your review.

> On Apr 15, 2021, at 3:34 PM, Christer Holmberg via Datatracker <noreply@ietf.org> wrote:
> 
> [External Email. Be cautious of content]
> 
> 
> Reviewer: Christer Holmberg
> Review result: Almost Ready
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://urldefense.com/v3/__https://trac.ietf.org/trac/gen/wiki/GenArtfaq__;!!NEt6yMaO-gk!SpXM0yYhkqFsTZDByFUPco5EutovKUYeL5VoR2Wb7DUHLrZxG7pdNLoL2KrhyA$ >.
> 
> Document: draft-ietf-idr-ext-opt-param-11
> Reviewer: Christer Holmberg
> Review Date: 2021-04-15
> IETF LC End Date: 2021-04-09
> IESG Telechat date: 2021-04-22
> 
> Summary: The document is easy to read, and I have no technical issues. However,
> I do have a minor question, and a couple of editorial suggestions, that I'd
> like the authors to address.
> 
> Major issues: N/A
> 
> Minor issues:
> 
> Q1: As far as I understand, the document only defines a new BGP OPEN Optional
> Parameter Type, but does not modify/add procedures in RFC 4271. So, is the
> document really an update to RFC 4271? And, when reading RFC 5429, I cannot
> find any text saying that new parameter types would require an update to RFC
> 4271. I also looked at a few other RFCs that add new values to the BGP IANA
> registry, and they were not updating any RFC.

The document modifies the way a router parses the OPEN. It doesn’t just add a new type, indeed the new type is only added as a special token to tell the router to use the new procedures.

> Nits/editorial comments:
> 
> Q2: I suggest that Section 2 is renamed to  "New Optional Parameter Type code",
> or something like that. OR, if the document really is updating RFC 4271,
> perhaps "Update to RFC 4271".

I’ve adopted your second suggestion.

> Q3: I suggest that Section 3 is renamed to "Backward Compatibility", or
> something like that.

Done.

—John

[Idr] Genart last call review of draft-ietf-idr-e… Christer Holmberg via Datatracker
Re: [Idr] Genart last call review of draft-ietf-i… John Scudder
Re: [Idr] [Gen-art] Genart last call review of dr… Lars Eggert
Re: [Idr] Genart last call review of draft-ietf-i… Christer Holmberg
Re: [Idr] [Last-Call] Genart last call review of … John Scudder
Re: [Idr] [Last-Call] Genart last call review of … Christer Holmberg