Re: [Idr] Éric Vyncke's Discuss on draft-ietf-idr-flow-spec-v6-19: (with DISCUSS and COMMENT)

Robert Raszuk <robert@raszuk.net> Wed, 04 November 2020 20:22 UTC

Return-Path: <robert@raszuk.net>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2C7BF3A07E6 for <idr@ietfa.amsl.com>; Wed, 4 Nov 2020 12:22:11 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.098
X-Spam-Level:
X-Spam-Status: No, score=-2.098 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=raszuk.net
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id It00hw6laxDf for <idr@ietfa.amsl.com>; Wed, 4 Nov 2020 12:22:09 -0800 (PST)
Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 178D13A0CE7 for <idr@ietf.org>; Wed, 4 Nov 2020 12:22:09 -0800 (PST)
Received: by mail-lj1-x232.google.com with SMTP id 23so24338535ljv.7 for <idr@ietf.org>; Wed, 04 Nov 2020 12:22:08 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raszuk.net; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aC1qKs+/eYjpBkTyDDyTmGivV+RVihb+Mlp9wUOJog8=; b=dKXi5NgGzxr3CeeDJwulbojBow1jv0uW+SsA4cm69C7suqJUKPgyjMJkslNbB2Q2lO Wir5C+IilkQPQVF5K751G9Q8RRbojkdnVPJ57l/zn5yubquoSa+T6jFz7vcgDN4s9i/i xLOXlje7Ox9yMX+2dssC5sZFc7rPyzG88ERk00p6S+3Ta6ZhBan17b4wUr3V6ScfEGLu USlOCgwC0x+qaswJ6JgUseIyzmoQOL5iS0HrysS+8qCS+TmHCIqKV6jJf8yLA1yKG+sg 3YvZ9FIQWTQkIgUU3HMuCLK3kZyAjAWLV995uwNNr7hYLqx53JpMQD73ggzEKL81ivye 9WYA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aC1qKs+/eYjpBkTyDDyTmGivV+RVihb+Mlp9wUOJog8=; b=mGWx0bWERcVlCIvFfALIGVFRQtk+daGh738xdOPiaTJkbquQoHcZiPu2AqgyOoHiIr 15x6HZz8VFPBu+7Q1FQax8azPJIlad00LAy85INQeS++aT7BR2zz7FIEM59D5sNYU4UB 0113gynHpSJOpOD2jsmnWEZzldd2Q4QeE5LcE/ShtQ2lXs+cLB0CEn5P/BTzcqqH7u4s P9KBYmIxKeYiCv9h4wmwHmJY1V5SlOkXcl5fHLr36/N0el1smFKEBWd7Ae+aFUBM9/e9 SBAiYwQqTYy1Xf/nPD4l1ebuim6axy7SuEyRJuWz1/YTwqPso0J9k3YdNOqyvsATiOVm hLKw==
X-Gm-Message-State: AOAM5319HcnSwhZ7RnT9O800qS5LpOC5zZzbZP66Vqy9x8EbNZwH+IIg gq++ThMU0y/B2Xbozy5BnQWc2qIz4L1QgZ2S5VzbIQ==
X-Google-Smtp-Source: ABdhPJxAJ9p8ZTJqCKa4fTVpZCMPvZUxCe305+DR70q3XEWYodo4CiOzKlrLaQbDeIL2usV8GJDm8z43GVKVQk8fmmE=
X-Received: by 2002:a2e:b8c7:: with SMTP id s7mr10475853ljp.374.1604521327253; Wed, 04 Nov 2020 12:22:07 -0800 (PST)
MIME-Version: 1.0
References: <160447530519.19838.7495034603697648657@ietfa.amsl.com>
In-Reply-To: <160447530519.19838.7495034603697648657@ietfa.amsl.com>
From: Robert Raszuk <robert@raszuk.net>
Date: Wed, 04 Nov 2020 21:21:58 +0100
Message-ID: <CAOj+MMHzCcMKi38=+M=cPzo2keCkyps38H6+fxTYLWxtHcZu+g@mail.gmail.com>
To: Éric Vyncke <evyncke@cisco.com>
Cc: The IESG <iesg@ietf.org>, draft-ietf-idr-flow-spec-v6@ietf.org, idr-chairs@ietf.org, "idr@ietf. org" <idr@ietf.org>, Jie Dong <jie.dong@huawei.com>, Alvaro Retana <aretana.ietf@gmail.com>
Content-Type: multipart/alternative; boundary="000000000000bef7d005b34dbbd2"
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/rPhhcD_3lmaICp9aNFfecWIIDKo>
Subject: Re: [Idr] Éric Vyncke's Discuss on draft-ietf-idr-flow-spec-v6-19: (with DISCUSS and COMMENT)
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Nov 2020 20:22:11 -0000

Hi Eric,

> Why was this not considered by the authors ? Or is there another document
in the WG to address this issue ?

Actually it was considered :) I wrote the first version of this draft and
after discussion with co-authors and industry peers we decided to make any
extension header extensions for flow-spec to be out of scope of the base
document.

The main reason was (and I believe still is) fact that extensions headers
are work in progress and the number of extension headers are being defined.

So while it is clearly valid to have this Next Header check we were for now
trying to focus on base IPv6 header to provide analogy to IPv4 header
functionality.

If you think this is a show stopper I guess we would need to go back to the
drawing board and halt all progress made with this document that far.

Many thx,
R.

On Wed, Nov 4, 2020 at 8:35 AM Éric Vyncke via Datatracker <noreply@ietf.org>
wrote:

> Éric Vyncke has entered the following ballot position for
> draft-ietf-idr-flow-spec-v6-19: Discuss
>
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
>
>
> Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
> for more information about IESG DISCUSS and COMMENT positions.
>
>
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-idr-flow-spec-v6/
>
>
>
> ----------------------------------------------------------------------
> DISCUSS:
> ----------------------------------------------------------------------
>
> Thank you for the work put into this document. It is indeed due time to
> filter
> also those IPv6 packets ;-)
>
> Please find below one blocking DISCUSS point, some non-blocking COMMENT
> points,
> and some nits.
>
> I hope that this helps to improve the document,
>
> Regards,
>
> -éric
>
> == DISCUSS ==
>
> I am puzzled by the absence of a flow spec for the first Next-Header being
> a
> specific value and by the absence of a flowspec for the occurence of any
> extension header in the extension header chain. Extension headers are an
> important difference compared to IPv4 and could be 'nasty' as well (e.g.,
> hop-by-hop header). Why was this not considered by the authors ? Or is
> there
> another document in the WG to address this issue ?
>
>
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
>
> == COMMENTS ==
>
> -- Section 3.1 --
> Smart idea to have an offset but I wonder whether "Offset < Length < 129"
> is
> true... Esp. with some IPv6 addresses with an embedded IPv4 address (32
> bit) at
> offset 96. Isn't "Offset + Length <= 128" better ?
>
> -- Section 3.3 --
> How is the upper-layer defined here? Basically, how a node can determine
> whether it is an extension header or an upper-layer header? While I agree
> that
> there are not too many new upper-layer protocols being specified, I would
> prefer to have a definition of "upper-layer" here either by listing (or
> referring to a IANA registry) all existing extension headers (then all
> 'next
> header' not being 'extension header' are by default 'upper layer') or
> vice-versa.
>
> -- Section 3.6 --
> Just curious ;-) Why is bit 7 not used in this encoding ?
>
> -- Section 3.7 --
> I share Ben Kaduk's concern about the encoding of the flow label in less
> than
> 20 bits.
>
> == NITS ==
>
> -- Section 3.1 (and possibly others) --
> Sometimes the field 'length' is all lower case and sometimes it is
> capitalized.
>
> -- Section 3.8.2 (and possibly others) --
> Please use RFC 5952 to write IPv6 addresses.
>
>
>
>