Re: [Idr] AD Review of draft-ietf-idr-bgp-flowspec-oid-12

Alvaro Retana <aretana.ietf@gmail.com> Fri, 30 April 2021 19:56 UTC

Return-Path: <aretana.ietf@gmail.com>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 32C573A24E4; Fri, 30 Apr 2021 12:56:02 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o6-MKDlI2fUM; Fri, 30 Apr 2021 12:55:59 -0700 (PDT)
Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9EC553A24E3; Fri, 30 Apr 2021 12:55:59 -0700 (PDT)
Received: by mail-ed1-x533.google.com with SMTP id q6so24697680edr.3; Fri, 30 Apr 2021 12:55:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :cc:content-transfer-encoding; bh=Ikase94vVHnKzewp6UQZ2J+uI3AAeqQ7j9wrw7u3F8Y=; b=K9Yj4Qs1P1UBOn81d6Rkb/klyyiJOHTB1KjUUM58UwH5kUoAd+qRKWDwymGXw24x++ 7Dfz/7H5EpLtUxl9hHiS3BlYoaKglIrteZgNuP7APjHRvARPNZps+SGjDVX79gHFGSlm SS1zm98AVXS5DbU4OHEnp8ydHGYSk75i4Vn/3Ug/lv99X282zdUSQzLx8meYldbG5nWm 8/KIDwQZ/hjIg9XtiJENHIb9i7/C2ddOfGypvdrucNWBrUtUsOFfaq1X6cRKnodD5VXQ jx+sQFzDw0kQUZ1DfBbPIrnctBDK+DKssgiNCZrPCaBqKWIjnyzWLgwJHHMwttnyDl+x qrVQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc:content-transfer-encoding; bh=Ikase94vVHnKzewp6UQZ2J+uI3AAeqQ7j9wrw7u3F8Y=; b=ZM2tpRJjqN6MctYxh+pBgkNnJeTTqjR9KrItPEve+MHzFbAv13XCyTQ2fL+wLyMO2I GuoMN3Kpeq+PQf+0a+9mTr/epFRpotXHdPbUX1FEjbkR9uSjC9kmKJ27CjWVn8HVxh87 wGQ/UvUsQkgMCoa7/Lx9UEWsmdA7/h+YARaiveznBQsFzSxoYYsul7wKh2Ws4mx2Sjg/ ezTM+QzsB8xn/koZ3JbqptgQHlgbopCGG/U+Np2ttFBlSMmjI2C2MmdDEVXQ/Vw0x+jT 99IVh3Zz1auQs+5rlRAPRZMiMuen+w89fBYu3qN4qIen/3reMC+qsxOz2Fg16VAJAm5H j8DQ==
X-Gm-Message-State: AOAM532Lol7a2F7t93olcb5dLR9RiUOFnUPuS55txXFZo2WSvnc1TN7M H/rowItKm8FGNmlQkk77B2sxyJDtRTLWembw6mA=
X-Google-Smtp-Source: ABdhPJz0A/4/I4BWxR2gnGDtwKcVuaFT9IUQm5jyJRmSwJWVt3tLbNEK/yCVOSMyoYrbyd6TvToYeao1Edvxdw+KZAQ=
X-Received: by 2002:aa7:dbd3:: with SMTP id v19mr7957880edt.314.1619812556210; Fri, 30 Apr 2021 12:55:56 -0700 (PDT)
Received: from 1058052472880 named unknown by gmailapi.google.com with HTTPREST; Fri, 30 Apr 2021 12:55:55 -0700
From: Alvaro Retana <aretana.ietf@gmail.com>
In-Reply-To: <DM6PR11MB319466B7490F9E5BBFF7C0AECD5E9@DM6PR11MB3194.namprd11.prod.outlook.com>
References: <CAMMESsxqRWK2vDPyj-0_ruYoW7pkautFc09MoFBUTKxG23=tyA@mail.gmail.com> <000701d6f57c$6c20ff60$4462fe20$@ndzh.com> <DM6PR11MB319495819681585AA858E54BCDB29@DM6PR11MB3194.namprd11.prod.outlook.com> <CAMMESswvncvo68dYp95P+9gkgKgPpmgY3Yr-xC3=hdt-1YigYQ@mail.gmail.com> <SN6PR11MB320012D1B66CF35D18DCB212CD9F9@SN6PR11MB3200.namprd11.prod.outlook.com> <CAMMESszDCb70G6YbdpiAnv0mYEC52=abh89QW7cXaEdfgVzOxw@mail.gmail.com> <EBC0EE4B-063B-44A4-A74B-FCAE6EDBA511@cisco.com> <00f001d71500$db52a9d0$91f7fd70$@ndzh.com> <DM6PR11MB3194DEF968FD730D08FFFFBACD759@DM6PR11MB3194.namprd11.prod.outlook.com> <CAMMESsxjUetknSv=Q+PHxzQfx8VqgtGitr3jW84bJuZD41puOQ@mail.gmail.com> <DM6PR11MB3194CAFF7F6373A8B193D1A2CD709@DM6PR11MB3194.namprd11.prod.outlook.com> <CAMMESsxhx87=zz6jTni52814wnEnhaH6VapeRG9Z7Km66jnC=A@mail.gmail.com> <DM6PR11MB319466B7490F9E5BBFF7C0AECD5E9@DM6PR11MB3194.namprd11.prod.outlook.com>
MIME-Version: 1.0
Date: Fri, 30 Apr 2021 12:55:55 -0700
Message-ID: <CAMMESsw1Yz+MxEjiYW2E=VzwLYZ-PU+-Pd_cE_Wp8j1+tqTOtw@mail.gmail.com>
To: "Juan Alcaide (jalcaide)" <jalcaide@cisco.com>
Cc: Susan Hares <shares@ndzh.com>, James Uttaro <ju1738@att.com>, "idr-chairs@ietf.org" <idr-chairs@ietf.org>, IDR List <idr@ietf.org>, "David Smith (djsmith)" <djsmith@cisco.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/smnJXU0SHnsaPE-INGJEZlUZcas>
Subject: Re: [Idr] AD Review of draft-ietf-idr-bgp-flowspec-oid-12
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Apr 2021 19:56:02 -0000

On April 30, 2021 at 2:33:19 PM, Juan Alcaide wrote:


Juan:


Hi!

Just one point:

...
> --> I originally added AS_CONFED_SET because the
> [I-D.ietf-idr-deprecate-as-set-confed-set] is not an RFC yet. But I'll gladly
> remove AS_CONFED_SET reference for clarity if that's ok.
> And just add a note in case it's not deprecated yet. Only concern is that it
> was (could have been) mentioned in both sections 4.1 and 5. So I thought
> perhaps the best place to add the note would be at the end of the
> introduction. My proposal:
>
>
> Throughout this document, some references are made to
> AS_CONFED_SEQUENCE AS_PATH segments. If AS_CONFED_SET ASPATH
> segments are supported, same considerations MUST apply to them.
> Note, however, that AS_CONFED_SET segments are expected to be
> deprecated per [I-D.ietf-idr-deprecate-as-set-confed-set], and thus
> support for them will soon not be required.

Suggestion:

   Throughout this document, some references are made to AS_CONFED_SEQUENCE
   segments; see Sections 4.1 and 5.  If AS_CONFED_SET segments are also
   present in the AS_PATH, the same considerations apply to them.  Note,
   however, that the use of AS_CONFED_SET segments is not recommended
   [RFC6472].  Refer to [I-D.ietf-idr-deprecate-as-set-confed-set] as well.

Both references should be Informative.


Thanks!

Alvaro.