[Idr] RtgDir review: draft-ietf-idr-shutdown-05

Lou Berger <lberger@labn.net> Fri, 10 February 2017 01:01 UTC

Return-Path: <lberger@labn.net>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4347E129E02 for <idr@ietfa.amsl.com>; Thu, 9 Feb 2017 17:01:34 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.388
X-Spam-Level:
X-Spam-Status: No, score=-3.388 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1.887, RCVD_IN_SORBS_SPAM=0.5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (768-bit key) header.d=labn.net
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oezV5nrz7hEU for <idr@ietfa.amsl.com>; Thu, 9 Feb 2017 17:01:26 -0800 (PST)
Received: from gproxy5-pub.mail.unifiedlayer.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by ietfa.amsl.com (Postfix) with SMTP id 93461129DFB for <idr@ietf.org>; Thu, 9 Feb 2017 17:01:26 -0800 (PST)
Received: (qmail 31192 invoked by uid 0); 10 Feb 2017 01:01:24 -0000
Received: from unknown (HELO CMOut01) (10.0.90.82) by gproxy5.mail.unifiedlayer.com with SMTP; 10 Feb 2017 01:01:24 -0000
Received: from box313.bluehost.com ([69.89.31.113]) by CMOut01 with id ip1H1u0212SSUrH01p1LzW; Thu, 09 Feb 2017 18:01:21 -0700
X-Authority-Analysis: v=2.1 cv=U+QBU4bu c=1 sm=1 tr=0 a=h1BC+oY+fLhyFmnTBx92Jg==:117 a=h1BC+oY+fLhyFmnTBx92Jg==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=IkcTkHD0fZMA:10 a=xqWC_Br6kY4A:10 a=n2v9WMKugxEA:10 a=48vgC7mUAAAA:8 a=fDOeviFNIXX-aRIJdMgA:9 a=QEXdDO2ut3YA:10 a=w1C3t2QeGrPiZgrLijVG:22
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=labn.net; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Date: Message-ID:Subject:From:Cc:To:Sender:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=52A8Ev5WamD0a+j23wd6KpMhnIatjMmSde94fLHemAk=; b=rXqlXWMxBuX7DiBtsTmOHpgWhv A6+DyRZ56lTPwAkbHZ7IDgcsGClyYK0aC0E1GHCobiBpUZDsb1nesx5CLh+LRJMPfQgdRYRBngeWy x94s4PY5klUu7YSbjESvgpa3D;
Received: from pool-100-15-85-191.washdc.fios.verizon.net ([100.15.85.191]:53728 helo=[IPv6:::1]) by box313.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.87) (envelope-from <lberger@labn.net>) id 1cbzaP-0003w4-KM; Thu, 09 Feb 2017 18:01:17 -0700
To: rtg-ads@ietf.org
From: Lou Berger <lberger@labn.net>
Message-ID: <ebd9efed-4a8c-df1e-4edf-d80ad0aa688e@labn.net>
Date: Thu, 9 Feb 2017 20:01:13 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - box313.bluehost.com
X-AntiAbuse: Original Domain - ietf.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - labn.net
X-BWhitelist: no
X-Source-IP: 100.15.85.191
X-Exim-ID: 1cbzaP-0003w4-KM
X-Source:
X-Source-Args:
X-Source-Dir:
X-Source-Sender: pool-100-15-85-191.washdc.fios.verizon.net ([IPv6:::1]) [100.15.85.191]:53728
X-Source-Auth: lberger@labn.net
X-Email-Count: 3
X-Source-Cap: bGFibm1vYmk7bGFibm1vYmk7Ym94MzEzLmJsdWVob3N0LmNvbQ==
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/sx82MoLUCUeRiMrCC58x9SVTJ_c>
Cc: idr@ietf.org, draft-ietf-idr-shutdown.all@ietf.org, rtg-dir@ietf.org
Subject: [Idr] RtgDir review: draft-ietf-idr-shutdown-05
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Feb 2017 01:01:34 -0000

Reviewer: Lou Berger
Review Date: 2/9/17
Review requested by: 2/13
Intended Status: Standards track

Summary:
    I have one minor comment about this document that I think should be
resolved before publication.

Comments:

    Draft is short and easy to understand.  I see the need for one minor
clarification that can be resolved based on implementation experience.

Major Issues:

    No major issues found.

Minor Issues:
    In reading the document it's unclear if Shutdown Communication field
must include a trailing zero or not.  (I authored something similar once
and had an interop problem where one implementation assumed null
termination was required and included in length, while the other didn't.
Our intent was no null required, but the spec wasn't explicit.)   Either
are fine, and given there are implementations you might just want to
have the spec match the implementation.

Nits:
  
https://tools.ietf.org/idnits?url=https://tools.ietf.org/id/draft-ietf-idr-shutdown-05.txt
reports nits that should be fixed.

That's it!
Cheers,
Lou