Re: [Idr] 答复: WG LC for draft-ietf-idr-bgp-ls-segment-routing-ext-04 (March 7 to March 21)

Aijun Wang <wangaijun@tsinghua.org.cn> Wed, 11 April 2018 11:34 UTC

Return-Path: <wangaijun@tsinghua.org.cn>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F34AF126CB6 for <idr@ietfa.amsl.com>; Wed, 11 Apr 2018 04:34:04 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, MIME_QP_LONG_LINE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id w0EyVsgEKIkU for <idr@ietfa.amsl.com>; Wed, 11 Apr 2018 04:34:01 -0700 (PDT)
Received: from m21397.mail.qiye.163.com (m21397.mail.qiye.163.com [223.252.213.97]) by ietfa.amsl.com (Postfix) with ESMTP id B016F124BE8 for <idr@ietf.org>; Wed, 11 Apr 2018 04:33:59 -0700 (PDT)
Received: from [192.168.124.4] (unknown [36.102.210.6]) by m21397.mail.qiye.163.com (Hmail) with ESMTPA id 3263D142C2A; Wed, 11 Apr 2018 19:33:53 +0800 (CST)
Content-Type: multipart/alternative; boundary=Apple-Mail-3389FA07-5DA6-4519-96F5-1C3A3D0AA1F0
Mime-Version: 1.0 (1.0)
From: Aijun Wang <wangaijun@tsinghua.org.cn>
X-Mailer: iPhone Mail (15E216)
In-Reply-To: <2ac4f73831924749aa53edcd1adb52be@XCH-ALN-008.cisco.com>
Date: Wed, 11 Apr 2018 19:33:49 +0800
Cc: Susan Hares <shares@ndzh.com>, idr wg <idr@ietf.org>
Content-Transfer-Encoding: 7bit
Message-Id: <50FE988A-A9DD-435A-BC25-F1729768747E@tsinghua.org.cn>
References: <011201d3b633$0b5fee60$221fcb20$@ndzh.com> <005901d3d144$02ea09b0$08be1d10$@org.cn> <2ac4f73831924749aa53edcd1adb52be@XCH-ALN-008.cisco.com>
To: "Ketan Talaulikar (ketant)" <ketant@cisco.com>
X-HM-Spam-Status: e1ktWUFJV1koWUFKTEtLSjdXWQgYFAkeWUFLVUtXWQkOFx4IWUFZMjUtOj cyP0FLVUtZBg++
X-HM-Sender-Digest: e1kSHx4VD1lBWUc6NTY6Hww*GTovOjdKOTwUMCgcCQMwCjRVSlVKTklI T09NT0hDT0xIVTMWGhIXVQwaFRwaEhEOFTsPCBIVHBMOGlUUCRxVGBVFWVdZDB4ZWUEdGhcIHldZ CAFZQUhKSEhMN1dZEgtZQVlITVVKS0lVSUpLVU1ZBg++
X-HM-Tid: 0a62b47bc5b97f6bkuuk3263d142c2a
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/u3wpq7LGfcs3YPfo_Tc8IVOIWOo>
Subject: Re: [Idr] =?utf-8?b?562U5aSNOiAgV0cgTEMgZm9yIGRyYWZ0LWlldGYtaWRyLWJn?= =?utf-8?q?p-ls-segment-routing-ext-04_=28March_7_to_March_21=29?=
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Apr 2018 11:34:05 -0000

Hi, Ketan:
I think the revised version is more clear.

Regarding the Source Router Identifier (Source Router-ID) TLV”, I think stripped it from the current draft did not influence the implementation on the device. We just reorganize the reference for this TLV, put it into the most suitable document for BGP-LS extension.
This TLV is more relevant to the Inter-AS situation and should be extended to cover all IGP scenarios, not just for ISIS in current document.
If possible, I can invite the author of this draft to be the co-authors of the BGP-LS inter-as extension draft.

Except this point, I fully agree with you the updates.



> 在 2018年4月11日,17:59,Ketan Talaulikar (ketant) <ketant@cisco.com> 写道:
> 
> Hi Aijun,
>  
> Please check inline below in your email for responses. Do let me know if this addresses your comments and I will post the updates accordingly.
>  
> Thanks,
> Ketan
>  
> From: Idr <idr-bounces@ietf.org> On Behalf Of Aijun Wang
> Sent: 11 April 2018 08:50
> To: 'Susan Hares' <shares@ndzh.com>om>; 'idr wg' <idr@ietf.org>
> Subject: [Idr] 答复: WG LC for draft-ietf-idr-bgp-ls-segment-routing-ext-04 (March 7 to March 21)
>  
> Hi, Susan and Authors of this draft:
>  
> Sorry to reply this LC so late.  The followings are my suggestions to this draft based on the discussion related to the mail thread https://mailarchive.ietf.org/arch/msg/idr/vSeflAMCMPL25N4nBOZu8yG19HA
> Is it too late to response?  Please see the reply below in line.
>  
> Best Regards.
>  
> Aijun Wang
> Network R&D and Operation Support Department
> China Telecom Corporation Limited Beijing Research Institute,Beijing, China.
>  
> 发件人: Susan Hares [mailto:shares@ndzh.com] 
> 发送时间: 2018年3月8日 0:41
> 收件人: 'idr wg'
> 主题: [Idr] WG LC for draft-ietf-idr-bgp-ls-segment-routing-ext-04 (March 7 to March 21)
>  
> This begins a 2 week WG LC for draft-ietf-idr-bgp-ls-segment-routing-ext-04.txt from March 7th to March 21.  During your discussion in the WG LC, please indicate the following things:
>  
> 1)     Do you think BGP should carry these link state information regarding segment routing,
> “Source Router Identifier (Source Router-ID) TLV” should be stripped off this draft, because there are other situations(more general scenarios besides SR) that requires the source router of the prefixes, as described in https://datatracker.ietf.org/doc/draft-wang-idr-bgpls-inter-as-topology-ext/ and discussed in mail thread https://mailarchive.ietf.org/arch/msg/idr/-T7U1yg8DmSdDmtyfqBgtnkO4I0
> [KT] You are right that Source Router-ID TLV is not SR specific. SR was one of the key use-cases where this was felt this was necessary especially in ISIS (see rfc7794). The authors of the BGP-LS SR draft felt it was necessary to introduce and cover it as part of this draft given the use-cases. It has been part of this draft since many years and even before it was adopted by the WG. It has implementations and deployments. I would say you are too late in bringing forward such a comment at this stage. With regards to the inter-AS draft, you have seen the responses on the WG mailer as well as at London and I do not have anything further to add.
> 2)     Are there any technical issues with this draft?
>  
> Some clarifications should be added in the following sections:
> a) Regarding the usage of SID/Label sub-TLV:
> “2.1.2 SR-Capabilities TLV”, “2.1.4 SR Local Block TLV” requires all the presence of “SID/Label sub-TLV”.  It is more clear to indicate  this “SID/Label sub-TLV” represent the base of the “Range Size”.
> [KT] How about instead of “SID/Label sub-TLV (as defined in Section 2.1.1).” we change it to “SID/Label sub-TLV (as defined in Section 2.1.1) which encodes the first label in the range.”? Would  this help clarify?
>  
> b) Regarding the inconsistence definition among “ISIS/OSPF/OSPFv3/BGP-LS” :
>     “2.2.1 Adjacency SID”, “2.2.2 LAN Adjacency SID TLV”,”2.3.1 Prefix-SID TLV”
> Note for “Length” field:   2-bytes “Reserved” filed should be added when copying the corresponding fields from IS-IS protocol
> [KT] Now about for Length, we say for Adj-SID & Prefix-SID – “Variable, 7 or 8 depending on Label or Index encoding of the SID” and for LAN-Adj-SID we say “Variable. For ISIS it would be 13 or 14 depending on Label or Index encoding of the SID. For OSPF it would be 11 or 12 depending on Label or Index encoding of the SID.”
>  
>                 c) Regarding the definition “Range TLV”:
>                     if the “Length” filed is 4, how to detect the existence of “sub-TLV?”
> [KT] You are right. The length should be variable since we have sub-TLVs and also the Prefix SID sub-TLV SHOULD be present to indicate the first label of the Range. I will correct this.
>  
>                     Is it more clear to rename the “Range TLV” as “Mapping-Range TLV”, so as to distinguish it from the previous “Range filed” in  “2.1.2 SR-Capabilities TLV”?
> [KT] I am not sure if we should make this name change at this stage. I don’t see the confusion between the two TLVs. However, if there is WG consensus to make this change then I would do so.
>  
>                 d) Regarding  the contents for “3. Procedures”:
>                    Suggest to delete this section, because:
> -------Contents in section 3.1, 3.2 has been mentioned in corresponding TLV definition(section 2.3.1), there is no more new information in this section.
> [KT] OK will do.
>  
> -------Contents in  section 3.3 and 3.4 should be merged with section 2.3.4 to eliminate the inconsistence arose in future when update parts of them.
> [KT] Sure, I will update it in that way too since it will be all info in one place for the reader.
>  
> 3)     Is this draft is ready for publication?
> If the above issued is solved, it is ready for publication.
>  
> For your quick access to this draft, click on the link below:
>  
> https://datatracker.ietf.org/doc/draft-ietf-idr-bgp-ls-segment-routing-ext/
>  
>  
> Susan Hares
>