Re: [Idr] draft-spaghetti-idr-bgp-sendholdtimer - Feedback requested

heasley <heas@shrubbery.net> Tue, 27 April 2021 17:41 UTC

Return-Path: <heas@shrubbery.net>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 56B2E3A197C for <idr@ietfa.amsl.com>; Tue, 27 Apr 2021 10:41:23 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.898
X-Spam-Level:
X-Spam-Status: No, score=-1.898 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=unavailable autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hGsgO42_RDKe for <idr@ietfa.amsl.com>; Tue, 27 Apr 2021 10:41:20 -0700 (PDT)
Received: from sea.shrubbery.net (sea.shrubbery.net [129.250.47.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9A7033A1978 for <idr@ietf.org>; Tue, 27 Apr 2021 10:41:20 -0700 (PDT)
Received: by sea.shrubbery.net (Postfix, from userid 7053) id 25A0B24A362; Tue, 27 Apr 2021 17:41:20 +0000 (UTC)
Date: Tue, 27 Apr 2021 17:41:20 +0000
From: heasley <heas@shrubbery.net>
To: tom petch <ietfc@btconnect.com>
Cc: "Jakob Heitz (jheitz)" <jheitz=40cisco.com@dmarc.ietf.org>, Jeffrey Haas <jhaas@pfrc.org>, "idr@ietf. org" <idr@ietf.org>, Robert Raszuk <robert@raszuk.net>, Ben Cox <ben=40benjojo.co.uk@dmarc.ietf.org>
Message-ID: <YIhMwHpkRuhSRAaF@shrubbery.net>
References: <CAL=9YSVy+mvxvAv+maxkUSzPbe0bfnUy-XJJTtcVhi3S3bm=WQ@mail.gmail.com> <20210423212348.GB19004@pfrc.org> <CAOj+MMGH+y-gxSLaakknWSPFLEk9ikkUU1fa=3H0FjkokAbg3w@mail.gmail.com> <20210424004838.GC19004@pfrc.org> <CAOj+MMH5yzpPZjdUcfXV4cxCORqCsQY4X+niBjnwxjPfN-tsJA@mail.gmail.com> <BYAPR11MB3207E4A0BDC3367E21886C55C0439@BYAPR11MB3207.namprd11.prod.outlook.com> <20210425192705.GD19004@pfrc.org> <BYAPR11MB3207F5B28D5C9B402940D197C0439@BYAPR11MB3207.namprd11.prod.outlook.com> <AM7PR07MB624871151D9AC3B6ED40FB42A0419@AM7PR07MB6248.eurprd07.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <AM7PR07MB624871151D9AC3B6ED40FB42A0419@AM7PR07MB6248.eurprd07.prod.outlook.com>
X-PGPkey: http://www.shrubbery.net/~heas/public-key.asc
X-note: live free, or die!
X-homer: i just want to have a beer while i am caring.
X-Claimation: an engineer needs a manager like a fish needs a bicycle
X-reality: only YOU can put an end to the embarrassment that is Tom Cruise
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/ulcTBr2aFcsaTc4n9rG6TXPGdkY>
Subject: Re: [Idr] draft-spaghetti-idr-bgp-sendholdtimer - Feedback requested
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Apr 2021 17:41:23 -0000

Tue, Apr 27, 2021 at 08:22:14AM +0000, tom petch:
> It does not mean that the data plane is broken.
> If that were the case, you would get either no keepalives
> from the peer or no more acks to your own keepalives.
> <tp>
> I agree with you up to the last sentence  If the TCP window is zero, then you cannot send anything, apart from ACK and similar control packets (since ACK controls the window and so has to get through).  Your own keepalives cannot be sent, just as updates cannot be sent.  I think that this is spelt out in the I-D.

Doesn't this depend on the TCP implementation, which should send a probe
with the seq of the last sent seq (snd.nxt - 1).  unless it is an old
impl., the probe data size should be zero - ie: no seq advancement.

if it could not send KAs, these tcp sessions would have expired after ~2h.