[Idr] Re: Shepherd reviews draft-ietf-idr-sr-te-policy-attr-02

liu.yao71@zte.com.cn Tue, 05 August 2025 02:29 UTC

Return-Path: <liu.yao71@zte.com.cn>
X-Original-To: idr@mail2.ietf.org
Delivered-To: idr@mail2.ietf.org
Received: from localhost (localhost [127.0.0.1]) by mail2.ietf.org (Postfix) with ESMTP id 98E7A4FD121E; Mon, 4 Aug 2025 19:29:02 -0700 (PDT)
X-Virus-Scanned: amavisd-new at ietf.org
X-Spam-Flag: NO
X-Spam-Score: -1.894
X-Spam-Level:
X-Spam-Status: No, score=-1.894 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001] autolearn=ham autolearn_force=no
Received: from mail2.ietf.org ([166.84.6.31]) by localhost (mail2.ietf.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8HhJ-nz_rbIr; Mon, 4 Aug 2025 19:29:02 -0700 (PDT)
Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [160.30.148.35]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail2.ietf.org (Postfix) with ESMTPS id 92E9B4FD1215; Mon, 4 Aug 2025 19:29:01 -0700 (PDT)
Received: from mse-fl1.zte.com.cn (unknown [10.5.228.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mxhk.zte.com.cn (FangMail) with ESMTPS id 4bwy6J5sHNz8Xs7F; Tue, 05 Aug 2025 10:28:56 +0800 (CST)
Received: from njb2app05.zte.com.cn ([10.55.22.121]) by mse-fl1.zte.com.cn with SMTP id 5752Sjld077965; Tue, 5 Aug 2025 10:28:45 +0800 (+08) (envelope-from liu.yao71@zte.com.cn)
Received: from mapi (njy2app03[null]) by mapi (Zmail) with MAPI id mid203; Tue, 5 Aug 2025 10:28:46 +0800 (CST)
Date: Tue, 05 Aug 2025 10:28:46 +0800
X-Zmail-TransId: 2afb68916c5e533-48c20
X-Mailer: Zmail v1.0
Message-ID: <20250805102846377-www8UVj3Vq3PxzbzESBH@zte.com.cn>
In-Reply-To: <DM8PR08MB74139F2C8B2F04CF797C2BF3B355A@DM8PR08MB7413.namprd08.prod.outlook.com>
References: DM8PR08MB74139F2C8B2F04CF797C2BF3B355A@DM8PR08MB7413.namprd08.prod.outlook.com
Mime-Version: 1.0
From: liu.yao71@zte.com.cn
To: shares@ndzh.com
Content-Type: multipart/mixed; boundary="=====_001_next====="
X-MAIL: mse-fl1.zte.com.cn 5752Sjld077965
X-TLS: YES
X-SPF-DOMAIN: zte.com.cn
X-ENVELOPE-SENDER: liu.yao71@zte.com.cn
X-SPF: None
X-SOURCE-IP: 10.5.228.132 unknown Tue, 05 Aug 2025 10:28:56 +0800
X-Fangmail-Anti-Spam-Filtered: true
X-Fangmail-MID-QID: 68916C68.001/4bwy6J5sHNz8Xs7F
Message-ID-Hash: YHJACZVJDBH4OJ34KADYVT2T7ZEB36R4
X-Message-ID-Hash: YHJACZVJDBH4OJ34KADYVT2T7ZEB36R4
X-MailFrom: liu.yao71@zte.com.cn
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-idr.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: idr@ietf.org, draft-ietf-idr-bgp-ls-te-path@ietf.org
X-Mailman-Version: 3.3.9rc6
Precedence: list
Subject: [Idr] Re: Shepherd reviews draft-ietf-idr-sr-te-policy-attr-02
List-Id: Inter-Domain Routing <idr.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/vUnpl5FsD2jP8BplWboQnmr1AsM>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Owner: <mailto:idr-owner@ietf.org>
List-Post: <mailto:idr@ietf.org>
List-Subscribe: <mailto:idr-join@ietf.org>
List-Unsubscribe: <mailto:idr-leave@ietf.org>

Hi Sue,

Thanks a lot for the detailed shepherd review. I've just submitted v-03 to address the comments, i.e, Review-02, Issue-1.
And about the implementations mentioned in the shepherd review, there might be a mistake. Currently it is an experimental document without implementation, as mentioned in section 6 of it.

Best Regards,
Yao





Original


From: SusanHares <shares@ndzh.com>
To: idr@ietf.org <idr@ietf.org>;
Cc: draft-ietf-idr-bgp-ls-te-path@ietf.org <draft-ietf-idr-bgp-ls-te-path@ietf.org>;
Date: 2025年07月14日 06:21
Subject: [Idr] Shepherd reviews draft-ietf-idr-sr-te-policy-attr-02

_______________________________________________
Idr mailing list -- idr@ietf.org
To unsubscribe send an email to idr-leave@ietf.org
 

Shepherd reviews draft-ietf-idr-sr-te-policy-attr-02
Summary
draft: draft-ietf-idr-sr-te-policy-attr
 Type: Proposed Standard
 status: WG Draft
 adopted: 8/12/2024 (adoption call: 7/12/2024 - 7/30/2024)
 current version: 02
 Early Allocation: -03 required prior to Early Allocation request
 implementations: H3C and ZTE (2 implementations)
 bgp-ls draft: would need to augment deraft-ietf-idr-bgp-ls-sr-policy
 
Review -02
Reviewer: Susan Hares
 draft: draft-ietf-idr-sr--te-policy-attr-02
Status of Technical issues from -01 Review
Review-01, Issue-1: Resolved in section 1 in the following text:
BGP UPDATE message
 sends the NLRI that identifies an SR Policy Candidate Path, and the
 attributes that encode the segment lists and other details of that SR
 Policy Candidate Path. These BGP attributes include the Tunnel
 Encapsulation Attribute [RFC9012] with the SR Policy Tunnel-Type, and
 it encodes SR Policy tunnel information (per
 [I-D.ietf-idr-sr-policy-safi]).
Review-01, Issue-2: Resolved in section with the text:
This section defines four new Segment types and the corresponding
 Segment Sub-TLVs of Segment List Sub-TLV to provide algorithm
 information for SR-MPLS Adjacency-SIDs. The Segment Sub-TLVs in this
 document are only defined for the Segment list Sub-TLV used by the
 Tunnel Encapsulation Attribute with the SR Policy Tunnel-Type as per
 [I-D.ietf-idr-sr-policy-safi]. All other usages are outside the
 scope of this document.
review-01, Issue-3: Resolved by the text in section 3 of:
The processing procedures for SID with algorithm specified in
[RFC9256] and [I-D.ietf-idr-bgp-sr-segtypes-ext] are still applicable
 for the new segment types. Just as in [I-D.ietf-idr-sr-policy-safi],
 the segment list sub-TLVs specified in this document (sections 3.1,
 3.2, 3.3, and 3.4) MAY repeat multiple times within the segment-list
 Sub-TLV. BGP only checks the syntax of the fields, but the semantic
 meaning is check by the consumer. When the algorithm is not
 specified for the SID types above which optionally allow for it, the
 headend SHOULD use the Strict Shortest Path algorithm if available;
 otherwise, it SHOULD use the default Shortest Path algorithm.
review-01, Issue-4 - resolved with the inclusion of section 6
 
The following needs to be corrected prior to early allocation for this draft:  
Review-02, Issue-1 - Security section needs to describe critical information
The information in segment types L-O are critical pieces of information about the infrastructure of a network or multiple network segments. The Security section needs to mention that the operators need to carefully restrict access to the information contained in segments L-O. A list of the unique information is useful in this section.