Re: [Idr] RtgDir review: draft-ietf-idr-shutdown-05

Job Snijders <job@ntt.net> Fri, 10 February 2017 01:40 UTC

Return-Path: <job@ntt.net>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 23FBA1294C8; Thu, 9 Feb 2017 17:40:14 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.935
X-Spam-Level:
X-Spam-Status: No, score=-1.935 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RP_MATCHES_RCVD=-0.001, SPF_SOFTFAIL=0.665] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pV_DZhUvl4dE; Thu, 9 Feb 2017 17:40:13 -0800 (PST)
Received: from mail3.dllstx09.us.to.gin.ntt.net (mail3.dllstx09.us.to.gin.ntt.net [IPv6:2001:418:3ff:5::26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EDF01129464; Thu, 9 Feb 2017 17:40:12 -0800 (PST)
Received: by mail3.dllstx09.us.to.gin.ntt.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.88) (envelope-from <job@ntt.net>) id 1cc0C2-000BKR-2r (job@us.ntt.net); Fri, 10 Feb 2017 01:40:12 +0000
Date: Thu, 9 Feb 2017 20:38:50 -0500
From: Job Snijders <job@ntt.net>
To: rtg-ads@ietf.org, Lou Berger <lberger@labn.net>
Message-ID: <1c3216b3-31a2-43a0-a003-6571fe133fbb@Spark>
In-Reply-To: <ebd9efed-4a8c-df1e-4edf-d80ad0aa688e@labn.net>
References: <ebd9efed-4a8c-df1e-4edf-d80ad0aa688e@labn.net>
X-Readdle-Message-ID: 1c3216b3-31a2-43a0-a003-6571fe133fbb@Spark
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="589d19c2_66334873_74b"
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/vgteLmAwciBh1WfA-GBueiPZXUM>
Cc: idr@ietf.org, draft-ietf-idr-shutdown.all@ietf.org, rtg-dir@ietf.org
Subject: Re: [Idr] RtgDir review: draft-ietf-idr-shutdown-05
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Feb 2017 01:40:14 -0000

Dear Lou,

Thank you for your review.

We will add a clarification that NUL termination is not expected.

The question actually came up during one of the implementations so you are right that there is value in being specific.

Kind regards,

Job

On 9 Feb 2017, 20:01 -0500, Lou Berger <lberger@labn.net>et>, wrote:
> Reviewer: Lou Berger
> Review Date: 2/9/17
> Review requested by: 2/13
> Intended Status: Standards track
>
> Summary:
> I have one minor comment about this document that I think should be
> resolved before publication.
>
> Comments:
>
> Draft is short and easy to understand. I see the need for one minor
> clarification that can be resolved based on implementation experience.
>
> Major Issues:
>
> No major issues found.
>
> Minor Issues:
> In reading the document it's unclear if Shutdown Communication field
> must include a trailing zero or not. (I authored something similar once
> and had an interop problem where one implementation assumed null
> termination was required and included in length, while the other didn't.
> Our intent was no null required, but the spec wasn't explicit.) Either
> are fine, and given there are implementations you might just want to
> have the spec match the implementation.
>
> Nits:
>
> https://tools.ietf.org/idnits?url=https://tools.ietf.org/id/draft-ietf-idr-shutdown-05.txt
> reports nits that should be fixed.
>
> That's it!
> Cheers,
> Lou
>
> _______________________________________________
> Idr mailing list
> Idr@ietf.org
> https://www.ietf.org/mailman/listinfo/idr