[Idr] AD Review of draft-ietf-idr-bgp-sendholdtimer-10

Roman Danyliw <rdd@cert.org> Tue, 25 June 2024 15:37 UTC

Return-Path: <rdd@cert.org>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E0CF9C180B52 for <idr@ietfa.amsl.com>; Tue, 25 Jun 2024 08:37:20 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.108
X-Spam-Level:
X-Spam-Status: No, score=-2.108 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cert.org
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id C85BULkY-dUb for <idr@ietfa.amsl.com>; Tue, 25 Jun 2024 08:37:16 -0700 (PDT)
Received: from USG02-CY1-obe.outbound.protection.office365.us (mail-cy1usg02on0081.outbound.protection.office365.us [23.103.209.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 931CDC1E0D8F for <idr@ietf.org>; Tue, 25 Jun 2024 08:37:05 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector5401; d=microsoft.com; cv=none; b=rl7ylKJ1Cel6XiAL2+1ZMyIiQ/m5OINtOcHxaSSeWkJxaApbazZbnrlIccgSo/67rbw44ERDcufUNEGGk6jQ5dFRB7/fKe4dibodlvNzqaqRsFZnATuevL3IZqRbGL71BhmuGu3lvZTVN2eYC0oBCr5TNU53PVuDJje8GosaE4D+qcHTmi2dywNIjerhGxH+NMjrz+fu4ky/u87PKXjPtzJk+WL1ceg/0XD9zYA88VZBgeHOnEl9Fk9qtvRkWzGtyJNqjHF2ifmeY2Na9nWYNBjWqYtuGwik7Id9N34Mvu+T2hW1ujVuhgrRji2YhClzvs1g1y2P/KWRdaautYKOAA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector5401; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vfuh/M/cpniluhrhSRh9LiUUL6/h2oWS+dLkzC7FOTA=; b=ZlIcjLNsQllvC53aWWnpjLrVlRFY9TNHwfXJOdWg7rwT8XmWP9wTKBgid67/p4fuq5mGxzq5epxgDcd8jXjkMAj9n5niOlpUTIRVr38VtNecWCXyeesz6l0DZrhqcbJsrha44COMWcYSmy8BnFmhVYKkpBRA42uyn0DwrHGIzo4gP/c+AxA/3M0k6a0yPO+Ml2h77cym5gpPUrjtw32wHIgqqrYUEoGpnzDvioeWKAisDqh6e73ZQgmt0gIohAeCsqRAFgmN7HgvntC7kQlBcFhNHlPo1aliLP6hFIn+QBImX/DRhzUZBt347oq4JtArGTEwOuADW0XUU9jJL+k32g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cert.org; dmarc=pass action=none header.from=cert.org; dkim=pass header.d=cert.org; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cert.org; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vfuh/M/cpniluhrhSRh9LiUUL6/h2oWS+dLkzC7FOTA=; b=fpQRgwTATXr1G9Pn7eYQzKWwX0Ww3QuBH8Pa+HDt4QjTWSkawRgBGXScwAOAuNxclEj03iATXrNygKPSR5pOk8WhShDje7dZ3ljbz0aCbx63YiyooZ/Mg5bIvmkiKmra6oo/Qw3wzFnTFhRMcWQTm5VyzVlKOLrF2w34Qjxmqa0=
Received: from BN2P110MB1107.NAMP110.PROD.OUTLOOK.COM (2001:489a:200:168::11) by BN2P110MB1318.NAMP110.PROD.OUTLOOK.COM (2001:489a:200:17f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.30; Tue, 25 Jun 2024 15:37:03 +0000
Received: from BN2P110MB1107.NAMP110.PROD.OUTLOOK.COM ([fe80::cbdf:26e2:6028:1349]) by BN2P110MB1107.NAMP110.PROD.OUTLOOK.COM ([fe80::cbdf:26e2:6028:1349%6]) with mapi id 15.20.7698.025; Tue, 25 Jun 2024 15:37:03 +0000
From: Roman Danyliw <rdd@cert.org>
To: "idr@ietf.org" <idr@ietf.org>
Thread-Topic: AD Review of draft-ietf-idr-bgp-sendholdtimer-10
Thread-Index: AdrHFESU7vb+ntb/TyGDmat7jxBaKwAASk0w
Date: Tue, 25 Jun 2024 15:37:03 +0000
Message-ID: <BN2P110MB11072976193ABF423AC4FD6CDCD5A@BN2P110MB1107.NAMP110.PROD.OUTLOOK.COM>
References: <BN2P110MB11075E385EA61E9D9DB2918EDCD5A@BN2P110MB1107.NAMP110.PROD.OUTLOOK.COM>
In-Reply-To: <BN2P110MB11075E385EA61E9D9DB2918EDCD5A@BN2P110MB1107.NAMP110.PROD.OUTLOOK.COM>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=cert.org;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BN2P110MB1107:EE_|BN2P110MB1318:EE_
x-ms-office365-filtering-correlation-id: e9758ed4-2f5c-414d-cdcb-08dc952ca9a0
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;ARA:13230037|1800799021|41320700010|366013|38070700015;
x-microsoft-antispam-message-info: 68DQU5d7Ye0g4nHNPMIeDbE9SzVmjQ5Q4rcSnav4GuKZwmP7oLInVvXRVGwls1fHviB1r2Xl3JJpXIvV1FG4nCpG6TlZv6FDhz7D+xHPmC8I7Fi62kVqNoTUuZpxsNjyHbosZ37hhx+X7Pclqv+33WmEnWDNzL9FlFKzeH/pS+t9/NvCaCCvvfdxIUxeLp3r4i6p1eP0yzO+XCO8RBCt25XREzA4h3hNE4IK4Rw2KNb9t3Hn0AcVEXLHh7LA15MCU/3BIguGQtn8uRMxIAj7Qc7AyYKY1r0qeRnJgLc8MYVUVhVm2GQxMOHbVyMCIoIOkYadowyp6DBJT8L/YPaCpXWODgKGO9ZcIuzSsiNDRON3MwmLDfZq29A1QweOqf1Q2ip+ru38gN48bd+MBBia7WtNT4VX0D3LDNnJVsnBTRB12aUqGIpOh5TufcnAOeIRLRPtAZkfVxfGyqrYGkw7uH8FfK4Y+91+XQ+lx4pwHo8D60/X4uLTJTMuTGcAhxAlsUauyH24vRPPwPxK+XYk/ykB83+fna8bf+vuLYqrxI6hX2cPp8K+qgokK8BO3U4grifXDcBS+ltTqc917pAcabw7RB29oauESj4+sdVfS2BFqosDmprY/mSUy1gVQWH9hZv6Sy72Czg3qWPEw35qTlR1RrAs18j9ZGKb+ku4yIjK8X3cTqdkX3IEVpjOAPjzHyNFHgagiZwozVCMcm7Q98gwuv7j1u3tTJG7f6pbjAw1rRjk+xPbIlxyMNnhOAkHYY5zMouXZBpiC3jbyIBg+awa+43ZqOwb+G6vkYSHsMWDvvsRtqInpqyx+iAGMVagsrFv9Ia2iqY07P5ceEh62Y5yJvltI+4Tc3sdRCPpvUwVuQQJMfzMqxWRRBfNR7zmoktIlQbNqpWeB2W5p4yWWDnZyAaKymC+/LpUVqKZsC3HnRjz8hcwXwEIhB5r32udJn7f1QSolA2mzhEvpaF+4gNaheeaxACdz+rp+VMi+51ALfERnHFnIsxMqygj3d2Giex224uJnxATu9LfrRAq+4Zxyk6AmU9A9ZnYYkXNXP2dHjTBgDS0XpcWyY1JIQ1bjPLEnA3U+OVudt4yzoDj8+vWfRT1fTfe5nY3tLDT5kc6TDNRYvGos/qnRSNU+uWW5NvzI8/Los8XVigXLfpG99q6jLzPAnR2GrJq3UA0FPDXZg4zlh7Vg+Onh68B2WC+fu6Kw6YiqaAJ3CKnnqWGy0mhY7BUbHFWMFKHEa5If11uvlY7jYjZRkyDDAp7ML6Xio4y0d9ucAsQ1f1H1jCz4ezQNqmlWzO/6TIcVmkUtl/4jOTQvTKxVf/1PVWWxeXn
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN2P110MB1107.NAMP110.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230037)(1800799021)(41320700010)(366013)(38070700015);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: AC7wZBYOeXBgypDXSfIFe4rHIqyE7JIcuTJQS30uMIg4KjbbPDdQyfJ718veMeCm+m9XkptHW5qJIv7P7fbwHrKBMzFEeUWmA43iNrnKkPfXRQLQtjw1M2awGuJa1V7KfYbg0tcLaB/G70v3eVNlWBCSj7FypatchktbOP9nmgqjM8wTzTjnP+l1qqmiXfd0ZpLMugqTl/hfiTvSW/5HzV5yx+cqRX9NSfQ5Pr1xel5ZGWbSs0GUuCgcHhBLaiIF28hhmjrXewH8o/cXHYobgA4fvQplrbd2lnLSCYCnjmWRm7TUEn8akPgK0coiJb1U2Laa6TEbiYdl6h86NqHkFjFxRj2KvUJOyGDNLzGG7MOxCayzMWXcwc282HBZQjFAZ7LzNQRAGGjAips4Rf4HWnVnzpozPrMXvLVjp3oaAFBUrxgIeL1LLu6R6UgnC3EboYXm2f2XA8wP4Akn6JUCPiryOsgcOxFDntxG+LdekcJK215e7ul+QwUdnwOjeq5c5rEXfG0b+BXrYBvMNk6b4mobTVxHCiaedCGtRf+swEum7zA2T72UFsZdqxgqqsbrNBz+Icz7aas0lARNF9bjR6KnN/LeSJbc+YAAlYtbf7RtVpCv5PhkgVAwUrXsFTJrRHhRLKY40ydPZREyYQt3pR5N6y4KgCicvLFYuHjmoGMaVjpWx8BmyOYO0ZB/9R9uBrusEK+snkxvCGpIBaQBKeHES2mn9v4LYRrPKT0GG5RhogC6ZiuVK1+VsG6QMnO5A9NF8WJCt4CzIFlRa486KH0cBXLL5H9qvT8HpfIceV2Wpn7XiYWkgIV2pVnISxaFEEnjVD45nqeqbEOAoXHWsH3Hg7RDaz+dnmiOXwROD2voqczXcdvmdKMLPCgEUcBFxLnN64vl1YII0z2g3LdqbKvdfUkVU3gg/lCQaFY1bqO2JwBYW8vaDx9B7QLWn8G5u0nJk9a72KZL6x/52Z90MNuEueygrFt45UG+tWXTQ8ESPS1WMfZJMqCHtwI5cM7dmMNM/9RA62uJmTn4PECJCLSIXnAeRAzyeq4opBzNxS9e9q1sj7Ly7mtx6Xrs+MovFX5lETIF2K2wUJ753ucubHql03sxEa5eeHe8LP69MYp3h3t1PAOeSWUFs7OroalbaVRlwOrs4BYuB9MhHyILw+oXRWjUNl9BUuBLx1WaO66SH53AIbVHwbDXhzBcIVywpjlXX2ULIKjgt5Y6g7vkx6lgNNkvJVMwZStqS0dIiJgrmq1ZvuTX/xAolie13gxJSOpju5EESXYFp0lGjXAOniEu0YD0LPMF58Udxr0bZGUZyem7a9CZ8HvOu9aRNMrjEyCsLWGaes6NZSaaqUklelDRPtp6KZ45HtzzDFIqPOASgbhUBnoZlH/Z9o3WtNNfX1q0sWewJUEUn2p867RikZGfHw9I+B3lXqB1wzLlvWtGaARo7rIQED/8JtrFJwNwo7BWJ8vxWoJHh+foKcSFrvUFwW6PH9LDt9ZBprQhFdE=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: cert.org
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN2P110MB1107.NAMP110.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: e9758ed4-2f5c-414d-cdcb-08dc952ca9a0
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jun 2024 15:37:03.6249 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 95a9dce2-04f2-4043-995d-1ec3861911c6
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN2P110MB1318
Message-ID-Hash: 57HDN7ENLBCLDJV2CUGLOOVAQPQ7HP6J
X-Message-ID-Hash: 57HDN7ENLBCLDJV2CUGLOOVAQPQ7HP6J
X-MailFrom: rdd@cert.org
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-idr.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.9rc4
Precedence: list
Subject: [Idr] AD Review of draft-ietf-idr-bgp-sendholdtimer-10
List-Id: Inter-Domain Routing <idr.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/w-qJ4ipfddOpEemDpxpy4WHO-5I>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Owner: <mailto:idr-owner@ietf.org>
List-Post: <mailto:idr@ietf.org>
List-Subscribe: <mailto:idr-join@ietf.org>
List-Unsubscribe: <mailto:idr-leave@ietf.org>

Hi!

I'm swapping with John and stepping in as the responsible AD for draft-ietf-idr-bgp-sendholdtimer.  I performed an AD review on draft-ietf-idr-bgp-sendholdtimer-10.  Thanks for this document.  My feedback is as follows:

** idnits reports:

  -- The document seems to lack a disclaimer for pre-RFC5378 work, but may
     have content which was first submitted before 10 November 2008.  If you
     have contacted all the original authors and they are all willing to grant
     the BCP78 rights to the IETF Trust, then this is fine, and you can ignore
     this comment.  If not, you may need to add the pre-RFC5378 disclaimer. 
     (See the Legal Provisions document at
     https://trustee.ietf.org/license-info for more information.)

Have the original authors been contact or should the alternative boilerplate be used?

** Section 3.1
   The following optional session attributes for each connection are
   added to Section 8, before "The state session attribute indicates the
   current state of the BGP FSM":

The placement of this (14) and (15) doesn’t seem accurate.  The (1) – (8) list preceding the sentence “The state session attribute indicates the current state of the BGP FSM" in Section 8 of RFC4271 lists mandatory attributes (which the attribute described in this document is not).

It seems like the (14) and (15) from this document should be added to the end of the “(1) – (13) list” that occurs after the text “The optional Session attributes are listed below”.

** Section 3.3
      -  logs an error message in the local system with the BGP Error
         Code "Send Hold Timer Expired",

Is this step mandatory?

** Section 3.4
   Section 10 of [RFC4271] summarizes BGP Timers.  This document adds
   another BGP timer: SendHoldTimer.

This text, unlike prior text, isn’t explicit in saying where the new text is being inserted in Section 10 of RFC4271.

** Section 6.
   This documents suggests that an attempt to send a
   NOTIFICATION message with the "Send Hold Timer Expired" error code is
   still made,

What does “suggests” mean?

** Section 7
   This specification does not change BGP's security characteristics.

Doesn’t it improve the resilience of the BGP model by allowing consistent termination of peers (i.e., improved availability of the global network)?

Regards,
Roman