[Idr] Rtgdir early review of draft-ietf-idr-eag-distribution-13
Ben Niven-Jenkins via Datatracker <noreply@ietf.org> Tue, 24 November 2020 07:17 UTC
Return-Path: <noreply@ietf.org>
X-Original-To: idr@ietf.org
Delivered-To: idr@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id DE4873A167A; Mon, 23 Nov 2020 23:17:47 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Ben Niven-Jenkins via Datatracker <noreply@ietf.org>
To: rtg-dir@ietf.org
Cc: idr@ietf.org, draft-ietf-idr-eag-distribution.all@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.23.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <160620226786.32561.612670509830410882@ietfa.amsl.com>
Reply-To: Ben Niven-Jenkins <ben@niven-jenkins.co.uk>
Date: Mon, 23 Nov 2020 23:17:47 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/yftjFHxuLpLRMlcrk_yNQO44LCM>
Subject: [Idr] Rtgdir early review of draft-ietf-idr-eag-distribution-13
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Nov 2020 07:17:48 -0000
Reviewer: Ben Niven-Jenkins Review result: Has Issues Hello, I have been selected as the Routing Directorate reviewer for this draft. The Routing Directorate seeks to review all routing or routing-related drafts as they pass through IETF last call and IESG review, and sometimes on special request. The purpose of the review is to provide assistance to the Routing ADs. For more information about the Routing Directorate, please see http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir Although these comments are primarily for the use of the Routing ADs, it would be helpful if you could consider them along with any other IETF Last Call comments that you receive, and strive to resolve them through discussion or by updating the draft. Document: draft-ietf-idr-eag-distribution-13.txt Reviewer: Ben Niven-Jenkins Review Date: 24 November 2020 Intended Status: Proposed Standard Summary: I have some minor concerns about this document that I think should be resolved before publication. Comments: The document is of high quality and easy to read. Major Issues: No major issues found. Minor Issues: 1) Section 2, 2nd bullet point states “the TLV must be considered malformed.” I think the must in this instance is really an RFC2119 MUST, please correct this. 2) Section 2, last paragraph states “The existing AG TLV 108 and the EAG TLV defined in this document MAY be advertised together.” However the existing AG TLV is 1088 not 108, please correct this. Nits: 1) Section 2, 2nd bullet point: s/The length value must MUST be multiple of 4./The length value MUST be a multiple of 4./ 2) Section 2, 3rd bullet point: s/that are enable/that are enabled/ Thanks Ben
- [Idr] Rtgdir early review of draft-ietf-idr-eag-d… Ben Niven-Jenkins via Datatracker
- Re: [Idr] Rtgdir early review of draft-ietf-idr-e… Jeff Tantsura
- Re: [Idr] [RTG-DIR] Rtgdir early review of draft-… Ben Niven-Jenkins