IETF Logo Mail Archive

Re: [Ietf-and-github] [Last-Call] Genart last call review of draft-ietf-git-using-github-04

Martin Thomson <mt@lowentropy.net> Tue, 10 March 2020 11:51 UTC

Return-Path: <mt@lowentropy.net>
X-Original-To: ietf-and-github@ietfa.amsl.com
Delivered-To: ietf-and-github@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 447033A1156 for <ietf-and-github@ietfa.amsl.com>; Tue, 10 Mar 2020 04:51:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.1
X-Spam-Level:
X-Spam-Status: No, score=-2.1 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=lowentropy.net header.b=sVkP/j/c; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=q8AUcUYa
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6_7_j6Rb0reH for <ietf-and-github@ietfa.amsl.com>; Tue, 10 Mar 2020 04:51:26 -0700 (PDT)
Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EEB793A1160 for <ietf-and-github@ietf.org>; Tue, 10 Mar 2020 04:51:25 -0700 (PDT)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id E7C1CA07; Tue, 10 Mar 2020 07:51:24 -0400 (EDT)
Received: from imap2 ([10.202.2.52]) by compute2.internal (MEProxy); Tue, 10 Mar 2020 07:51:25 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lowentropy.net; h=mime-version:message-id:in-reply-to:references:date:from:to :cc:subject:content-type; s=fm1; bh=wM95hqpVFmf+MVYAlK1+Yr9V+XiH AA0sKh757CpliK4=; b=sVkP/j/csEwYheQf2Fq+g+vVRrIy5WOd0tBzWl7N5mzF oMzhmplbKQLWI/oYyZ9S+XDDgVwsbRSzn2fXGVDlduX8Lq6AcT8OHL/hpbpdBHSf rYO6TOpZ9ieYv8WplgwED3pn5tQU4nFEzl0bJU/ENbDdNIDE9PUOzTCnU09pgVsE O8L+qlQHtp7w6K3d+3n6+BmsSitygfGa5uhVCcWuoq+//nLcGEn363L2GnYcWN+2 jihNaf/0QyhEiAeLGzUWB6cjijzFbxrhE+HiLOXWveVq1uP3b+L+5NnUTU3Z/k7Q Wyo+7iFRWuOHmDSoacltZEQhzpt7LDOe4JtX5MoKGA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=wM95hq pVFmf+MVYAlK1+Yr9V+XiHAA0sKh757CpliK4=; b=q8AUcUYaOKAB22igyRYX9c TP//VOtqX0TPUqrGoVCFsrZ4UU3buB8dUTuE71O6PpHnKzHbcZPqK/PSF/YAZdCJ e2tkSSW+igDapj7mUzl9oe2qLSppIoWvRzoLwfdME+3fa0JnF4k/LWZKLRLqWJRx hwKkS0tbC8T18w51nnqt1MaTVjXo8YFoIMJTC/OHSJr2WNjOFTQ1dLm6HieQZuz/ YxPkpMY4D5xso+X17VRARGa1xBLjQwu27ib0Nm/nbfEHxIdOAdzGNOLib5BlRlHp pmY134+FBuywKXx5qhHC6vcieQVirPjWjRdm8Y3VUuMKJIqgmvFRqPA4PxALYfKQ ==
X-ME-Sender: <xms:PH9nXiNx6urkpQIOgSWs71u7TkYoj07QEOgbB_0j5tJyrj4i_Fnu7A>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedruddvtddgfedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreerjeenucfhrhhomhepfdforghr thhinhcuvfhhohhmshhonhdfuceomhhtsehlohifvghnthhrohhphidrnhgvtheqnecuff homhgrihhnpehquhhitgifghdrohhrghdpghhithhhuhgsrdgtohhmnecuvehluhhsthgv rhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhhtsehlohifvghnthhroh hphidrnhgvth
X-ME-Proxy: <xmx:PH9nXlOT4O4KYJiKiajfm9BtHuUVwH4uw_rU9oImxlO_IFnTpfw-AQ> <xmx:PH9nXkQ5KgbvNcvwsCGMVA4kd4IElEyy4zelc1QrtTvebHT7_34Cew> <xmx:PH9nXnCDHGHsBvFBMsPUnsMYtqETkI5qLZDOmPML4QV-64d9scWg3Q> <xmx:PH9nXlZwMd0WVMkPSW5VjjfW64WcMQLKOpWK9NWzb7g2fGggZt8daA>
Received: by mailuser.nyi.internal (Postfix, from userid 501) id 13F8EE00BB; Tue, 10 Mar 2020 07:51:24 -0400 (EDT)
X-Mailer: MessagingEngine.com Webmail Interface
User-Agent: Cyrus-JMAP/3.1.7-991-g5a577d3-fmstable-20200305v3
Mime-Version: 1.0
Message-Id: <45abf8fd-0465-4125-94a3-1688930ebe94@www.fastmail.com>
In-Reply-To: <4499a1bb-eb83-1eac-5e69-e46f6df3f332@gmail.com>
References: <158250611906.1067.14505081937854561120@ietfa.amsl.com> <3450f158-be66-71d3-b29a-6751650d64af@gmail.com> <f1c29108-1710-425e-a6f9-394ab247896e@www.fastmail.com> <26084a2d-a6f7-955c-7994-3dc48f58f145@gmail.com> <05fd402e-5ee3-4996-8394-8835a8f3f0c7@www.fastmail.com> <4499a1bb-eb83-1eac-5e69-e46f6df3f332@gmail.com>
Date: Tue, 10 Mar 2020 22:51:03 +1100
From: "Martin Thomson" <mt@lowentropy.net>
To: "Alexandre Petrescu" <alexandre.petrescu@gmail.com>
Cc: ietf-and-github@ietf.org
Content-Type: text/plain
Archived-At: <https://mailarchive.ietf.org/arch/msg/ietf-and-github/FuCYMNc0ieWhW_HEk49JRfkoRPU>
Subject: Re: [Ietf-and-github] =?utf-8?q?=5BLast-Call=5D_Genart_last_call_rev?= =?utf-8?q?iew_of_draft-ietf-git-using-github-04?=
X-BeenThere: ietf-and-github@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Discussion of using GitHub in IETF activities, particularly for Working Groups" <ietf-and-github.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf-and-github>, <mailto:ietf-and-github-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ietf-and-github/>
List-Post: <mailto:ietf-and-github@ietf.org>
List-Help: <mailto:ietf-and-github-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf-and-github>, <mailto:ietf-and-github-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Mar 2020 11:51:32 -0000

On Tue, Mar 10, 2020, at 21:24, Alexandre Petrescu wrote:
> In that case, it would be better to say
> 
> NEW:
> > Pull requests are the GitHub feature that allow users to request 
> > to obtain the changes made to a repository.

After Barry's review it says:

A pull request is a GitHub feature that allows a user to request a change to a repository.


> > In most cases, you
> > don't even have to make an effort to do so because modern software
> > has largely left the baggage of the past behind.  We've recently
> > added the real names of contributors to the QUIC specs and it just
> > worked.
> 
> Was it with Windows 10?

Yes.  And Mac and Linux variously.  I just took the names I was given and used copy and paste.

> Were these the names I said?

See
https://quicwg.org/base-drafts/draft-ietf-quic-transport.html#name-contributors
https://github.com/quicwg/base-drafts/pull/3283/files

v2.8.7 | Report a Bug | By Email