Re: [Ietf-and-github] AD evaluation of draft-ietf-git-using-github-03

["Christopher Wood" <[e-mail]>]

Thanks for the review, Alissa! I made two PRs that should address your 
substantive comments [1] and nits [2]. Please have a look. I also left 
some comments inline below.

On 6 Feb 2020, at 12:53, Alissa Cooper wrote:
>
> === Substantive comments ===
>
> == General ==
>
> Should there be some words in this document about how research groups 
> might draw inspiration from this document, but that specific guidance 
> for research groups is out of scope?

Good idea! I made this change in [1].

>
> == Section 2.1 ==
>
> draft-ietf-git-github-wg-configuration settled on the naming 
> convention ietf-wg-<wgname> so this document needs to be updated to 
> align with that.

This is also done in [1].

>
> == Section 4.2 ==
>
> Do you want to say a few words about who determines what constitutes a 
> "substantial" change (or add a forward reference to Section 5 and 
> provide some uniform statement about it there)? For example, might 
> some WGs determine that anything non-editorial is substantial (also 
> discussed in 5.3.2)? Whose call would that be?

Pointing to 5.3.2 seems easiest and minimizes redundancy. I went with 
that in [1].

>
> == Section 4.3 ==
>
> Should we see if the secretariat can setup server infrastructure to 
> support github-notify-ml for WGs that want it, and have a process 
> whereby WGs can request support for it? This would imply changes to 
> draft-ietf-git-github-wg-configuration rather than to this document, 
> but I figured I would ask while I'm reviewing this.

I don’t have a strong opinion on this. However, it’s worth noting 
that Mark Nottingham recently introduced a new service [3] that 
effectively replaces github-notify-ml. I found it fairly easy to use. 
See [4] as a recent change made for the TLS WG. If maintaining this 
service is costly, perhaps it would be a good idea to see if the 
secretariat can help.

> == Section 10 ==
>
> I'd like to suggest:
>
> OLD
> Maintaining a mirror of a repository that is hosted on GitHub is 
> relatively simple and might be considered as a way to provide a backup 
> for the primary repository.
>
> NEW
> Maintaining a mirror of a repository that is hosted on GitHub is 
> relatively simple and is specified in [GH-CONFIG] to provide 
> IETF-hosted backups for WG repositories.

Fixed in [1].

Thanks again!

Best,
Chris

[1] https://github.com/ietf-gitwg/using-github/pull/41
[2] https://github.com/ietf-gitwg/using-github/pull/39
[3] https://github.com/ietf-github-services/activity-summary
[4] 
https://github.com/ietf-github-services/activity-summary/commit/0b7d52d77f507a6e26cce8c02e489e5d2afe1e48