Re: [Ietf-and-github] [Last-Call] Genart last call review of draft-ietf-git-using-github-04

[Martin Thomson <[e-mail]>]

On Sat, Mar 7, 2020, at 03:31, Alexandre Petrescu wrote:
> I take advantage of this Last Call about github use at IETF to give my 
> comments about writing I-Ds on github.

Hi Alex,

Thanks for sharing your experience. Taking this back to the Working Group list as it doesn't seem to be a comment about the work.

Do you think that anything in this invalidates the advice and procedures in the draft?  Or suggests the need for additions?  I didn't see anything that suggests the need for changes.  Indeed, your process would seem to fit within the pattern described, with the possible exception of missing a notice for contributors about their obligations (usually CONTRIBUTING.md).

> 3. do not commit the xml file to github before you are sure it
> compiles safely on xml2rfc.tools.ietf.org

I personally wouldn't make this recommendation.  Stuff breaks occasionally and asking people to check is unreliable.  Automated validation on check-in is my preferred solution to this problem.

Cheers,
Martin