[Ietf-and-github] Opsdir last call review of draft-ietf-git-using-github-04

Qin Wu via Datatracker <noreply@ietf.org> Mon, 24 February 2020 02:21 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: ietf-and-github@ietf.org
Delivered-To: ietf-and-github@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id E56A13A07D7; Sun, 23 Feb 2020 18:21:42 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Qin Wu via Datatracker <noreply@ietf.org>
To: <ops-dir@ietf.org>
Cc: last-call@ietf.org, draft-ietf-git-using-github.all@ietf.org, ietf-and-github@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.118.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <158251090278.1088.6094983334229327241@ietfa.amsl.com>
Reply-To: Qin Wu <bill.wu@huawei.com>
Date: Sun, 23 Feb 2020 18:21:42 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/ietf-and-github/zpc7sxu8q6gJVTmVkzOH5Dxvxek>
Subject: [Ietf-and-github] Opsdir last call review of draft-ietf-git-using-github-04
X-BeenThere: ietf-and-github@ietf.org
X-Mailman-Version: 2.1.29
List-Id: "Discussion of using GitHub in IETF activities, particularly for Working Groups" <ietf-and-github.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf-and-github>, <mailto:ietf-and-github-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ietf-and-github/>
List-Post: <mailto:ietf-and-github@ietf.org>
List-Help: <mailto:ietf-and-github-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf-and-github>, <mailto:ietf-and-github-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Feb 2020 02:21:43 -0000

Reviewer: Qin Wu
Review result: Has Nits

I have reviewed this document as part of the Ops area directorate's ongoing
effort to review all IETF documents being processed by the IESG.  These
comments were written primarily for the benefit of the Ops area directors.
Document editors and WG chairs should treat these comments just like any other
last call comments.

Good work, this draft provides working group github usage guidance and document
best practice that can be referenced by all IETF working groups. A few nits
that need to be fixed before moving forward: 1. Section 5.2,3rd paragraph: The
word "err" is a little bit weird to me. s/err more toward/lean more toward 2.
Section 5.2 5th paragraph: "As mailing lists remain the primary venue for
discussion of
   substantive matters, this mode and the document management only modes
   remain those most compatible with existing work practices for Working
   Groups."
I feel the second half sentence is disconnected and not clear. should this be
changed into "...only modes which remain those most" …? 3.Section 5.4.2,last
paragraph The label “v2” has some ambiguity, since each draft may have already
made multiple revisions. The latest version may not start with v1. In addition,
should the decision label or component label be registered in IANA?