Genart last call review of draft-ietf-bier-architecture-07

Dan Romascanu <dromasca@gmail.com> Sun, 25 June 2017 10:54 UTC

Return-Path: <dromasca@gmail.com>
X-Original-To: ietf@ietf.org
Delivered-To: ietf@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id E291C1296CF; Sun, 25 Jun 2017 03:54:07 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Dan Romascanu <dromasca@gmail.com>
To: gen-art@ietf.org
Cc: bier@ietf.org, ietf@ietf.org, draft-ietf-bier-architecture.all@ietf.org, dromasca@gmail.com
Subject: Genart last call review of draft-ietf-bier-architecture-07
X-Test-IDTracker: no
X-IETF-IDTracker: 6.55.1
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <149838804788.3251.829139224134758886@ietfa.amsl.com>
Date: Sun, 25 Jun 2017 03:54:07 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/ietf/0GE3-pw35mGuaJStV2OkioGKl3E>
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.22
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ietf/>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 25 Jun 2017 10:54:08 -0000

Reviewer: Dan Romascanu
Review result: Ready with Issues

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-bier-architecture-??
Reviewer: Dan Romascanu
Review Date: 2017-06-25
IETF LC End Date: 2017-06-29
IESG Telechat date: 2017-07-06

Summary:

This document specifies a new architecture known as "Bit Index Explicit
Replication" (BIER) for the forwarding of multicast data packets through a
"multicast domain".  It does not require a protocol for explicitly building
multicast distribution trees, nor does it require intermediate nodes to
maintain any per-flow state. This architecture is .  While the Abstract and
Introduction of the document mentions Architecture as the principal scope, this
document goes well beyond the scope of a typical architectural document.
including detailed definitions of the procedures, terminology and normative
algorithms required for BIER.

The document is clear and detailed. Because of its structure, I am missing some
information that usually can be found in architecture documents. I included
these in the 'minor issues' list. Although none of these may be a show-stopper,
I believe that addressing these before document approval can improve the
quality of the document and of the overall BIER work.

Major issues:

Minor issues:

1. As the document is targeting 'Experimental' it would be useful to mention
what is the scope of the experiment. The charter actually says:

' The scope of the experiment will be
documented in the output of the Working Group.'

Would not the Architecture document be the right place for this? If not, is
there another document that deals or is planned to define the scope of the
experiment?

2. While the Abstract and Introduction of the document mentions Architecture as
the principal scope, this document is different from a typical architectural
document. While it defines well the procedures, terminology and normative
algorithms required for BIER Intra-domain forwarding, it goes well beyond the
level of detail that other similar documents go. Specifications of the
procedures and normative algorithm should be mentioned in Abstract and
Introduction, they occupy the same or more space than architecture.

3. On the other hand I am missing the relationship with other work items in the
BIER charter - there is no manageability section for example, there is no
reference to the performance impact in networks. Maybe these are dealt with in
a different document or documents or BIER, if so it would be good at least to
mention and reference these here.

4. I also would have expected the architecture document to refer the use cases
document and note which of the use cases are being addressed and how -
draft-ietf-bier-use-cases is not even included in the references.

5. Sections 3 to 6 mentioned repeatedly provisioning. As there is no Operations
and Manageability section as in many other Routing Area documents, it is not
clear how this is expected to happen. For example draft-ietf-bier-bier-yang is
not mentioned or referred. I suggest adding a note (and maybe references) for
clarity.

6. In section 8 I found:

'Every BFR must be provisioned to know which of its interfaces lead to
   a BIER domain and which do not.  If two interfaces lead to different
   BIER domains, the BFR must be provisioned to know that those two
   interfaces lead to different BIER domains. '

It seems that the two 'must' in these sentences would rather be capitalized.

Nits/editorial comments: