Re: Review of draft-ietf-pals-status-reduction-04

["Andrew G. Malis" <[e-mail]>]

Jürgen,

On behalf of the PALS WG, thanks for the review!

Cheers,
Andy


On Tue, Mar 28, 2017 at 2:35 AM, Jürgen Schönwälder <
[e-mail]> wrote:

> Reviewer: Jürgen Schönwälder
> Review result: Has Nits
>
> Disclaimer: I have not much clue about MPLS LSP PWs and hence I am
> reading this from a perspective of a clueless outsider.
>
> Section 1.2 is not really about terminology but instead it basically
> expands acronyms. The section does not define any terms or does it
> make it clear where terms are defined. A reader who does not know
> T-PE
> will not be pointed to a document that defines 'Terminating Provider
> Edge Node of MS-PW'. I usally find terminology sections more useful
> if
> they say where definitions of terms get be found.
>
> Section 3: s/the the/the/
>
> Section 4: What is the 'Version' field in the message format?
>
> Section 4: There is an 8-bit field marked U C Flags and I _assume_
> the
> U and C bits are the 'first' two bits and the 'remaining bits are the
> flags managed by IANA. Perhaps make this clearer, e.g.:
>
>    +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>    |  Last Received Seq Number     | Message Type  |U|C|   Flags   |
>    +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>
> Or alternatively simply name the entire 8-bit flags field like you do
> in the text where you refer to Message Flags and then explain in the
> text under the 'Message Flags' that the first two bits have a fixed
> meaning.
>
>    +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>    |  Last Received Seq Number     | Message Type  | Message Flags |
>    +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>
> This option carries less information but then you use 'Message Flags'
> in several places and you also request an IANA registry for Message
> Flags where the U and C bit are allocated. Looking at the IANA text,
> it says 'bit position' 0 and 1. Not sure this is clear enough, you
> seem to number bits in the order 0, 1, 2, ...
>
> It turns out we have several slightly different labels further down
> in
> the document for this flags field throughout the document - this
> makes
> searching in the text difficult, please use a single consistent name
> for this message field.
>
> Section 8.2 says values 1 and 2 are defined in this document but then
> it seems value 3 is also allocated, no?
>
> Subsections of section 8 switches several times between decimal and
> hexadecimal numbers. Perhaps things get clearer if a single number
> system (e.g., hexadecimal) is used when talking about a specific
> registry. Numbers like 134,217,728 look somewhat confusing, 0x8000000
> seems simpler.
>
>
>