RE: Review of draft-ietf-curdle-dnskey-eddsa-02

Daniel Migault <daniel.migault@ericsson.com> Mon, 12 December 2016 07:36 UTC

Return-Path: <daniel.migault@ericsson.com>
X-Original-To: ietf@ietfa.amsl.com
Delivered-To: ietf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AC14F12956C; Sun, 11 Dec 2016 23:36:49 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.202
X-Spam-Level:
X-Spam-Status: No, score=-4.202 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1rCkF2MLbZzY; Sun, 11 Dec 2016 23:36:47 -0800 (PST)
Received: from usplmg20.ericsson.net (usplmg20.ericsson.net [198.24.6.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7FFFC12957F; Sun, 11 Dec 2016 23:36:44 -0800 (PST)
X-AuditID: c618062d-ab7ff70000007359-21-584e58d4720e
Received: from EUSAAHC001.ericsson.se (Unknown_Domain [147.117.188.75]) by (Symantec Mail Security) with SMTP id 8A.D7.29529.4D85E485; Mon, 12 Dec 2016 08:59:19 +0100 (CET)
Received: from EUSAAMB107.ericsson.se ([147.117.188.124]) by EUSAAHC001.ericsson.se ([147.117.188.75]) with mapi id 14.03.0319.002; Mon, 12 Dec 2016 02:36:40 -0500
From: Daniel Migault <daniel.migault@ericsson.com>
To: Dan Romascanu <dromasca@gmail.com>, "gen-art@ietf.org" <gen-art@ietf.org>
Subject: RE: Review of draft-ietf-curdle-dnskey-eddsa-02
Thread-Topic: Review of draft-ietf-curdle-dnskey-eddsa-02
Thread-Index: AQHSU6C4i+rMO9ocBUWkxf9EcksFjKED7ZgQ
Date: Mon, 12 Dec 2016 07:36:39 +0000
Message-ID: <2DD56D786E600F45AC6BDE7DA4E8A8C117FF1023@eusaamb107.ericsson.se>
References: <148145528503.29942.6087808105717521379.idtracker@ietfa.amsl.com>
In-Reply-To: <148145528503.29942.6087808105717521379.idtracker@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [147.117.188.11]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrNLMWRmVeSWpSXmKPExsUyuXSPt+71CL8Ig/2HTCy2LpzFbLFo91pm i8bHWhZXX31msXi2cT6LA6vHzll32T2WLPnJFMAUxWWTkpqTWZZapG+XwJWxbu9VxoJzHBVf H+9lbmDcwNHFyMkhIWAiMffIFzYQW0hgPaPEi76kLkYuIHs5o8SsDW/BEmwCRhJth/rZQWwR AV+J66cnsYMUMQusZJT49e03WJGwgIXEr/l3oYosJf6emQ0U5wCyjSTWtUqBhFkEVCWOHl7A CmLzAs15v30zM8RiX4nPb16wgNicAn4SS3ZvBqthFBCT+H5qDROIzSwgLnHryXwmiKMFJJbs Oc8MYYtKvHz8jxXCVpL4+Hs+O8haZgFNifW79CFaFSWmdD9kh1grKHFy5hOWCYyis5BMnYXQ MQtJxywkHQsYWVYxcpQWF+TkphsZbGIERskxCTbdHYz3p3seYhTgYFTi4f2Q6RshxJpYVlyZ e4hRgoNZSYR3T5BfhBBvSmJlVWpRfnxRaU5q8SFGaQ4WJXHeuNX3w4UE0hNLUrNTUwtSi2Cy TBycUg2MzGq3unu+ZrxKuZeg+sRH8WRW1eXXey5eUjELnlYy6WFuQ5b9ga0WQvE6WnP+qVl8 ZDhyeUVow7v2/dzxryymTH2z4drEL/KV84OLTkacOuL20/fLlg3nGEJ3M30uYukNsyjQqrnz cePL1+92Z3/Xv7njYsxclb/swldYTB8sVxPzXiRc/udeqBJLcUaioRZzUXEiAGa74wWOAgAA
Archived-At: <https://mailarchive.ietf.org/arch/msg/ietf/Gf1RLMr3IAP9PPLrCtfOsmLupVY>
Cc: "draft-ietf-curdle-dnskey-eddsa.all@ietf.org" <draft-ietf-curdle-dnskey-eddsa.all@ietf.org>, "curdle@ietf.org" <curdle@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ietf/>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Dec 2016 07:36:50 -0000

Thanks Dan for the review. 

Yours, 
Daniel

-----Original Message-----
From: Dan Romascanu [mailto:dromasca@gmail.com] 
Sent: Sunday, December 11, 2016 12:21 PM
To: gen-art@ietf.org
Cc: draft-ietf-curdle-dnskey-eddsa.all@ietf.org; curdle@ietf.org; ietf@ietf.org
Subject: Review of draft-ietf-curdle-dnskey-eddsa-02

Reviewer: Dan Romascanu
Review result: Ready with Nits

Summary: Ready, with nits

I am not an expert in this field, but the document seems to meet its goals, it's clear and precise

Major issues:

Minor issues:

Nits/editorial comments:

1. Section 4: s/Section5.1.7/Sections 5.1.7/

2. Section 8: 'The following entry has been added to
   the registry' - I may be wrong, but the section seems to define two new entries in the registry rather than one