Re: Review of draft-ietf-teas-gmpls-resource-sharing-proc-07

"Rakesh Gandhi (rgandhi)" <rgandhi@cisco.com> Thu, 26 January 2017 14:05 UTC

Return-Path: <rgandhi@cisco.com>
X-Original-To: ietf@ietfa.amsl.com
Delivered-To: ietf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 023DD1295CF; Thu, 26 Jan 2017 06:05:43 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -17.709
X-Spam-Level:
X-Spam-Status: No, score=-17.709 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-3.199, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_HTML_ATTACH=0.01, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zmRsA2b3hW8q; Thu, 26 Jan 2017 06:05:40 -0800 (PST)
Received: from alln-iport-3.cisco.com (alln-iport-3.cisco.com [173.37.142.90]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7C39D1295D6; Thu, 26 Jan 2017 06:05:40 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=79446; q=dns/txt; s=iport; t=1485439540; x=1486649140; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=E+aRxipe1XHLjEPCoWuHA4kmSYVQ3+Pp/BtF2UZQtxo=; b=Je/GVobrbClneTeOSNDT0FVWEaGQBQPMw7AyvUimMuYFa4daBhB/dnu4 SvsaJpU/1OLeRQbEAAwPZxEnHq/eBcXFLgQhPOUbYwYUUJokoQwk2Aqw5 sOVkIVF1QUPyhPNgrXPLK9tllgKsUiGvpCjpSkfj5kgSpZ/6UFRKRIvQw 0=;
X-Files: Diff_ draft-ietf-teas-gmpls-resource-sharing-proc-07.txt - draft-ietf-teas-gmpls-resource-sharing-proc-08.html : 53729
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0BjAQAmAYpY/5BdJa1UChkBAQEBAQEBA?= =?us-ascii?q?QEBAQcBAQEBAYMoDQEBAQEBH2GBCQeDToIGiAORYx+VLoINLIQcgVoCGoIFPxg?= =?us-ascii?q?BAgEBAQEBAQFiKIRqBhoJCkwQAgEIFCQBCQICAjAlAgQBDQUOiVMOrhWCJYpyA?= =?us-ascii?q?QEBAQEBAQEBAQEBAQEBAQEBAQEBDg+GS4IFCIJigwyBDwYLASMHCQkYgk4ugjE?= =?us-ascii?q?Fl2WDawGDbIJ4ixGBd1OEP4loiCSKVgEfOHZVFUsBg3OCNXUBhkqBIYENAQEB?=
X-IronPort-AV: E=Sophos;i="5.33,289,1477958400"; d="html'217?scan'217,208,217";a="376842861"
Received: from rcdn-core-8.cisco.com ([173.37.93.144]) by alln-iport-3.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jan 2017 14:05:38 +0000
Received: from XCH-ALN-016.cisco.com (xch-aln-016.cisco.com [173.36.7.26]) by rcdn-core-8.cisco.com (8.14.5/8.14.5) with ESMTP id v0QE5c4H030661 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Thu, 26 Jan 2017 14:05:38 GMT
Received: from xch-aln-018.cisco.com (173.36.7.28) by XCH-ALN-016.cisco.com (173.36.7.26) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Thu, 26 Jan 2017 08:05:37 -0600
Received: from xch-aln-018.cisco.com ([173.36.7.28]) by XCH-ALN-018.cisco.com ([173.36.7.28]) with mapi id 15.00.1210.000; Thu, 26 Jan 2017 08:05:37 -0600
From: "Rakesh Gandhi (rgandhi)" <rgandhi@cisco.com>
To: Dale Worley <worley@ariadne.com>, "gen-art@ietf.org" <gen-art@ietf.org>
Subject: Re: Review of draft-ietf-teas-gmpls-resource-sharing-proc-07
Thread-Topic: Review of draft-ietf-teas-gmpls-resource-sharing-proc-07
Thread-Index: AQHSdbz3neBdDdbGgkq0vqdxReRQJqFK39EA
Date: Thu, 26 Jan 2017 14:05:37 +0000
Message-ID: <92179CBF-6182-4A1C-8DCB-53EB1099D7DA@cisco.com>
References: <148520575728.29440.1145810018959016669.idtracker@ietfa.amsl.com>
In-Reply-To: <148520575728.29440.1145810018959016669.idtracker@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/f.1d.0.161209
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.86.242.154]
Content-Type: multipart/mixed; boundary="_002_92179CBF61824A1C8DCB53EB1099D7DAciscocom_"
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/ietf/Gtp4wXzjJXlEJbwn-WjPbn31uVo>
Cc: "draft-ietf-teas-gmpls-resource-sharing-proc.all@ietf.org" <draft-ietf-teas-gmpls-resource-sharing-proc.all@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "teas@ietf.org" <teas@ietf.org>
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ietf/>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Jan 2017 14:05:43 -0000

Thank you Dale for the thorough review of the document. Please see the attached diff file with the changes.

Please see inline for the replies <RG> ..

On 2017-01-23, 4:09 PM, "Dale Worley" <worley@ariadne.com> wrote:

    Reviewer: Dale Worley
    Review result: Ready with Nits
    
    I am the assigned Gen-ART reviewer for this draft.  The General Area
    Review Team (Gen-ART) reviews all IETF documents being processed by
    the IESG for the IETF Chair.  Please wait for direction from your
    document shepherd or AD before posting a new version of the draft.
    
    For more information, please see the FAQ at
    <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
    
    Document:  draft-ietf-teas-gmpls-resource-sharing-proc-07
    Reviewer:  Dale R. Worley
    Review Date:  23 Jan 2017
    IETF LC End Date:  17 Jan 2017
    IESG Telechat date:  2 Feb 2017
    
    Summary:
    
           This draft is basically ready for publication, but has nits
           that should be fixed before publication.
    
    There remain a few editorial items:
    
    2. Conventions Used in This Document	
    		
        The reader is assumed to be familiar with the terminology in	
        [RFC3209], [RFC3473], [RFC4872], [RFC4873] and [RFC4427].	
    		
    That is a significant help to the reader, but it's also rather
    intimidating!  Is there a way to point out that 4427 is specific to
    recovery?

<RG> Yes, added.    


    3.1.1.  1+R Restoration
    
       Unlike a protecting LSP which is set up before the failure, a
       restoration LSP is set up per need basis, after the failure.
    
    Probably better to change "per need basis" to "when needed".

<RG> Yes, edited.

    
    3.2. Resource Sharing By Restoration LSP	
    			
    "By" generally should not be capitalized in titles, as it is a
    preposition.

<RG> Edited.
    
                                   +-----+      +-----+
                                   |  F  +------+  G  +--------+
                                   +--+--+      +-----+        |
                                      |                        |
                                      |                        |
            +-----+    +-----+     +--+--+      +-----+     +--+--+
            |  A  +----+  B  +-----+  C  +--X---+  D  +-----+  E  |
            +-----+    +-----+     +-----+      +-----+     +-----+
    
              Figure 3: Resource Sharing in 1+R Recovery Scheme
    
    
       [...]  Nodes A and B
       reconfigure the resources to set up the restoration LSP by sending
       cross-connection command to the data plane.
    
       In the recovery scheme employing revertive behavior, after the
       failure is repaired, the resources on nodes A and B need to be
       reconfigured to set up the working LSP.  The traffic is then
    reverted
       back to the original working LSP.  
    
    It's not clear to me why nodes A and B are reconfigured and/or do the
    reconfiguring.  Any "global" reconfiguring would be driven by the
    head-end A alone, I think.  Any "local" reconfiguring would be done
    by
    C and possibly E.  Though perhaps there is reconfiguring that must be
    done along the entire path, but that would be attributed to A, B, C,
    F, G, and E together.  I suspect there is a trivial editorial error
    here...
    
<RG> Corrected the text. I made an error in the last update when addressing your comment.

Thanks,
Rakesh (for authors and contributors)



    [END]