Review of draft-ietf-curdle-dnskey-eddsa-02

Dan Romascanu <dromasca@gmail.com> Sun, 11 December 2016 11:21 UTC

Return-Path: <dromasca@gmail.com>
X-Original-To: ietf@ietf.org
Delivered-To: ietf@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 0952D1296F6; Sun, 11 Dec 2016 03:21:25 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Dan Romascanu <dromasca@gmail.com>
To: <gen-art@ietf.org>
Subject: Review of draft-ietf-curdle-dnskey-eddsa-02
X-Test-IDTracker: no
X-IETF-IDTracker: 6.39.1
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <148145528503.29942.6087808105717521379.idtracker@ietfa.amsl.com>
Date: Sun, 11 Dec 2016 03:21:25 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/ietf/H-b93uDJqkxIIufFRQn67clj9RE>
Cc: draft-ietf-curdle-dnskey-eddsa.all@ietf.org, curdle@ietf.org, ietf@ietf.org
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.17
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ietf/>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 11 Dec 2016 11:21:25 -0000

Reviewer: Dan Romascanu
Review result: Ready with Nits

Summary: Ready, with nits

I am not an expert in this field, but the document seems to meet its
goals, it's clear and precise

Major issues:

Minor issues:

Nits/editorial comments:

1. Section 4: s/Section5.1.7/Sections 5.1.7/

2. Section 8: 'The following entry has been added to
   the registry' - I may be wrong, but the section seems to define two
new entries in the registry rather than one