RE: Review of draft-ietf-softwire-multicast-prefix-option-11

<mohamed.boucadair@orange.com> Tue, 10 January 2017 06:44 UTC

Return-Path: <mohamed.boucadair@orange.com>
X-Original-To: ietf@ietfa.amsl.com
Delivered-To: ietf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 26F17120725; Mon, 9 Jan 2017 22:44:02 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.118
X-Spam-Level:
X-Spam-Status: No, score=-5.118 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-3.199, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uiOVDIW_kZuY; Mon, 9 Jan 2017 22:44:01 -0800 (PST)
Received: from relais-inet.orange.com (mta239.mail.business.static.orange.com [80.12.66.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3A1FF1294DA; Mon, 9 Jan 2017 22:43:59 -0800 (PST)
Received: from opfedar01.francetelecom.fr (unknown [xx.xx.xx.2]) by opfedar20.francetelecom.fr (ESMTP service) with ESMTP id EC95B12097D; Tue, 10 Jan 2017 07:43:57 +0100 (CET)
Received: from Exchangemail-eme2.itn.ftgroup (unknown [xx.xx.31.60]) by opfedar01.francetelecom.fr (ESMTP service) with ESMTP id CD7D816005E; Tue, 10 Jan 2017 07:43:57 +0100 (CET)
Received: from OPEXCLILMA3.corporate.adroot.infra.ftgroup ([fe80::60a9:abc3:86e6:2541]) by OPEXCLILM7F.corporate.adroot.infra.ftgroup ([fe80::c1d7:e278:e357:11ad%19]) with mapi id 14.03.0319.002; Tue, 10 Jan 2017 07:43:57 +0100
From: mohamed.boucadair@orange.com
To: Sheng Jiang <jiangsheng@huawei.com>, "ops-dir@ietf.org" <ops-dir@ietf.org>
Subject: RE: Review of draft-ietf-softwire-multicast-prefix-option-11
Thread-Topic: Review of draft-ietf-softwire-multicast-prefix-option-11
Thread-Index: AQHSavVTVnFTRVjfwk6X5cBQPk1w3KExQLPw
Date: Tue, 10 Jan 2017 06:43:56 +0000
Message-ID: <787AE7BB302AE849A7480A190F8B933009DE2269@OPEXCLILMA3.corporate.adroot.infra.ftgroup>
References: <148402050186.25046.4223816824977657511.idtracker@ietfa.amsl.com>
In-Reply-To: <148402050186.25046.4223816824977657511.idtracker@ietfa.amsl.com>
Accept-Language: fr-FR, en-US
Content-Language: fr-FR
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.168.234.5]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/ietf/JJZxpzEtzYOk6Tx7O5SN2Yq3eyw>
Cc: "softwires@ietf.org" <softwires@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "draft-ietf-softwire-multicast-prefix-option.all@ietf.org" <draft-ietf-softwire-multicast-prefix-option.all@ietf.org>
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ietf/>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Jan 2017 06:44:02 -0000

Hi Sheng, 

Thank you for the review. 

Please see inline. 

Cheers,
Med

> -----Message d'origine-----
> De : Sheng Jiang [mailto:jiangsheng@huawei.com]
> Envoyé : mardi 10 janvier 2017 04:55
> À : ops-dir@ietf.org
> Cc : softwires@ietf.org; ietf@ietf.org; draft-ietf-softwire-multicast-
> prefix-option.all@ietf.org
> Objet : Review of draft-ietf-softwire-multicast-prefix-option-11
> 
> Reviewer: Sheng Jiang
> Review result: Has Nits
> 
> Summary: This draft is almost ready for publication as a standard
> track RFC.
> 
> Major issues:
> 
> Minor issues:
> 
> “the specification of a DHCPv6 option that could be used to discover
>    unicast PREFIX64s in environments where multicast is not enabled.
>    Such side effect conflicts with the recommendation documented in
>    Section 6 of [RFC7051].”
> 
> It is unclear how the Section 6 of RFC7051 relevant with the content
> above. It would be necessary to quote particular content of RFC7051
> and give necessary analysis.
> 

[Med] What about:  

OLD: 

   Note that it was tempting to define three distinct DHCPv6 options,
   but that approach was not adopted because it has a side effect: the
   specification of a DHCPv6 option that could be used to discover
   unicast PREFIX64s in environments where multicast is not enabled.
   Such side effect conflicts with the recommendation documented in
   Section 6 of [RFC7051].

NEW: 
   Note that it was tempting to define three distinct DHCPv6 options,
   but that approach was not adopted because it has a side effect: the
   specification of a DHCPv6 option that could be used to discover
   unicast PREFIX64s in environments where multicast is not enabled.
   Such side effect conflicts with the recommendation documented in
   Section 6 of [RFC7051]. As a reminder, that recommendation is to
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   to support the Well-Known DNS Name heuristic discovery-based method
   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   for unicast-only environments.
   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 

Better?

> Nits:
> 
> “the Pv4 multicast address is inserted in the last 32 bits of the
> IPv4-embedded IPv6
>    multicast address.”
> 
> Pv4//IPv4
[Med] Fixed.