Re: [Tzdist-bis] Last Call: <draft-murchison-tzdist-tzif-13.txt> (The Time Zone Information Format (TZif)) to Proposed Standard

Paul Eggert <eggert@cs.ucla.edu> Thu, 13 September 2018 18:32 UTC

Return-Path: <eggert@cs.ucla.edu>
X-Original-To: ietf@ietfa.amsl.com
Delivered-To: ietf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D7628130F93; Thu, 13 Sep 2018 11:32:25 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.201
X-Spam-Level:
X-Spam-Status: No, score=-4.201 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QM8m2_sj0GI9; Thu, 13 Sep 2018 11:32:23 -0700 (PDT)
Received: from zimbra.cs.ucla.edu (zimbra.cs.ucla.edu [131.179.128.68]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CF797130F0F; Thu, 13 Sep 2018 11:32:23 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 991981616C5; Thu, 13 Sep 2018 11:32:23 -0700 (PDT)
Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id EzRftbWx34uJ; Thu, 13 Sep 2018 11:32:22 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id ADDD11616C2; Thu, 13 Sep 2018 11:32:22 -0700 (PDT)
X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu
Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id wCIfeozDcaEI; Thu, 13 Sep 2018 11:32:22 -0700 (PDT)
Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 6EF1A1616BF; Thu, 13 Sep 2018 11:32:22 -0700 (PDT)
Subject: Re: [Tzdist-bis] Last Call: <draft-murchison-tzdist-tzif-13.txt> (The Time Zone Information Format (TZif)) to Proposed Standard
To: tom petch <daedulus@btconnect.com>, ietf <ietf@ietf.org>
Cc: "alexey.melnikov@isode.com" <alexey.melnikov@isode.com>, "lear@ofcourseimright.com" <lear@ofcourseimright.com>, "tzdist-bis@ietf.org" <tzdist-bis@ietf.org>, "draft-murchison-tzdist-tzif@ietf.org" <draft-murchison-tzdist-tzif@ietf.org>, Ken Murchison <murch@fastmail.com>
References: <153668132581.16924.5079239635019957388.idtracker@ietfa.amsl.com> <054601d44b58$80fc2340$4001a8c0@gateway.2wire.net>
From: Paul Eggert <eggert@cs.ucla.edu>
Organization: UCLA Computer Science Department
Message-ID: <b2e98de8-4024-bf84-c57d-8fde8e3c84ee@cs.ucla.edu>
Date: Thu, 13 Sep 2018 11:32:18 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <054601d44b58$80fc2340$4001a8c0@gateway.2wire.net>
Content-Type: multipart/mixed; boundary="------------1E801D14422EC771DD3E7169"
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/ietf/JiNJsj19kL7weCkra9eZaNj2VNE>
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ietf/>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Sep 2018 18:32:32 -0000

tom petch wrote:
> I would expect the
> index to be
> [0, 'typecnt'-1)
> or
> [1, 'typecnt')
> but not
> [0, 'typecnt')
> as the I-D says, unless zero has a special meaning but then it is not
> really an index.

Alhough the [lo, hi) notation is well-established (as Tim Parenti mentioned), it 
wouldn't hurt to reword this to [0, 'typecnt'-1] to avoid the confusion you ran 
into.
> I infer, and would rather be told explicitly, that
> "The total number of octets is specified by the 'charcnt' field ..
> excludes the NUL that terminates the list.

charcnt includes the NUL; it does not exclude it. Since you inferred otherwise 
we should make this explicit. Also, come to think of it, we should say that 
charcnt MUST NOT be zero, as this constraint (which is a logical implication of 
the already-documented constraint that typecnt must not be zero) will help avoid 
further confusion in this area.
> In s.1,
> "the source the time zone data  metadata, identifiers, ..."
> would appear to be light of an 'of'.

Thanks, good catch.

Proposed patch attached. It attempts to address all the above issues.