Re: Gen-ART LC review of draft-ietf-isis-node-admin-tag-08

Pushpasis Sarkar <pushpasis.ietf@gmail.com> Mon, 02 May 2016 17:34 UTC

Return-Path: <pushpasis.ietf@gmail.com>
X-Original-To: ietf@ietfa.amsl.com
Delivered-To: ietf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 585F812D5B6; Mon, 2 May 2016 10:34:43 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0YKPLWd3fiR8; Mon, 2 May 2016 10:34:41 -0700 (PDT)
Received: from mail-pf0-x231.google.com (mail-pf0-x231.google.com [IPv6:2607:f8b0:400e:c00::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3A29B12D126; Mon, 2 May 2016 10:34:41 -0700 (PDT)
Received: by mail-pf0-x231.google.com with SMTP id y69so81261805pfb.1; Mon, 02 May 2016 10:34:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=YQKbLM0yJBz0pzMXRg9VEURdyNLQRI81aEdGZJfuh5E=; b=OicT/c9VwZS+aeJ+ggHWHRRleFlX1aKgWJA6ewVn3NP7jH3SIIpWuurerpJiZMtc5R 1X3VOZFdpMIq3B1dqacW32qpqrBJuruk9+Gwnb4o9grNmZhIhyuP6F3KzSgU5M3i6aoo d8HZeJuk3jVSAHJ6bcNhHzPKeEbIBg4boMuDznvHsXK1o6p+NrutYITjTEABfccRRRp4 9DXGvxzojMouGORUdeUF6IPCE6fhPBS3U/ktE2KDG3rQiVN9V4mQbWT0toyOYDh4cXd+ E+y+MgBgiTgJQX1nT/sQuxKAJTvcbl8VC5Wjjy6VQrcTMGWA9Q5mVsyPMI/kdyHGfzBz MVRg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=YQKbLM0yJBz0pzMXRg9VEURdyNLQRI81aEdGZJfuh5E=; b=l+XLHQ8n19c4g2dqKedj6HLQQsaedNoqJgYtAVDR4VRq3pAOmqRBiOu3erOMZi+CYt 3i4bDrFcR6KcZPnEmVrnjCfauWnl7d+Ps5o2bpOXIcOlZfgFaP5e89uyvo4AB3x9ChDF P3Hlpm6/n8EZQhb7Yn767uc15lGyZZt386zU6Bdp8B6Yw9VyV422uybLtIAO/9zVTBou taubweFZV+XRJn54tIZMQQ6C9qgPn3pbJ9yqj1TKPoGjl6FHMgb7YbL+BzZStozIS/xW eQKijaWT1AViJMWQrlf9IZqW0pvY6TywtYqOCYgSD0dATCHLHoxjO++L7u/N2ZlMkVP1 f1qw==
X-Gm-Message-State: AOPr4FW9ITPtDaZv51ioZdbXx3Np/7cUiPa9lgbSfWIdYYf1qZEP29OdPgS7PYvsGI5jcQ==
X-Received: by 10.98.51.132 with SMTP id z126mr52636389pfz.23.1462210480824; Mon, 02 May 2016 10:34:40 -0700 (PDT)
Received: from Pushpasiss-MacBook-Pro.local ([122.172.248.193]) by smtp.gmail.com with ESMTPSA id y3sm54013678par.2.2016.05.02.10.34.38 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 02 May 2016 10:34:40 -0700 (PDT)
Subject: Re: Gen-ART LC review of draft-ietf-isis-node-admin-tag-08
To: Peter Yee <peter@akayla.com>, draft-ietf-isis-node-admin-tag.all@ietf.org
References: <00ef01d1a2bc$1e6a0130$5b3e0390$@akayla.com>
From: Pushpasis Sarkar <pushpasis.ietf@gmail.com>
Message-ID: <57278FB0.9090901@gmail.com>
Date: Mon, 2 May 2016 23:04:40 +0530
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <00ef01d1a2bc$1e6a0130$5b3e0390$@akayla.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <http://mailarchive.ietf.org/arch/msg/ietf/JkAtYkBTzFXrojS2hKbMvgJ_wa4>
Cc: gen-art@ietf.org, ietf@ietf.org
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ietf/>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 02 May 2016 17:34:43 -0000

Hi Peter,

Once again many many thanks for the detailed review comments. Please 
find few comments inline. Unless otherwise there is a counter-comment 
the comment is accepted and will be addressed in the next version to be 
uploaded soon.

Thanks and Regards,
-Pushpasis

On 4/30/16 2:11 PM, Peter Yee wrote:
> I am the assigned Gen-ART reviewer for this draft.  The General Area Review
> Team (Gen-ART) reviews all IETF documents being processed by the IESG for
> the IETF Chair.  Please treat these comments just like any other last call
> comment.  For background on Gen-ART, please see the FAQ at
> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>
>
> Document: draft-ietf-isis-node-admin-tag-08
> Reviewer: Peter Yee
> Review Date: April 27, 2016
> IETF LC End Date: April 29, 2016
> IESG Telechat date: May 5, 2016
>
> Summary: This draft is basically ready for publication as a Standards Track
> RFC, but has some issues that should be fixed/considered before publication.
> [Ready with issues]
>
> This draft defines a means to carry additional per-node administrative tags
> with the IS-IS protocol.  These tags can be used along with local policy to
> simplify the management of routing and path selection.  This specification
> gives informative examples of such tag usage but does not otherwise
> prescribe the meaning of the tags.
>
> This review was generated prior to the release of draft -09 (but not keyed
> in until April 29th), but many of the issues and nits noted below remain in
> draft -09.  Obviously, some of my comments no longer apply.  I'll address
> draft -09 specifically for the telechat review, but you should look at the
> points here prior to that review to save time.  Given that draft -09
> substantially reduces Section 5, I've removed my comments regarding that
> section as well as in a few other places.
>
> Major issues: None
>
> Minor issues:
>
> Page 4, last partial paragraph: the number 63 is given for the maximum
> number of per-node administrative tags that can be carried in a sub-TLV.
> Given the maximum length of a sub-TLV is 250 octets (and 2 octets are
> otherwise used by type and length), I would argue that the correct number
> here is 62 (62*4 = 248).  Also, I would delete the text starting at "and".
> In all cases, when more than 62 tags are used, a single sub-TLV will not
> provide sufficient space.
[Pushpasis] AFAIK, maximum length of sub-TLV is 255 (because length 
field if 1 byte). If you take out 2 bytes for length and value, we have 
253 bytes left.. 253 divided by 4byte = 63 (63x4=252).. Let me know if 
my understanding is wrong.
>
> Page 5, 1st partial paragraph, 1st full sentence: Sub-TLV values are given
> here as cumulative.  Is there any need or desire to be able to subtract
> tags?  How would a router disassociate itself from a tag that was no longer
> relevant to the router?  This ability is implied in Section 4.3, 2nd
> paragraph, but that conflicts with the statement given here.  In general, I
> believe the ability to reset the flooded tags associated with a router or to
> delete a tag is underspecified.
[Pushpasis] Assuming the comment is on the following sentence..
"Such occurrence of the 'Node
    Administrative Tag' sub-TLV does not cancel previous announcements,
    but rather is cumulative."

The reference here to "previous announcements" is not the ones received 
in the previous instances of the same LSP fragment but to the ones 
received in other TLVs in same or different LSP fragments originated by 
the same router... What it essentially mean is that if a router 
originates 3 node-admin-tag TLVs in three different LSP fragments.. the 
later ones do not cancel/override the previous ones but are rather 
considered all together.. in an additive manner.. Perhaps I will add a 
line or two clarify the same.. I also see RFC7777 has altogether removed 
the stanza in the final RFC edition.. Will that be fine too with you for 
this draft?

Alternatively, I can propose the following clarifying text... If it 
makes any sense to you :)

"Such occurrence of a
     'Node Administrative Tag' sub-TLV, found in a LSP fragment received 
recently, does not cancel
     the one(s) received in any recent versions of other LSP fragments 
originated by the same
     router. Instead, all the 'Node Administrative Tag' sub-TLVs found 
in all the LSP fragments
     originated by the same originating router, should be treated as 
cumulative."

>
> Page 6, 1st partial paragraph, 1st sentence: Care to define "reasonably
> small"?  Previously, the ability to send more than 63 (or perhaps 62, see
> above) tags was specified in section 3.1.  What's the limit to
> reasonableness?  (Not that an exact number seems to matter at all for the
> purposes of this specification, which is agnostic to the specific number or
> the use of the tags.)
[Pushpasis] I see the only way to resolve this comment is by removing 
the stanza being referred to in the last comment..
>
> Page 6, Section 4.3, 2nd paragraph: This paragraph implies that a large set
> (greater than 62 at least) of sub-TLVs will have to be sent in multiple
> Router CAPABILITY TLVs and those TLVs must(?) occur in a single Link-State
> PDU.  Or how is the receiving router to know that it has the complete set of
> tags?  Also, the implication seems to be that while section 3.1 indicates a
> strictly cumulative capability, there must be someway of terminating those
> cumulative changes and allowing a reset.  What is that signaling mechanism?
[Pushpasis] This is dealt with ISIS LSP fragment generation and 
reception.. A typical ISIS implementation will be able to figure out any 
given point whether it has received all the fragments originated by a 
originating router or not. Please refer to ISO-10589 for more details.. 
There are no extra requirements imposed by this draft in this regard.
>
> Nits:
>
> General:
>
> The use of capitalization of Per-node administrative tag varies throughout
> the document.  It seems clear that you mean for it to be written as
> "Per-node Administrative Tag" when referring to the name of sub-TLV.  For
> other uses, I would suggest using "per-node administrative tag"
> consistently.  Use that to replace "Per-node administrative tag".
>
> Separate parenthetical elements from the preceding and following words with
> a space.  These aren't function calls. ;-)
>
> Replace any use of "per-node admin tag" with "per-node administrative tag".
> The shortening is fine for the document header which would otherwise become
> unreadable.
>
> And change all of my references to "per-node" to "node", since draft -09
> drops the "per-". :-)
>
> Replace "TLV 242" with "the Router CAPABILITY TLV".
>
> Specific:
>
>   Page 1, Abstract:  delete the first comma in the Abstract.
>
> Page 3, first paragraph after the lettered items, 3rd sentence: insert "the"
> before "Router".
>
> Page 3, Section 2, 1st sentence: change "Tag" to "tag".
>
> Page 3, Section 2, 3rd sentence: insert "a" before "certain".
>
> Page  3, Section 3, 1st paragraph, 1st sentence: change "TLV-242" to "TLV
> (IS-IS TLV type 242)" and delete the closing parenthesis after "[RFC4971".
>
> Page 3, Section 3, 1st paragraph, 3rd sentence: change "the same" to "it".
> Change "they" to "it".  Change "specfied" to "specified".  Insert "the"
> before "originating".  Delete "the" before "other".
>
> Page 3, Section 3, 1st paragraph, 5th sentence: change "are" to "is".
>
> Page 3, Section 3, 1st paragraph, 6th sentence: delete the comma.
>
> Page 3, Section 3, 1st paragraph, 7th sentence: change "Operator" to "The
> operator".
>
> Page 4, Section 3, last paragraph, 1st sentence: insert "the" before
> "Per-node" (after having changed "per-node" to "Per-node").
>
> Page 4, Section 3, last paragraph, 2nd sentence: change "topology specific"
> to "topology-specific".
>
> Page 4, Section 3.1, 1st paragraph, 1st sentence: change "ISIS" to "IS-IS".
>
> Page 4, Section 3.1, Length definition: change "A" to "An".
>
> Page 4, Section 3.1, Value definition: change "sequence" to "set".  Sequence
> would seem to imply order which is contradicted by Section 4.1.  Change "4
> octets" to "4-octet values".
>
> Page 5, 1st partial paragraph, 1st full sentence: append a comma after
> "such" and insert "each" before "occurrence".
>
> Page 5, Section 4.1, 1st paragraph, 1st sentence: change "Meaning" to "The
> meaning".
>
> Page 5, Section 4.1, 1st paragraph, 2nd sentence: change "Router" to "A
> router".
>
> Page 5, Section 4.1, 2nd paragraph, last sentence: append a comma after
> "change".
>
> Page 5, Section 4.1, 4th paragraph, 2nd sentence: delete "The".  Change
> "TLVs" to "sub-TLVs".  Change "adminsitrative" to "administrative".
>
> Page 5, Section 4.1, 4th paragraph: the paragraph, starting at "The list of
> per-node" is pretty much redundant given the admonition in the first
> sentence of the previous paragraph.  Perhaps delete it rather than belabor
> the point?
>
> Page 5, Section 4.1, 1st paragraph, 4th sentence: change "well known" to
> "well-known".  Change "capability" to "CAPABILITY".
>
> Page 6, 1st partial paragraph, 2nd sentence: insert "the" before
> "reachability".
>
> Page 6, Section 4.3, 1st paragraph, 1st sentence: delete "(TLV-242)".
>
> Page 6, Section 4.3, 1st paragraph, 3rd sentence: change "an" to "a".  Based
> on Section 3.1, I might change "changes" to "adds to" because Section 3.1
> specifies that sub-TLVs are cumulative.
>
> Page 10, Section 7, 1st paragraph, 3rd sentence: change "ISIS" to "IS-IS".
> Change "is" to "are".
>
> Page 10, Section 7, 2nd paragraph, 2nd sentence: insert "the" before "case".
> Insert "the" before "forwarding".  Insert a space before "and".
>
> Page 12, Section 8, 2nd sentence: insert "The" before "YANG".
>
> Page 12, Section 8, 3rd sentence: insert "The" before "IS-IS".  Insert "the"
> before "routing".
>
> Page 12, Section 9, item i): why is the sub-TLV name hyphenated here and not
> elsewhere?
>
> Page 12, Section 10: append a comma after "Chunduri".
>