Re: Gen-ART Telechat review of draft-ietf-isis-node-admin-tag-10

Pushpasis Sarkar <pushpasis.ietf@gmail.com> Thu, 05 May 2016 04:50 UTC

Return-Path: <pushpasis.ietf@gmail.com>
X-Original-To: ietf@ietfa.amsl.com
Delivered-To: ietf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 75BA112D517; Wed, 4 May 2016 21:50:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id thsUDh87P7do; Wed, 4 May 2016 21:50:42 -0700 (PDT)
Received: from mail-pf0-x231.google.com (mail-pf0-x231.google.com [IPv6:2607:f8b0:400e:c00::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6118A12B014; Wed, 4 May 2016 21:50:42 -0700 (PDT)
Received: by mail-pf0-x231.google.com with SMTP id 77so33114911pfv.2; Wed, 04 May 2016 21:50:42 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=g/3pMqRf7RsYSkRyN/fGznRabrHFLp0/7k+nFLjEUhY=; b=RfGs4s3FmrMgf6CTG2EXTzbvxVLrxExHwvPCXx3NmGAWfoOLqPNVtvoj342EEoGej2 DOgmuTgvIStd/bhQm4/ybUjPnij9vzkTSd31LBesZWK+4EW2rxbOfBnIojpEPjTfXFZ5 yB+TzYS17/DU5mX1GTuP7OulSNEZFHtqExlhLcqarVf+x78b7Vcr69HgPTW4OjuS655S B3oVBDOIVs0S71EJEiMzD/lEF09xQ4qWjpDYW/Q/cw5s6otWPguRXqryNqtRVqcSj9PX cafEU1uFDEO3M/XdqV+c4TXKoaFlb1duXhQT/uqiWLSQJkTzncURNKn3sYItF5Uwy/Yo qgfg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=g/3pMqRf7RsYSkRyN/fGznRabrHFLp0/7k+nFLjEUhY=; b=Xtm3sd2NlUfU+QuOeXoPeMnk6uJej+7bxeMGg47IPMXQ+EkAfjVt69bGbaUnJparTa ZEm8k3l7h40Vg6KMBsCM78H0BWQlNGFX+1eTMa93ewNgYbRSeK8KN4XwfeJWgZjBR9ds 3oanAOLAthfcx6/sj/bjANrXCxsmyIN2BmS6QQRSPEOaOU9VyvZ9TTGCQ/vaw+HBr490 4rfT6+ea8LeAU80+pUXKMKKnEb1z628l2cDCVs2RDNEHqPkPpg2PmfbTCjRemwwHYNmZ U9QwVnScflz0tq5g6Hqi9gum20An/of/YCGf4/Y8a7QpiH0zONDad51Rehbaq9Vofpjj lSjA==
X-Gm-Message-State: AOPr4FXoEdMOAjx13OVa8iOhIbNLebWxSfSSmD3Useyqr6FAfQjCExWofzCi17DB0suDzw==
X-Received: by 10.98.101.199 with SMTP id z190mr17651463pfb.1.1462423841656; Wed, 04 May 2016 21:50:41 -0700 (PDT)
Received: from Pushpasiss-MacBook-Pro.local ([122.171.166.12]) by smtp.gmail.com with ESMTPSA id q129sm9725450pfb.16.2016.05.04.21.50.39 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 04 May 2016 21:50:41 -0700 (PDT)
Subject: Re: Gen-ART Telechat review of draft-ietf-isis-node-admin-tag-10
To: Peter Yee <peter@akayla.com>, draft-ietf-isis-node-admin-tag.all@ietf.org
References: <027101d1a57f$25508a80$6ff19f80$@akayla.com>
From: Pushpasis Sarkar <pushpasis.ietf@gmail.com>
Message-ID: <572AD11D.3080500@gmail.com>
Date: Thu, 5 May 2016 10:20:37 +0530
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <027101d1a57f$25508a80$6ff19f80$@akayla.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <http://mailarchive.ietf.org/arch/msg/ietf/KMeoQ-UPD91YLGNIb2gv5otAx04>
Cc: gen-art@ietf.org, ietf@ietf.org
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ietf/>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 05 May 2016 04:50:44 -0000

Hi Peter,

Sorry for the late reply. Was not doing well..

Once again, thanks a lot for the detailed review comments. I will 
address them very soon..

Thanks
-Pushpasis



On 5/4/16 2:32 AM, Peter Yee wrote:
> I am the assigned Gen-ART reviewer for this draft. The General Area Review
> Team (Gen-ART) reviews all IETF documents being processed by the IESG for
> the IETF Chair. Please wait for direction from your document shepherd or AD
> before posting a new version of the draft.  For background on Gen-ART,
> please see the FAQ at
> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>
>
> Document: draft-ietf-isis-node-admin-tag-10
> Reviewer: Peter Yee
> Review Date: May 3, 2016
> IETF LC End Date: April 29, 2016
> IESG Telechat date: May 5, 2016
>
> Summary: This draft is basically ready for publication as a Standards Track
> RFC, but has an issue and some nits that should be fixed/considered before
> publication. [Ready with issues]
>
> This draft defines a means to carry additional per-node administrative tags
> with the IS-IS protocol.  These tags can be used along with local policy to
> simplify the management of routing and path selection.  This specification
> gives informative examples of such tag usage but does not otherwise
> prescribe the meaning of the tags.
>
> Major issues: None
>
> Minor issues:
>
> Page 5, section 4.2, 2nd paragraph, 1st sentence: The sentence states:
> "Being part of the Router CAPABILITY TLV, the node administrative tag
> sub-TLV MUST be reasonably small and stable."  If you're going to make this
> a MUST, you've got to at least give a definition of "reasonably small" and
> perhaps even "stable" in the context of this specification.  As it stands,
> there's no test for whether the MUST is enforceable or understandable
> between parties.
>
> Nits:
>
> General:
>
> The use of capitalization of Node administrative tag varies throughout the
> document.  It seems clear that you mean for it to be written as "Node
> Administrative Tag" when referring to the name of sub-TLV.  For other uses,
> I would suggest using "node administrative tag" (all lower case)
> consistently.  Use that to replace "Node administrative tag".
>
> Specific:
>
>   Page 3, 1st paragraph after the labeled items at the top, 3rd sentence:
> change the first "TLV" to "sub-TLV".
>
> Page 3, Section 2, 2nd paragraph: append a comma after "another".
>
> Page 3, Section 3, 1st paragraph, 1st sentence: change "a" before "IS-IS" to
> "an".
>
> Page 3, Section 3, 1st paragraph, 2nd sentence: change "Capablity" to
> "CAPABILITY".
>
> Page 3, Section 3, 1st paragraph, 3rd sentence: change "Operator" to "An
> operator".  Change "diiferent" to "different".
>
> Page 3, Section 3, 2nd paragraph, 1st sentence: insert "the" before "Node".
>
> Page 3, Section 3, 2nd paragraph, 2nd sentence: change "topology specific"
> to "topology-specific".  (That is to say, swap the space for a hyphen.)
>
> Page 4, Section 3.1, Value definition: insert "node" before
> "administrative".
>
> Page 4, Section 4.1, 1st sentence: change "Node" to "node".  (See general
> nit.)
>
> Page 4, Section 4.1, 3rd sentence: delete the space after the slash and
> before regulations.
>
> Page 5, 3rd full paragraph, 4th sentence: delete the spaces after closing
> parenthesis and the terminating period.
>
> Page 6, Section 4.3, 1st paragraph, 2nd sentence: change "Node" to "node".
> (See general nit.)  Change the first "TLVs" to "sub-TLVs".
>
> Page 6, Section 4.3, 2nd paragraph, 2nd sentence: delete the space before
> the comma.
>
> Page 6, Section 5, 1st paragraph, 1st sentence: change "Node" to "node".
> (See general nit.)
>
> Page 6, Section 5, 1st paragraph, 4th sentence: change "Following" to "The
> following".
>
> Page 6, Section 5, 1st paragraph, 5th sentence: change "section-3" to
> "section 3".
>
> Page 7, Section 6, 2nd paragraph, the comma should be rejoined with the
> closing parenthesis.
>
> Page 7, Section 7, 1st paragraph, 3rd sentence: change "is" to "are".
>
> Page 7, Section 8, 1st paragraph, 2nd sentence: delete "The" before "YANG".
> With the change in the rest of the sentence, "The" becomes superfluous.
>
> Page 8, Section 9: change "Capabality" to "CAPABILITY".
>