TSV-ART review of draft-ietf-rtcweb-transports

Allison Mankin <allison.mankin@gmail.com> Wed, 03 August 2016 14:00 UTC

Return-Path: <allison.mankin@gmail.com>
X-Original-To: ietf@ietfa.amsl.com
Delivered-To: ietf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C3D1612DD5C; Wed, 3 Aug 2016 07:00:34 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.699
X-Spam-Level:
X-Spam-Status: No, score=-2.699 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EVgMWgNVXPhy; Wed, 3 Aug 2016 07:00:32 -0700 (PDT)
Received: from mail-vk0-x22f.google.com (mail-vk0-x22f.google.com [IPv6:2607:f8b0:400c:c05::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1F38512D597; Wed, 3 Aug 2016 06:54:43 -0700 (PDT)
Received: by mail-vk0-x22f.google.com with SMTP id s189so146436158vkh.1; Wed, 03 Aug 2016 06:54:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to:cc; bh=9SqjeGhuAMJ7wuriZp/WbKbDUhlsgnuGgI1yveTFoKo=; b=szbQ/h9rI5UQbqIRteS3miFaurz5j4H03u3Se1eLOdYuiBzBgILAiNv3g9o5xFBf2l RIrZn2SMz5PWzEL9d3jyM2s+E36J3w7ue3Nc69GaxXsrdQ8qKoSiA0VCmW8cwmC1NQGQ fPznS1s3n5H3XtYXJgvyDeKWiCOiErtEbxFooIgK6Lm2DisWYewFwtVHi870QpDzMSjz /SNFewCtrE+qDK+sp2rDp2qpZ7qE8QwL1mZPANXHkdG0Xofo4fePl2KuhCWSgPXQkX2d 0Gn+NFfcrGllto75U7JlKc0rOWTFpsVRRq22UBeNCa/F6ODIpzg/QyKWlWkAwZBUbRPv 4ONw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=9SqjeGhuAMJ7wuriZp/WbKbDUhlsgnuGgI1yveTFoKo=; b=lBYVlfo3bBsGxI06YoSxI1P73twCi7yPeu+S3UKEk6OoMm9UBm+sAymgy8s2oPb0N/ XTZU2TivjeSL49a1XgCsBwGQyfWiCBJSeHwvLVr8nXdDD1lD1XcC3lC/ghcGBXQ0R2nd uKzGAZIfHo2UHXSbHIY141SaP3G3TNklkiNkW/huqYVXsuA4LrAjms8N4SWVItVkeYuc e5RVOwq3lrrZN7QgOPZL8SAanobvltIiN7CwASfQL+AqA4zR2Ucz7oqgmBdmCDa/Shad BOTM2sonbDbv+scIqlc2CJhV+hClxAIzR5wkVqwrUsaH9X6Q6E7Z+TNRQSFnJnOBwuag fTfQ==
X-Gm-Message-State: AEkoouskK9HqoZG3f1leuU969wtPxJVDjgc+kmSbfJvfX/+NFb2tcLW6+8+wRsjFSZzyoJCbhTVMc8KS2Vcfcg==
X-Received: by 10.31.72.6 with SMTP id v6mr17678337vka.106.1470232482035; Wed, 03 Aug 2016 06:54:42 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.176.4.78 with HTTP; Wed, 3 Aug 2016 06:54:41 -0700 (PDT)
From: Allison Mankin <allison.mankin@gmail.com>
Date: Wed, 03 Aug 2016 09:54:41 -0400
Message-ID: <CAP8yD=tyqViJQhNihPioxdGH8fP+eZ_Z4fwtzkTDrLxut1NmgA@mail.gmail.com>
Subject: TSV-ART review of draft-ietf-rtcweb-transports
To: IETF Discussion <ietf@ietf.org>, tsv-art@ietf.org, draft-ietf-rtcweb-transports@tools.ietf.org, "cullenfluffyjennings@gmail.com" <fluffy@cisco.com>, IESG <iesg@ietf.org>
Content-Type: multipart/alternative; boundary="001a114dc7e8d43d1205392b2c38"
Archived-At: <https://mailarchive.ietf.org/arch/msg/ietf/Kqa5hkNu5uDVgjDVpLqHyuimqeM>
Cc: amankin@salesforce.com
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ietf/>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Aug 2016 14:00:35 -0000

Hi,

I've reviewed this draft (draft-ietf-rtcpweb-transports-14.txt) as part of
the TSV Area Review Team, paying special attention to transport-related
concerns. Please take these as any other IETF last call comments.

Summary: this draft specifies the mandatory transport protocols (and
transport features) associated with the use of WebRTC media.  It does not
appear to pose any transport-related danger, except perhaps that a
reviewer's head aches over the number of RFCs that are needed to get media
bits from point A to point B, but this is not a fault of the draft.  The
draft is broadly ready for publication as a PS, however there are a few
issues for the Transport Area.

Section 3.4:

   If TCP connections are used, RTP framing according to [RFC4571
<https://tools.ietf.org/html/rfc4571>] MUST
   be used, both for the RTP packets and for the DTLS packets used to
   carry data channels.

About the passage above, RFC4571 doesn't talk about DTLS.  It looks like
this passage also needs a reference to whatever of the specs defines
framing for DTLS?

Section 4.1  Local Prioritization

This section describes the resource allocations that are expected for
prioritized different streams when there is congestion.  There are two
highly relevant congestion control documents that are approved (or nearly
so), and I can't see that the  RTCWB WG considered them from my quick
review of mailing list discussions, but it would be a good idea for this
draft to call them out:

draft-ietf-avtcore-rtp-circuit-breakers-17 - this has enough positions to
pass and is waiting for an AD followup (looks like for the IANA re-review
after a version change).  It puts some additional considerations on flows
that are likely to be relevant to the flows in the present draft.

draft-ietf-rmcat-cc-requirements-09 - this is in the RFC Editor queue and
seems to be waiting for the rtcweb-overview draft, to which it normatively
refers.  I think it would be better if the rmcat draft referenced
rtcweb-transpoarts, and if rtcweb-transports would check on its alignment
with the rmcat requirements in the congestion control remarks in section
4.1.

Section 4.2 Usage of Quality of Service - DSCP and Multiplexing

I will just flag here that I reviewed the mailing list and it seems that
there was a lot of TSV review of the DSCP material here already, and a
consensus reached.