RE: Review of draft-ietf-clue-rtp-mapping-10

Roni Even <roni.even@huawei.com> Wed, 11 January 2017 08:06 UTC

Return-Path: <roni.even@huawei.com>
X-Original-To: ietf@ietfa.amsl.com
Delivered-To: ietf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 31728129A69; Wed, 11 Jan 2017 00:06:07 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.42
X-Spam-Level:
X-Spam-Status: No, score=-7.42 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-3.199, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id B6kLyM9kUk70; Wed, 11 Jan 2017 00:06:05 -0800 (PST)
Received: from lhrrgout.huawei.com (lhrrgout.huawei.com [194.213.3.17]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 87F98129A65; Wed, 11 Jan 2017 00:06:04 -0800 (PST)
Received: from 172.18.7.190 (EHLO lhreml704-cah.china.huawei.com) ([172.18.7.190]) by lhrrg01-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id DEF33104; Wed, 11 Jan 2017 08:06:00 +0000 (GMT)
Received: from DGGEMM404-HUB.china.huawei.com (10.3.20.212) by lhreml704-cah.china.huawei.com (10.201.5.130) with Microsoft SMTP Server (TLS) id 14.3.301.0; Wed, 11 Jan 2017 08:05:59 +0000
Received: from DGGEMM506-MBX.china.huawei.com ([169.254.3.117]) by DGGEMM404-HUB.china.huawei.com ([10.3.20.212]) with mapi id 14.03.0301.000; Wed, 11 Jan 2017 16:05:53 +0800
From: Roni Even <roni.even@huawei.com>
To: =?utf-8?B?SsO8cmdlbiBTY2jDtm53w6RsZGVyIDxqLnNjaG9lbndhZWxkZXJAamFjQGll?= =?utf-8?B?dGZhLmFtc2wuY29t?= <=?utf-8?b?SsO8cmdlbiBTY2jDtm53w6RsZGVyIDxqLnNjaG9lbndhZWxkZXJAamFj?=@ietfa.amsl.com>, "ops-dir@ietf.org" <ops-dir@ietf.org>
Subject: RE: Review of draft-ietf-clue-rtp-mapping-10
Thread-Topic: Review of draft-ietf-clue-rtp-mapping-10
Thread-Index: AQHSZbeSRJ3tnTYULkWp18M9pC35/qEy8E8Q
Date: Wed, 11 Jan 2017 08:05:52 +0000
Message-ID: <6E58094ECC8D8344914996DAD28F1CCD76C149@DGGEMM506-MBX.china.huawei.com>
References: <148344421561.28040.10199222017103675571.idtracker@ietfa.amsl.com>
In-Reply-To: <148344421561.28040.10199222017103675571.idtracker@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.200.201.242]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A0B0206.5875E769.0327, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=169.254.3.117, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 27f2b505fe16ab95670489090cf3ec13
Archived-At: <https://mailarchive.ietf.org/arch/msg/ietf/Ns0SynIJ4WutJjHx-hfcGuSELNw>
Cc: "clue@ietf.org" <clue@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "draft-ietf-clue-rtp-mapping.all@ietf.org" <draft-ietf-clue-rtp-mapping.all@ietf.org>
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ietf/>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Jan 2017 08:06:07 -0000

Hi,
Thanks for the review
Inline
Roni

> -----Original Message-----
> From: =?utf-
> 8?b?SsO8cmdlbiBTY2jDtm53w6RsZGVyIDxqLnNjaG9lbndhZWxkZXJAamFj?=
> @ietfa.amsl.com [mailto:=?utf-
> 8?b?SsO8cmdlbiBTY2jDtm53w6RsZGVyIDxqLnNjaG9lbndhZWxkZXJAamFj?=
> @ietfa.amsl.com]
> Sent: יום ג 03 ינואר 2017 13:50
> To: ops-dir@ietf.org
> Cc: clue@ietf.org; ietf@ietf.org; draft-ietf-clue-rtp-mapping.all@ietf.org
> Subject: Review of draft-ietf-clue-rtp-mapping-10
> 
> Reviewer: Jürgen Schönwälder
> Review result: Has Nits
> 
> I do not see any major OPS related issues. While reading the document, I
> found a number of things the authors should look into:
> 
> - Consider to expand SDP and perhaps CLUE in the abstract
[Roni Even] OK
> 
> - Having both CaptureId and CaptureID in 5.1 is a bit confusing (since
>   the two identifiers only differ by the capitalization of the last
>   character)
[Roni Even] I will change it
> 
> - Both nXML mode in emacs and xmlint indicate that the xml in section
>   6 is invalid. Please check. (It could also be an issue with my tools
>   and the namespaces but then also the indentation looks at least
>   somewhat surprising.
[Roni Even] This are partial examples from the clue data model document just to show the relevant part. They were not meant to be valid xml , I can add text to explain this
> 
> - Is the RFC editor expected to	replace XX in the drawing in section
>   5.1 with the value assigned for TBA? If so, I think this needs to be
>   documented somewhere.
[Roni Even] OK
> 
> - Is 'roni.even@mail01.huawei.com' is a long term stable identifier
>   for the 'Contact' field of the RTP SDES Compact Header Extensions
>   subregistry?
[Roni Even] I will provide a better email address
> 
> - Security considerations, last	paragraph: What	is 'a lot of trust'?
>   Why is the SHOULD not	a MUST?
[Roni Even] I agree, it is also a passive language
Old text
"In multi-party communication scenarios using RTP Middleboxes, a lot of trust is placed on these middleboxes to preserve the sessions security"
New text
"In multi-party communication scenarios using RTP Middleboxes; these middleboxes are trusted to preserve the sessions security"

As for the "SHOULD maintain" it may depend on application policies (for example allowing users with different security levels into a multipoint conference)

> 
> - s/CaptureIDis/CaptureID is/g
[Roni Even] OK
> 
> - According to idnits, there are RFCs listed in the references that
>   are not cited in the text; please pay attention to idnits reports
[Roni Even] OK
>