Re: [Tsv-art] TSV-ART review of draft-ietf-rtcweb-transports

Colin Perkins <csp@csperkins.org> Thu, 04 August 2016 12:12 UTC

Return-Path: <csp@csperkins.org>
X-Original-To: ietf@ietfa.amsl.com
Delivered-To: ietf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A681A12DF2D; Thu, 4 Aug 2016 05:12:54 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.2
X-Spam-Level:
X-Spam-Status: No, score=-4.2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id S_qKlL5gH_Ia; Thu, 4 Aug 2016 05:12:50 -0700 (PDT)
Received: from balrog.mythic-beasts.com (balrog.mythic-beasts.com [IPv6:2a00:1098:0:82:1000:0:2:1]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6C39612DEC5; Thu, 4 Aug 2016 05:07:37 -0700 (PDT)
Received: from [2001:630:40:f00:12dd:b1ff:feca:b79b] (port=50043) by balrog.mythic-beasts.com with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.80) (envelope-from <csp@csperkins.org>) id 1bVHQw-0001Gt-C2; Thu, 04 Aug 2016 13:07:33 +0100
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
Subject: Re: [Tsv-art] TSV-ART review of draft-ietf-rtcweb-transports
From: Colin Perkins <csp@csperkins.org>
In-Reply-To: <45871F4C-2EE2-4185-B9EE-3D4E7F6E9D57@kuehlewind.net>
Date: Thu, 4 Aug 2016 13:07:27 +0100
Content-Transfer-Encoding: quoted-printable
Message-Id: <2FB5FED1-3C27-4692-A067-1FF1CB412BC1@csperkins.org>
References: <CAP8yD=tyqViJQhNihPioxdGH8fP+eZ_Z4fwtzkTDrLxut1NmgA@mail.gmail.com> <51F4D053-22C1-4F0E-ADEE-CCAF48B931E1@csperkins.org> <45871F4C-2EE2-4185-B9EE-3D4E7F6E9D57@kuehlewind.net>
To: "Mirja Kuehlewind (IETF)" <ietf@kuehlewind.net>
X-Mailer: Apple Mail (2.3124)
X-BlackCat-Spam-Score: -28
X-Mythic-Debug: Threshold = On =
Archived-At: <https://mailarchive.ietf.org/arch/msg/ietf/Q6815fkEhh7ZRMJZxra9RLagR7k>
Cc: Cullen Jennings <fluffy@cisco.com>, amankin@salesforce.com, IESG <iesg@ietf.org>, tsv-art@ietf.org, draft-ietf-rtcweb-transports@tools.ietf.org, IETF Discussion <ietf@ietf.org>
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ietf/>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Aug 2016 12:12:55 -0000

Hi,

> On 4 Aug 2016, at 13:03, Mirja Kuehlewind (IETF) <ietf@kuehlewind.net> wrote:
> 
> Hi Colin,
> 
> see below.
> 
>> Am 04.08.2016 um 12:00 schrieb Colin Perkins <csp@csperkins.org>rg>:
>> 
>> 
>>> On 3 Aug 2016, at 14:54, Allison Mankin <allison.mankin@gmail.com> wrote:
>>> 
>>> Hi,
>>> 
>>> I've reviewed this draft (draft-ietf-rtcpweb-transports-14.txt) as part of the TSV Area Review Team, paying special attention to transport-related concerns. Please take these as any other IETF last call comments.
>>> 
>>> Summary: this draft specifies the mandatory transport protocols (and transport features) associated with the use of WebRTC media.  It does not appear to pose any transport-related danger, except perhaps that a reviewer's head aches over the number of RFCs that are needed to get media bits from point A to point B, but this is not a fault of the draft.  The draft is broadly ready for publication as a PS, however there are a few issues for the Transport Area.
>>> 
>>> Section 3.4:
>>>  If TCP connections are used, RTP framing according to [RFC4571
>>> ] MUST
>>>  be used, both for the RTP packets and for the DTLS packets used to
>>>  carry data channels.
>>> 
>>> About the passage above, RFC4571 doesn't talk about DTLS.  It looks like this passage also needs a reference to whatever of the specs defines framing for DTLS? 
>>> 
>>> Section 4.1  Local Prioritization
>>> 
>>> This section describes the resource allocations that are expected for prioritized different streams when there is congestion.  There are two highly relevant congestion control documents that are approved (or nearly so), and I can't see that the  RTCWB WG considered them from my quick review of mailing list discussions, but it would be a good idea for this draft to call them out:
>>> 
>>> draft-ietf-avtcore-rtp-circuit-breakers-17 - this has enough positions to pass and is waiting for an AD followup (looks like for the IANA re-review after a version change).  It puts some additional considerations on flows that are likely to be relevant to the flows in the present draft.
>> 
>> This is listed as “MUST implement” in draft-ietf-rtcweb-rtp-usage-26, which is referenced from Section 3.5 of the rtcweb-transport draft. 
>> 
>> Colin
> 
> rtcweb-transport says 
> "For transport of media, secure RTP is used.  The details of the profile of RTP used are described in "RTP Usage“ [I-D.ietf-rtcweb-rtp-usage]."
> 
> Given that this doc is called "Transports for WebRTC“, I would appreciate if it says slightly more about the recommendations given in rtcweb-rtp-usage, especialy regarding congestion control.
> 
> What’s about the following?
> 
> "For transport of media, secure RTP is used.  The details of the profile of RTP used are described in "RTP Usage“ [I-D.ietf-rtcweb-rtp-usage], which mandates the use of a circuit breaker [draft-ietf-avtcore-rtp-circuit-breakers-17] and congestion control (see [draft-ietf-rmcat-cc-requirements-09] for further guidance).“

No objection, but it’s not my draft to make the change. 

-- 
Colin Perkins
https://csperkins.org/