Re: Review of draft-hardie-privsec-metadata-insertion-05

Ted Hardie <ted.ietf@gmail.com> Wed, 22 February 2017 21:59 UTC

Return-Path: <ted.ietf@gmail.com>
X-Original-To: ietf@ietfa.amsl.com
Delivered-To: ietf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EF3EC129BF3; Wed, 22 Feb 2017 13:59:14 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.699
X-Spam-Level:
X-Spam-Status: No, score=-2.699 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 43JhWEWaeT9q; Wed, 22 Feb 2017 13:59:13 -0800 (PST)
Received: from mail-oi0-x22f.google.com (mail-oi0-x22f.google.com [IPv6:2607:f8b0:4003:c06::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3DF54129BF0; Wed, 22 Feb 2017 13:59:13 -0800 (PST)
Received: by mail-oi0-x22f.google.com with SMTP id s205so8813569oif.3; Wed, 22 Feb 2017 13:59:13 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=mOOUYf2NZ+i3gfMTVySGw6jYt0lmGd0UZsTpLt6kPqE=; b=OQZePFmv4mwlEyhtwWti7GbyAct/XZzQGp23Yofoypvd6AHmPibb6nSHvWiypxK7Bk G0xftgqCqNXey5l9VIvXuyD/f4i15YOCiIJNvmQ8hHF0QFINZCI6eJXZktaaWfXzBBeR 4NpvJAVqL/8ChJv+HicPZWQmjtNLTDSd7kUVds9kKuihgO7v5BzDFzKt8DZJU8ZF7F33 8kMAc0hatW8GhFYuqVH2Sa9/hzf6ssvOHC8T8pzHCfuyYi7NRXwma72Gd7jNRs47zZLL U93U69uDN9WnGEhBCj32mOLJoukdIPIaTsULZU34pcPae9XF4vakCWqY4gmLJCPT3uFd 57Hw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=mOOUYf2NZ+i3gfMTVySGw6jYt0lmGd0UZsTpLt6kPqE=; b=OPNUi56NbD4fu2RLRG7LwwkFIpndmN4vjhM6phsByETKSZLQxxsi61TMc7UK9fN0lL LiKQeDpDpsv/VR2ZmECCy/iWaZhINZc1rtrBV9yTFVM7hhTT/LwxJv1TJUXGFMveoVRI dyFvlAykPRbEmtiGlHU3OsJ+SFgumIpdIlneoTprucLJxUahJ3Cx4Rf9D+9Q4xLEwbkd MclHBHODHB8goDP27AZNbTcTXn5fNxx6z4ocoOJm738Vap5kMtfKr4OinwJIAhr4pskQ 0aPoRHS8lBXinbgl0mBEZKnMOeMbPJoQlQIa3n3m5VrYBxjsXdBRatlNfw9mkjjmiGz0 PghA==
X-Gm-Message-State: AMke39kczSwPxPrGs3Y8KUzO6UaYjonPXhkvj7blj4DSBdmjKlE+31FHpY7aTwK3Fwor7K+VSYelHG6ynVEl8g==
X-Received: by 10.202.72.2 with SMTP id v2mr5435370oia.179.1487800752356; Wed, 22 Feb 2017 13:59:12 -0800 (PST)
MIME-Version: 1.0
Received: by 10.74.142.85 with HTTP; Wed, 22 Feb 2017 13:58:42 -0800 (PST)
In-Reply-To: <148559843419.17936.4314684504467085961.idtracker@ietfa.amsl.com>
References: <148559843419.17936.4314684504467085961.idtracker@ietfa.amsl.com>
From: Ted Hardie <ted.ietf@gmail.com>
Date: Wed, 22 Feb 2017 13:58:42 -0800
Message-ID: <CA+9kkMBb93qg9NccNkNpn2=sJdfgqE8=MccVz6zWf4MNccGfvQ@mail.gmail.com>
Subject: Re: Review of draft-hardie-privsec-metadata-insertion-05
To: Stewart Bryant <stewart@g3ysx.org.uk>
Content-Type: multipart/alternative; boundary="001a113e4eac57444a0549259b84"
Archived-At: <https://mailarchive.ietf.org/arch/msg/ietf/QtlwLJwX4GWvzBdJwFogBRrZFj4>
Cc: gen-art@ietf.org, IETF <ietf@ietf.org>, draft-hardie-privsec-metadata-insertion.all@ietf.org
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ietf/>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Feb 2017 21:59:15 -0000

Hi Stewart,

Thanks for the review.  I've updated the abstract, removed the vestigial
reference, added a reference for EDNS0 and clarified how it is used in the
design I describe.

Thanks again for your attention to it,

Ted

On Sat, Jan 28, 2017 at 2:13 AM, Stewart Bryant <stewart@g3ysx.org.uk>
wrote:

> Reviewer: Stewart Bryant
> Review result: Ready with Nits
>
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
>
> For more information, please see the FAQ at
>
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
>
> Document: draft-hardie-privsec-metadata-insertion-??
> Reviewer: Stewart Bryant
> Review Date: 2017-01-28
> IETF LC End Date: 2017-02-21
> IESG Telechat date: Not scheduled for a telechat
>
> Summary: This is a well written document with a couple of nits. It
> would be helpful to the reader interested in the concept, but
> unfamiliar with DNS if there was some minor additional clarification
> regarding  EDNS0.
>
> Major issues: None
>
> Minor issues:
>
> RFC4301 is an unused reference. Is it missing from the text?
>
> =====
>
>    By negotiating an EDNS0
>    option which allowed them to self-populate this data,.....
>
> SB> Calling up EDNS0 (which really needs expanding) comes out of the
> SB> blue and could use a reference and sentence of explanation
> SB> at least for those not familiar with the detail of DNS.
>
> Nits/editorial comments:
>
> [RFC7624] in the Abstract should be changed to RFC7624
>
> =========
>
> 1.  Introduction
> ....
>    exploited in the attacks document in [RFC7258] and the threats
> s/document/documented/
>
>
>