RE: TSV-ART review of draft-ietf-core-coap-tcp-tls-07

Brian Raymor <Brian.Raymor@microsoft.com> Thu, 20 April 2017 19:31 UTC

Return-Path: <Brian.Raymor@microsoft.com>
X-Original-To: ietf@ietfa.amsl.com
Delivered-To: ietf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B6D4E1315BF; Thu, 20 Apr 2017 12:31:43 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.802
X-Spam-Level:
X-Spam-Status: No, score=-4.802 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-2.8, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=microsoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qfttccClCqb1; Thu, 20 Apr 2017 12:31:41 -0700 (PDT)
Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0129.outbound.protection.outlook.com [104.47.41.129]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 19EF21315FD; Thu, 20 Apr 2017 12:31:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=gZQXEn5AMfW0SBRFJEmxpLjuTJxdKqTjytB5LVLRDiE=; b=SD6+8mXBtOaz/KX0yX0mbAUC9HcBxzUb79V7N2m707E74qAOVlsuq7DBrL1jOL8I9REXm2RL6FEOK54Zf8HrooN6eU5JPr5FrcdX8dokihbG9dxGXYBC/YRn9OsGvTTSFCOtmb19HV1a27pZnX+DOXMkzWT5yF1s1uTZR9GojiU=
Received: from BY2PR21MB0084.namprd21.prod.outlook.com (10.162.78.141) by BY2PR21MB0083.namprd21.prod.outlook.com (10.162.78.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1061.1; Thu, 20 Apr 2017 19:31:38 +0000
Received: from BY2PR21MB0084.namprd21.prod.outlook.com ([10.162.78.141]) by BY2PR21MB0084.namprd21.prod.outlook.com ([10.162.78.141]) with mapi id 15.01.1061.003; Thu, 20 Apr 2017 19:31:38 +0000
From: Brian Raymor <Brian.Raymor@microsoft.com>
To: Yoshifumi Nishida <nishida@sfc.wide.ad.jp>, "tsv-art@ietf.org" <tsv-art@ietf.org>
CC: "draft-ietf-core-coap-tcp-tls@ietf.org" <draft-ietf-core-coap-tcp-tls@ietf.org>, "core@ietf.org" <core@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>
Subject: RE: TSV-ART review of draft-ietf-core-coap-tcp-tls-07
Thread-Topic: TSV-ART review of draft-ietf-core-coap-tcp-tls-07
Thread-Index: AQHSsOTWicthTbHq+0Cl6wEpb6SnVKHOtjQA
Date: Thu, 20 Apr 2017 19:31:38 +0000
Message-ID: <BY2PR21MB0084E781B2831EBC6A5F4E88831B0@BY2PR21MB0084.namprd21.prod.outlook.com>
References: <CAO249ye7KNdcbQfmOfik7QYFiXS9zcTE5n19pngHLgeur2XFpg@mail.gmail.com>
In-Reply-To: <CAO249ye7KNdcbQfmOfik7QYFiXS9zcTE5n19pngHLgeur2XFpg@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: sfc.wide.ad.jp; dkim=none (message not signed) header.d=none;sfc.wide.ad.jp; dmarc=none action=none header.from=microsoft.com;
x-originating-ip: [174.61.159.182]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; BY2PR21MB0083; 7:rWzV/MddUNs53nBT3v6eGgbIIJPr5ZooUjY/MeGMkEDdnhAHkAeKvWBaM3vIv0cezKcqstjTqSUfN0du9Mtvhk3B7rx2cl0LMo3CuYX9Dh8odSWtHv72Ve0ATl7skOsq+VHXhvN+SyASxUOHRTTVizyjjPirFFmU+3K3yItnGeIGYgfy4cJ9KhFxNpHvrwj54fQrUwzGEhwoA98fjMp8DPeMx7lv+9xyr3ORNkWWW40gojujKt4mBaIMMMOVdvcg9S9TA4kbXt3Im1issFqb3scQlYbhcfL9X6LzqMwQsyCzf0qwZ2WmvGeZMNtKCvlqSgmNdJSZhv0ooxyns9/GFn5J4mNizUL6gaS0Zpzy9oo=
x-ms-office365-filtering-correlation-id: de05cb43-ed75-4b8d-6352-08d48823dd64
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081); SRVR:BY2PR21MB0083;
x-microsoft-antispam-prvs: <BY2PR21MB00831A56E423A03E46C59804831B0@BY2PR21MB0083.namprd21.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(166708455590820);
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(61425038)(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(6055026)(61426038)(61427038)(6041248)(20161123562025)(20161123555025)(20161123558043)(201703131423075)(201702281528075)(201703061421075)(201703061406096)(20161123564025)(20161123560025)(6072148); SRVR:BY2PR21MB0083; BCL:0; PCL:0; RULEID:; SRVR:BY2PR21MB0083;
x-forefront-prvs: 02830F0362
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(39410400002)(39850400002)(39860400002)(39450400003)(39400400002)(39840400002)(6436002)(6116002)(50986999)(55016002)(54906002)(74316002)(99286003)(38730400002)(6506006)(66066001)(4326008)(6246003)(2900100001)(53936002)(76176999)(9686003)(8676002)(6306002)(8936002)(81166006)(54356999)(3846002)(7736002)(7696004)(5660300001)(305945005)(25786009)(102836003)(2950100002)(77096006)(10090500001)(5005710100001)(33656002)(86362001)(3660700001)(2906002)(3280700002)(2501003)(122556002)(189998001)(10290500002); DIR:OUT; SFP:1102; SCL:1; SRVR:BY2PR21MB0083; H:BY2PR21MB0084.namprd21.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en;
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2017 19:31:38.2636 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR21MB0083
Archived-At: <https://mailarchive.ietf.org/arch/msg/ietf/_56XKwqL-TUYou0KNZs_-MD9UbU>
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ietf/>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Apr 2017 19:31:44 -0000

Thanks for your feedback.

> 1: It is not clear how the protocol reacts the errors from transport layers (e.g. connection failure).
>    The protocol will just inform apps of the events and the app will decide what to do or the protocol itself will do something?

The WebSockets case is addressed by RFC6455:

   When the underlying TCP connection is closed, it is said that _The
   WebSocket Connection is Closed_ and that the WebSocket connection is
   in the CLOSED state.  If the TCP connection was closed after the
   WebSocket closing handshake was completed, the WebSocket connection
   is said to have been closed _cleanly_.

-and-

   If at any point the underlying transport layer connection is
   unexpectedly lost, the client MUST _Fail the WebSocket Connection_.

It's possible to add language similar to the abort case, along the lines of "When the underlying TCP connection is closed or reset, the CoAP connection is closed and in flight messages may be lost".

> 2: There will be situations where the app layer is freezing while the 
> transport layer is still working. Since transport layers cannot detect 
> this type of failures, there should be some mechanisms for it somewhere in the protocol or in the app layer.  The doc needs to address
> this point. For example, what will happen when a PONG message is not returned for a certain amount of time?

PONG is modeled on similar mechanisms in RFC6455 and RFC7540. Neither provides any guidance for this case. It's expected that an application framework would define and enforce the appropriate policy for timeouts or retries.
 
> 3: Since this draft defines new SZX value, I think the doc needs to update RFC7959. This point should be clarified more in the doc.

Carsten responded to this issue and the final exchange is here - https://www.ietf.org/mail-archive/web/core/current/msg08562.html 

My sense is that we should treat this as an update to RFC7959 based on the original language:

     The value 7 for SZX (which would
      indicate a block size of 2048) is reserved, i.e., MUST NOT be sent
      and MUST lead to a 4.00 Bad Request response code upon reception
      in a request.

and the use of "extension" in coap-tcp-tls:

    The ’Block-wise Extension for Reliable Transport (BERT)’ extends the Block protocol
    to enable the use of larger messages over a reliable transport.

The existing IANA entries for Block1 and Block2 will also need to reference coap-tcp-tls in addition to RFC7959.

Tracking in https://github.com/core-wg/coap-tcp-tls/issues/129