Gen-ART LC Review of draft-ietf-ipfix-data-link-layer-monitoring-06

Ben Campbell <ben@nostrum.com> Tue, 22 October 2013 22:36 UTC

Return-Path: <ben@nostrum.com>
X-Original-To: ietf@ietfa.amsl.com
Delivered-To: ietf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 61DD911E81BA; Tue, 22 Oct 2013 15:36:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -102.144
X-Spam-Level:
X-Spam-Status: No, score=-102.144 tagged_above=-999 required=5 tests=[AWL=0.456, BAYES_00=-2.599, SPF_PASS=-0.001, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tfyDwfmq4QyK; Tue, 22 Oct 2013 15:36:37 -0700 (PDT)
Received: from shaman.nostrum.com (nostrum-pt.tunnel.tserv2.fmt.ipv6.he.net [IPv6:2001:470:1f03:267::2]) by ietfa.amsl.com (Postfix) with ESMTP id B776B11E82A5; Tue, 22 Oct 2013 15:36:25 -0700 (PDT)
Received: from [10.0.1.29] (cpe-173-172-146-58.tx.res.rr.com [173.172.146.58]) (authenticated bits=0) by shaman.nostrum.com (8.14.3/8.14.3) with ESMTP id r9MMaNaJ068860 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Tue, 22 Oct 2013 17:36:24 -0500 (CDT) (envelope-from ben@nostrum.com)
From: Ben Campbell <ben@nostrum.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Subject: Gen-ART LC Review of draft-ietf-ipfix-data-link-layer-monitoring-06
Date: Tue, 22 Oct 2013 17:36:25 -0500
Message-Id: <877E63A6-07D1-45C3-93EA-086871A8ADE7@nostrum.com>
To: draft-ietf-ipfix-data-link-layer-monitoring.all@tools.ietf.org
Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\))
X-Mailer: Apple Mail (2.1510)
Received-SPF: pass (shaman.nostrum.com: 173.172.146.58 is authenticated by a trusted mechanism)
Cc: "gen-art@ietf.org Team (gen-art@ietf.org)" <gen-art@ietf.org>, "ietf@ietf.org list" <ietf@ietf.org>
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/ietf>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Oct 2013 22:36:38 -0000

I am the assigned Gen-ART reviewer for this draft. For background on
Gen-ART, please see the FAQ at

<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Please resolve these comments along with any other Last Call comments
you may receive.

Document: draft-ietf-ipfix-data-link-layer-monitoring-06
Reviewer: Ben Campbell
Review Date: 2013-22-10
IETF LC End Date: 2013-23-10

Summary: Ready for publication as a proposed standard, with  one problem that should be easily fixed.

Major issues:

None

Minor issues:

3.2.18:

Title of the data element suggests a total, but the description sounds like a delta (i.e change since last report.)

-- section 4 and subsections

It looks like this draft updates at least RFC5477. If so, this should be indicated in the header and in the abstract.



Nits/editorial comments:

-- section , 3rd paragraph:

Do you mean to say the existing data models do not contain the elements needed, or that the models do not provide the right foundation for the needed elements? The wording seems to indicate the latter but I think you mean the former.

-- General:
Watch for missing articles.